Filip/playwright
1
0
Fork 0
Code Issues Pull requests Actions Packages Projects Releases Wiki Activity

fix(ui-mode): use onChange instead of onClick for <input type='checkbox' (#33636)

Browse source
This commit is contained in:
Max Schmitt 2024-11-18 10:21:28 +01:00 committed by GitHub
parent 82c77a5e9e
commit 6fce5620e0
No known key found for this signature in database
GPG key ID: B5690EEEBB952194
2 changed files with 3 additions and 3 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

2
packages/trace-viewer/src/ui/settingsView.tsx
View file

@ -30,7 +30,7 @@ export const SettingsView: React.FunctionComponent<{
{settings.map(({ value, set, title }) => { {settings.map(({ value, set, title }) => {
return <div key={title} className='setting'> return <div key={title} className='setting'>
<label> <label>
<input type='checkbox' checked={value} onClick={() => set(!value)}/> <input type='checkbox' checked={value} onChange={() => set(!value)}/>
{title} {title}
</label> </label>
</div>; </div>;

4
packages/trace-viewer/src/ui/uiModeFiltersView.tsx
View file

@ -62,7 +62,7 @@ export const FiltersView: React.FC<{
{[...statusFilters.entries()].map(([status, value]) => { {[...statusFilters.entries()].map(([status, value]) => {
return <div className='filter-entry' key={status} role='listitem'> return <div className='filter-entry' key={status} role='listitem'>
<label> <label>
<input type='checkbox' checked={value} onClick={() => { <input type='checkbox' checked={value} onChange={() => {
const copy = new Map(statusFilters); const copy = new Map(statusFilters);
copy.set(status, !copy.get(status)); copy.set(status, !copy.get(status));
setStatusFilters(copy); setStatusFilters(copy);
@ -76,7 +76,7 @@ export const FiltersView: React.FC<{
{[...projectFilters.entries()].map(([projectName, value]) => { {[...projectFilters.entries()].map(([projectName, value]) => {
return <div className='filter-entry' key={projectName} role='listitem'> return <div className='filter-entry' key={projectName} role='listitem'>
<label> <label>
<input type='checkbox' checked={value} onClick={() => { <input type='checkbox' checked={value} onChange={() => {
const copy = new Map(projectFilters); const copy = new Map(projectFilters);
copy.set(projectName, !copy.get(projectName)); copy.set(projectName, !copy.get(projectName));
setProjectFilters(copy); setProjectFilters(copy);