Filip/playwright
1
0
Fork 0
Code Issues Pull requests Actions Packages Projects Releases Wiki Activity

Revert "chore(driver): roll driver to recent Node.js LTS version (#18… (#18791)

Browse source 
…636)"

The new node resolves loalhost to ::1 by default which breaks API tests
in the ports (Java in particular). Reverting to the previous LTS to
allow some time to implement happy eyeballs algorithm on our end by next
release.

This reverts commit 63a0b75186.
Reference https://github.com/microsoft/playwright/issues/18790
This commit is contained in:
Yury Semikhatsky 2022-11-14 11:30:36 -08:00 committed by GitHub
parent 1e309f375a
commit 70065ba6dd
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
4 changed files with 6 additions and 6 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

2
utils/build/build-playwright-driver.sh
View file

@ -4,7 +4,7 @@ set -x
trap "cd $(pwd -P)" EXIT trap "cd $(pwd -P)" EXIT
SCRIPT_PATH="$(cd "$(dirname "$0")" ; pwd -P)" SCRIPT_PATH="$(cd "$(dirname "$0")" ; pwd -P)"
NODE_VERSION="18.12.1" # autogenerated via ./update-playwright-driver-version.mjs NODE_VERSION="16.18.0" # autogenerated via ./update-playwright-driver-version.mjs
cd "$(dirname "$0")" cd "$(dirname "$0")"
PACKAGE_VERSION=$(node -p "require('../../package.json').version") PACKAGE_VERSION=$(node -p "require('../../package.json').version")

4
utils/docker/Dockerfile.focal
View file

@ -7,9 +7,9 @@ ARG DOCKER_IMAGE_NAME_TEMPLATE="mcr.microsoft.com/playwright:v%version%-focal"
# === INSTALL Node.js === # === INSTALL Node.js ===
RUN apt-get update && \ RUN apt-get update && \
# Install node18 # Install node16
apt-get install -y curl wget gpg && \ apt-get install -y curl wget gpg && \
curl -sL https://deb.nodesource.com/setup_18.x | bash - && \ curl -sL https://deb.nodesource.com/setup_16.x | bash - && \
apt-get install -y nodejs && \ apt-get install -y nodejs && \
# Feature-parity with node.js base images. # Feature-parity with node.js base images.
apt-get install -y --no-install-recommends git openssh-client && \ apt-get install -y --no-install-recommends git openssh-client && \

4
utils/docker/Dockerfile.jammy
View file

@ -7,9 +7,9 @@ ARG DOCKER_IMAGE_NAME_TEMPLATE="mcr.microsoft.com/playwright:v%version%-jammy"
# === INSTALL Node.js === # === INSTALL Node.js ===
RUN apt-get update && \ RUN apt-get update && \
# Install node18 # Install node16
apt-get install -y curl wget gpg && \ apt-get install -y curl wget gpg && \
curl -sL https://deb.nodesource.com/setup_18.x | bash - && \ curl -sL https://deb.nodesource.com/setup_16.x | bash - && \
apt-get install -y nodejs && \ apt-get install -y nodejs && \
# Feature-parity with node.js base images. # Feature-parity with node.js base images.
apt-get install -y --no-install-recommends git openssh-client && \ apt-get install -y --no-install-recommends git openssh-client && \

2
utils/linux-browser-dependencies/inside_docker/process.sh
View file

@ -5,7 +5,7 @@ set +x
# Install Node.js # Install Node.js
apt-get update && apt-get install -y curl && \ apt-get update && apt-get install -y curl && \
curl -sL https://deb.nodesource.com/setup_18.x | bash - && \ curl -sL https://deb.nodesource.com/setup_16.x | bash - && \
apt-get install -y nodejs apt-get install -y nodejs
# Install apt-file # Install apt-file