From 702536d96212a69e27e3e8e18a26c282ee26b08a Mon Sep 17 00:00:00 2001 From: "github-actions[bot]" <41898282+github-actions[bot]@users.noreply.github.com> Date: Sun, 6 Mar 2022 12:22:47 +0100 Subject: [PATCH] feat(webkit): roll to r1616 (#12541) Co-authored-by: github-actions <41898282+github-actions[bot]@users.noreply.github.com> Co-authored-by: Yury Semikhatsky --- packages/playwright-core/browsers.json | 2 +- .../src/server/webkit/protocol.d.ts | 30 +++++++++++++++++++ .../assets/modernizr/mobile-safari-14-1.json | 2 +- tests/assets/modernizr/safari-14-1.json | 2 +- tests/page/elementhandle-press.spec.ts | 3 +- tests/page/elementhandle-type.spec.ts | 3 +- 6 files changed, 37 insertions(+), 5 deletions(-) diff --git a/packages/playwright-core/browsers.json b/packages/playwright-core/browsers.json index a24c5402a6..dc7279453a 100644 --- a/packages/playwright-core/browsers.json +++ b/packages/playwright-core/browsers.json @@ -23,7 +23,7 @@ }, { "name": "webkit", - "revision": "1611", + "revision": "1616", "installByDefault": true, "revisionOverrides": { "mac10.14": "1446" diff --git a/packages/playwright-core/src/server/webkit/protocol.d.ts b/packages/playwright-core/src/server/webkit/protocol.d.ts index 0b980bb010..adeca1940f 100644 --- a/packages/playwright-core/src/server/webkit/protocol.d.ts +++ b/packages/playwright-core/src/server/webkit/protocol.d.ts @@ -2909,6 +2909,32 @@ export module Protocol { } export type hideGridOverlayReturnValue = { } + /** + * Shows a flex overlay for a node that begins a 'flex' layout context. The command has no effect if nodeId is invalid or the associated node does not begin a 'flex' layout context. A node can only have one flex overlay at a time; subsequent calls with the same nodeId will override earlier calls. + */ + export type showFlexOverlayParameters = { + /** + * The node for which a flex overlay should be shown. + */ + nodeId: NodeId; + /** + * The primary color to use for the flex overlay. + */ + flexColor: RGBAColor; + } + export type showFlexOverlayReturnValue = { + } + /** + * Hides a flex overlay for a node that begins a 'flex' layout context. The command has no effect if nodeId is specified and invalid, or if there is not currently an overlay set for the nodeId. + */ + export type hideFlexOverlayParameters = { + /** + * The node for which a flex overlay should be hidden. If a nodeId is not specified, all flex overlays will be hidden. + */ + nodeId?: NodeId; + } + export type hideFlexOverlayReturnValue = { + } /** * Requests that the node is sent to the caller given its path. */ @@ -8895,6 +8921,8 @@ the top of the viewport and Y increases as it proceeds towards the bottom of the "DOM.highlightFrame": DOM.highlightFrameParameters; "DOM.showGridOverlay": DOM.showGridOverlayParameters; "DOM.hideGridOverlay": DOM.hideGridOverlayParameters; + "DOM.showFlexOverlay": DOM.showFlexOverlayParameters; + "DOM.hideFlexOverlay": DOM.hideFlexOverlayParameters; "DOM.pushNodeByPathToFrontend": DOM.pushNodeByPathToFrontendParameters; "DOM.resolveNode": DOM.resolveNodeParameters; "DOM.getAttributes": DOM.getAttributesParameters; @@ -9193,6 +9221,8 @@ the top of the viewport and Y increases as it proceeds towards the bottom of the "DOM.highlightFrame": DOM.highlightFrameReturnValue; "DOM.showGridOverlay": DOM.showGridOverlayReturnValue; "DOM.hideGridOverlay": DOM.hideGridOverlayReturnValue; + "DOM.showFlexOverlay": DOM.showFlexOverlayReturnValue; + "DOM.hideFlexOverlay": DOM.hideFlexOverlayReturnValue; "DOM.pushNodeByPathToFrontend": DOM.pushNodeByPathToFrontendReturnValue; "DOM.resolveNode": DOM.resolveNodeReturnValue; "DOM.getAttributes": DOM.getAttributesReturnValue; diff --git a/tests/assets/modernizr/mobile-safari-14-1.json b/tests/assets/modernizr/mobile-safari-14-1.json index 58fd04c6e6..1391463a4b 100644 --- a/tests/assets/modernizr/mobile-safari-14-1.json +++ b/tests/assets/modernizr/mobile-safari-14-1.json @@ -183,7 +183,7 @@ "websocketsbinary": true, "atobbtoa": true, "atob-btoa": true, - "sharedworkers": false, + "sharedworkers": true, "bdi": true, "xhrresponsetypearraybuffer": true, "xhrresponsetypeblob": true, diff --git a/tests/assets/modernizr/safari-14-1.json b/tests/assets/modernizr/safari-14-1.json index dde865a164..55373b37f8 100644 --- a/tests/assets/modernizr/safari-14-1.json +++ b/tests/assets/modernizr/safari-14-1.json @@ -183,7 +183,7 @@ "websocketsbinary": true, "atobbtoa": true, "atob-btoa": true, - "sharedworkers": false, + "sharedworkers": true, "bdi": true, "xhrresponsetypearraybuffer": true, "xhrresponsetypeblob": true, diff --git a/tests/page/elementhandle-press.spec.ts b/tests/page/elementhandle-press.spec.ts index 2e0a3ce934..e4cb023e41 100644 --- a/tests/page/elementhandle-press.spec.ts +++ b/tests/page/elementhandle-press.spec.ts @@ -51,7 +51,8 @@ it('should not modify selection when focused', async ({ page }) => { expect(await page.$eval('input', input => input.value)).toBe('hewo'); }); -it('should work with number input', async ({ page }) => { +it('should work with number input', async ({ page, browserName }) => { + it.fail(browserName === 'webkit', 'Started failing after https://github.com/WebKit/WebKit/commit/c92a2aea185d63b5e9998608a9c0321a461c496c'); await page.setContent(``); await page.press('input', '1'); expect(await page.$eval('input', input => input.value)).toBe('12'); diff --git a/tests/page/elementhandle-type.spec.ts b/tests/page/elementhandle-type.spec.ts index a54b348db9..1514d32f21 100644 --- a/tests/page/elementhandle-type.spec.ts +++ b/tests/page/elementhandle-type.spec.ts @@ -51,7 +51,8 @@ it('should not modify selection when focused', async ({ page }) => { expect(await page.$eval('input', input => input.value)).toBe('heworldo'); }); -it('should work with number input', async ({ page }) => { +it('should work with number input', async ({ page, browserName }) => { + it.fail(browserName === 'webkit', 'Started failing after https://github.com/WebKit/WebKit/commit/c92a2aea185d63b5e9998608a9c0321a461c496c'); await page.setContent(``); await page.type('input', '13'); expect(await page.$eval('input', input => input.value)).toBe('132');