Filip/playwright
1
0
Fork 0
Code Issues Pull requests Actions Packages Projects Releases Wiki Activity

cherry-pick(#32880): chore: unflake 'should record'

Browse source
This commit is contained in:
Max Schmitt 2024-09-30 20:33:37 +02:00
parent d3e38c32af
commit 7155356e3c
2 changed files with 3 additions and 1 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

2
packages/playwright-core/src/server/recorder/recorderCollection.ts
View file

@ -126,6 +126,8 @@ export class RecorderCollection extends EventEmitter {
}
private _fireChange() {
if (!this._enabled)
return;
this.emit('change', collapseActions(this._actions));
}
}

2
tests/library/debug-controller.spec.ts
View file

@ -188,9 +188,9 @@ test('test', async ({ page }) => {
await page.getByRole('button', { name: 'Submit' }).click();
});`
});
const length = events.length;
// No events after mode disabled
await backend.setRecorderMode({ mode: 'none' });
const length = events.length;
await page.getByRole('button').click();
expect(events).toHaveLength(length);
});