Filip/playwright
1
0
Fork 0
Code Issues Pull requests Actions Packages Projects Releases Wiki Activity

fix: exception in exposeFunction when oopif detaches (#18078)

Browse source 
The test is racy but it was reliably failing several times in 100
iterations.

Fixes https://github.com/microsoft/playwright/issues/18067
This commit is contained in:
Yury Semikhatsky 2022-10-14 08:37:42 -07:00 committed by GitHub
parent 1c1060e85b
commit 7219a68b12
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
2 changed files with 11 additions and 1 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

2
packages/playwright-core/src/server/chromium/crPage.ts
View file

@ -133,7 +133,7 @@ export class CRPage implements PageDelegate {
return cb(frameSession); return cb(frameSession);
return cb(frameSession).catch(e => { return cb(frameSession).catch(e => {
// Broadcasting a message to the closed iframe shoule be a noop. // Broadcasting a message to the closed iframe shoule be a noop.
if (e.message && (e.message.includes('Target closed.') || e.message.includes('Session closed.'))) if (e.message && e.message.includes('Target closed'))
return; return;
throw e; throw e;
}); });

10
tests/library/chromium/oopif.spec.ts
View file

@ -326,6 +326,16 @@ it('should emit filechooser event for iframe', async ({ page, server, browser })
expect(chooser).toBeTruthy(); expect(chooser).toBeTruthy();
}); });
it('should not throw on exposeFunction when oopif detaches', async ({ page, browser, server }) => {
await page.goto(server.PREFIX + '/dynamic-oopif.html');
expect(await countOOPIFs(browser)).toBe(1);
await Promise.all([
page.exposeFunction('myFunc', () => 2022),
page.evaluate(() => document.querySelector('iframe').remove()),
]);
expect(await page.evaluate(() => (window as any).myFunc())).toBe(2022);
});
async function countOOPIFs(browser) { async function countOOPIFs(browser) {
const browserSession = await browser.newBrowserCDPSession(); const browserSession = await browser.newBrowserCDPSession();
const oopifs = []; const oopifs = [];