Filip/playwright
1
0
Fork 0
Code Issues Pull requests Actions Packages Projects Releases Wiki Activity

feat(webkit): bump to 1385 (#4430)

Browse source
This commit is contained in:
Yury Semikhatsky 2020-11-13 16:29:20 -08:00 committed by GitHub
parent 914c6eec23
commit 732e83f48d
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
5 changed files with 75 additions and 62 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

2
browsers.json
View file

@ -13,7 +13,7 @@
}, },
{ {
"name": "webkit", "name": "webkit",
"revision": "1383", "revision": "1385",
"download": true "download": true
} }
] ]

4
src/server/webkit/protocol.ts
View file

@ -1415,7 +1415,7 @@ export module Protocol {
/** /**
* Channels for different types of log messages. * Channels for different types of log messages.
*/ */
export type ChannelSource = "xml"|"javascript"|"network"|"console-api"|"storage"|"appcache"|"rendering"|"css"|"security"|"content-blocker"|"media"|"mediasource"|"webrtc"|"itp-debug"|"ad-click-attribution"|"other"; export type ChannelSource = "xml"|"javascript"|"network"|"console-api"|"storage"|"appcache"|"rendering"|"css"|"security"|"content-blocker"|"media"|"mediasource"|"webrtc"|"itp-debug"|"private-click-measurement"|"other";
/** /**
* Level of logging. * Level of logging.
*/ */
@ -5826,7 +5826,7 @@ the top of the viewport and Y increases as it proceeds towards the bottom of the
/** /**
* List of settings able to be overridden by WebInspector. * List of settings able to be overridden by WebInspector.
*/ */
export type Setting = "AdClickAttributionDebugModeEnabled"|"AuthorAndUserStylesEnabled"|"ICECandidateFilteringEnabled"|"ITPDebugModeEnabled"|"ImagesEnabled"|"MediaCaptureRequiresSecureConnection"|"MockCaptureDevicesEnabled"|"NeedsSiteSpecificQuirks"|"ScriptEnabled"|"ShowDebugBorders"|"ShowRepaintCounter"|"WebRTCEncryptionEnabled"|"WebSecurityEnabled"; export type Setting = "PrivateClickMeasurementDebugModeEnabled"|"AuthorAndUserStylesEnabled"|"ICECandidateFilteringEnabled"|"ITPDebugModeEnabled"|"ImagesEnabled"|"MediaCaptureRequiresSecureConnection"|"MockCaptureDevicesEnabled"|"NeedsSiteSpecificQuirks"|"ScriptEnabled"|"ShowDebugBorders"|"ShowRepaintCounter"|"WebRTCEncryptionEnabled"|"WebSecurityEnabled";
/** /**
* Resource type as it was perceived by the rendering engine. * Resource type as it was perceived by the rendering engine.
*/ */

3
test/page-event-crash.spec.ts
View file

@ -16,6 +16,7 @@
*/ */
import { it, expect, describe } from './fixtures'; import { it, expect, describe } from './fixtures';
import * as os from 'os';
function crash(page, toImpl, browserName) { function crash(page, toImpl, browserName) {
if (browserName === 'chromium') if (browserName === 'chromium')
@ -29,6 +30,8 @@ function crash(page, toImpl, browserName) {
describe('', (suite, { browserName, platform, wire }) => { describe('', (suite, { browserName, platform, wire }) => {
suite.skip(wire && browserName !== 'chromium'); suite.skip(wire && browserName !== 'chromium');
suite.flaky(browserName === 'firefox' && platform === 'win32'); suite.flaky(browserName === 'firefox' && platform === 'win32');
const isBigSur = platform === 'darwin' && parseInt(os.release(), 10) >= 20;
suite.fixme(isBigSur && browserName === 'webkit', 'Timing out after roll');
}, () => { }, () => {
it('should emit crash event when page crashes', async ({page, browserName, toImpl}) => { it('should emit crash event when page crashes', async ({page, browserName, toImpl}) => {
await page.setContent(`<div>This page should crash</div>`); await page.setContent(`<div>This page should crash</div>`);

8
test/request-continue.spec.ts
View file

@ -15,7 +15,8 @@
* limitations under the License. * limitations under the License.
*/ */
import { it, expect } from './fixtures'; import { it, expect, describe } from './fixtures';
import * as os from 'os';
it('should work', async ({page, server}) => { it('should work', async ({page, server}) => {
await page.route('**/*', route => route.continue()); await page.route('**/*', route => route.continue());
@ -55,6 +56,10 @@ it('should amend method on main request', async ({page, server}) => {
expect((await request).method).toBe('POST'); expect((await request).method).toBe('POST');
}); });
describe('', (suite, { browserName, platform, wire }) => {
const isBigSur = platform === 'darwin' && parseInt(os.release(), 10) >= 20;
suite.flaky(isBigSur && browserName === 'webkit', 'Flaky after roll');
}, () => {
it('should amend post data', async ({page, server}) => { it('should amend post data', async ({page, server}) => {
await page.goto(server.EMPTY_PAGE); await page.goto(server.EMPTY_PAGE);
await page.route('**/*', route => { await page.route('**/*', route => {
@ -122,3 +127,4 @@ it('should amend binary post data', async ({page, server}) => {
for (let i = 0; i < arr.length; ++i) for (let i = 0; i < arr.length; ++i)
expect(arr[i]).toBe(buffer[i]); expect(arr[i]).toBe(buffer[i]);
}); });
});

6
test/resource-timing.spec.ts
View file

@ -16,8 +16,12 @@
*/ */
import { expect, it } from './fixtures'; import { expect, it } from './fixtures';
import * as os from 'os';
it('should work', async ({ page, server }) => { it('should work', (test, { browserName, platform }) => {
const isBigSur = platform === 'darwin' && parseInt(os.release(), 10) >= 20;
test.fail(isBigSur && browserName === 'webkit', 'Resource timing is -1 on BigSur');
}, async ({ page, server }) => {
const [request] = await Promise.all([ const [request] = await Promise.all([
page.waitForEvent('requestfinished'), page.waitForEvent('requestfinished'),
page.goto(server.EMPTY_PAGE) page.goto(server.EMPTY_PAGE)