Filip/playwright
1
0
Fork 0
Code Issues Pull requests Actions Packages Projects Releases Wiki Activity

fix(installer): release lock if things go south (#5125)

Browse source 
References #5110
This commit is contained in:
Andrey Lushnikov 2021-01-22 17:27:33 -08:00 committed by GitHub
parent b7fd0cd14c
commit 74816e4000
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
1 changed files with 7 additions and 4 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

11
src/install/installer.ts
View file

@ -57,10 +57,13 @@ export async function installBrowsersWithProgressBar(packagePath: string, browse
});
const linksDir = path.join(browsersPath, '.links');
await fsMkdirAsync(linksDir, { recursive: true });
await fsWriteFileAsync(path.join(linksDir, sha1(packagePath)), packagePath);
await validateCache(packagePath, browsersPath, linksDir, browserNames);
await releaseLock();
try {
await fsMkdirAsync(linksDir, { recursive: true });
await fsWriteFileAsync(path.join(linksDir, sha1(packagePath)), packagePath);
await validateCache(packagePath, browsersPath, linksDir, browserNames);
} finally {
await releaseLock();
}
}
async function validateCache(packagePath: string, browsersPath: string, linksDir: string, browserNames?: browserPaths.BrowserName[]) {