From 75776dbc3e15bf13db235de666e637340c768bf7 Mon Sep 17 00:00:00 2001 From: Pavel Feldman Date: Tue, 26 Mar 2024 15:49:44 -0700 Subject: [PATCH] cherry-pick(#30135): chore: do not exit UI mode upon page reload --- .../playwright-core/src/server/trace/viewer/traceViewer.ts | 1 - packages/playwright/src/runner/testServer.ts | 3 ++- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/packages/playwright-core/src/server/trace/viewer/traceViewer.ts b/packages/playwright-core/src/server/trace/viewer/traceViewer.ts index f3ed7fa06c..8bf26d3db1 100644 --- a/packages/playwright-core/src/server/trace/viewer/traceViewer.ts +++ b/packages/playwright-core/src/server/trace/viewer/traceViewer.ts @@ -229,7 +229,6 @@ class StdinServer implements Transport { } onclose() { - gracefullyProcessExitDoNotHang(0); } sendEvent?: (method: string, params: any) => void; diff --git a/packages/playwright/src/runner/testServer.ts b/packages/playwright/src/runner/testServer.ts index 3156530698..f563e8beb6 100644 --- a/packages/playwright/src/runner/testServer.ts +++ b/packages/playwright/src/runner/testServer.ts @@ -98,7 +98,7 @@ class TestServerDispatcher implements TestServerInterface { this._configFile = configFile; this.transport = { dispatch: (method, params) => (this as any)[method](params), - onclose: () => gracefullyProcessExitDoNotHang(0), + onclose: () => {}, }; this._globalWatcher = new Watcher('deep', () => this._dispatchEvent('listChanged', {})); this._testWatcher = new Watcher('flat', events => { @@ -392,6 +392,7 @@ async function innerRunTestServer(configFile: string | undefined, options: { hos const testServer = new TestServer(configFile); const cancelPromise = new ManualPromise(); const sigintWatcher = new SigIntWatcher(); + process.stdin.on('close', () => gracefullyProcessExitDoNotHang(0)); void sigintWatcher.promise().then(() => cancelPromise.resolve()); try { const server = await testServer.start(options);