Filip/playwright
1
0
Fork 0
Code Issues Pull requests Actions Packages Projects Releases Wiki Activity

chery-pick(#17918): docs: AriaRole is enum (#17921)

Browse source 
This PR cherry-picks the following commits:

- 946994ca92

Co-authored-by: github-actions <41898282+github-actions[bot]@users.noreply.github.com>
This commit is contained in:
Playwright Service 2022-10-07 23:03:18 -07:00 committed by GitHub
parent af0d2936ac
commit 75aaaac3eb
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
1 changed files with 2 additions and 2 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

4
docs/src/release-notes-java.md
View file

@ -21,7 +21,7 @@ page.getByLabel("User Name").fill("John");
page.getByLabel("Password").fill("secret-password"); page.getByLabel("Password").fill("secret-password");
page.getByRole("button", new Page.GetByRoleOptions().setName("Sign in")).click(); page.getByRole(AriaRole.BUTTON, new Page.GetByRoleOptions().setName("Sign in")).click();
assertThat(page.getByText("Welcome, John!")).isVisible(); assertThat(page.getByText("Welcome, John!")).isVisible();
``` ```
@ -37,7 +37,7 @@ All the same methods are also available on [Locator], [FrameLocator] and [Frame]
- [`method: LocatorAssertions.toHaveAttribute`] with an empty value does not match missing attribute anymore. For example, the following snippet will succeed when `button` **does not** have a `disabled` attribute. - [`method: LocatorAssertions.toHaveAttribute`] with an empty value does not match missing attribute anymore. For example, the following snippet will succeed when `button` **does not** have a `disabled` attribute.
```js ```js
assertThat(page.getByRole("button")).hasAttribute("disabled", ""); assertThat(page.getByRole(AriaRole.BUTTON)).hasAttribute("disabled", "");
``` ```
### Browser Versions ### Browser Versions