Filip/playwright
1
0
Fork 0
Code Issues Pull requests Actions Packages Projects Releases Wiki Activity

fix(trace): do not access null content window (#21166)

Browse source
This commit is contained in:
Pavel Feldman 2023-02-23 11:57:15 -08:00 committed by GitHub
parent b735e136fe
commit 7626267ec5
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
1 changed files with 2 additions and 4 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

6
packages/trace-viewer/src/ui/snapshotTab.tsx
View file

@ -208,10 +208,8 @@ export const InspectModeController: React.FunctionComponent<{
setHighlightedLocator: (locator: string) => void, setHighlightedLocator: (locator: string) => void,
}> = ({ iframe, isInspecting, sdkLanguage, testIdAttributeName, highlightedLocator, setHighlightedLocator }) => { }> = ({ iframe, isInspecting, sdkLanguage, testIdAttributeName, highlightedLocator, setHighlightedLocator }) => {
React.useEffect(() => { React.useEffect(() => {
if (!iframe) const win = iframe?.contentWindow as any;
return; if (!win || !isInspecting && !highlightedLocator && !win._recorder)
const win = iframe.contentWindow as any;
if (!isInspecting && !highlightedLocator && !win._recorder)
return; return;
let recorder: Recorder | undefined = win._recorder; let recorder: Recorder | undefined = win._recorder;
if (!recorder) { if (!recorder) {