From 762dc780cc2f2ed4177acdf2b496282095e520b4 Mon Sep 17 00:00:00 2001
From: Max Schmitt <max@schmitt.mx>
Date: Mon, 4 Nov 2024 11:45:04 +0100
Subject: [PATCH] review feedback

---
 packages/playwright-core/src/server/bidi/bidiChromium.ts | 2 +-
 packages/playwright-core/src/server/chromium/chromium.ts | 2 +-
 tests/library/download.spec.ts                           | 2 +-
 tests/library/emulation-focus.spec.ts                    | 3 ++-
 tests/library/permissions.spec.ts                        | 2 +-
 tests/library/screenshot.spec.ts                         | 3 ++-
 6 files changed, 8 insertions(+), 6 deletions(-)

diff --git a/packages/playwright-core/src/server/bidi/bidiChromium.ts b/packages/playwright-core/src/server/bidi/bidiChromium.ts
index 62d76cda8f..9572ac71ed 100644
--- a/packages/playwright-core/src/server/bidi/bidiChromium.ts
+++ b/packages/playwright-core/src/server/bidi/bidiChromium.ts
@@ -112,7 +112,7 @@ export class BidiChromium extends BrowserType {
     if (options.devtools)
       chromeArguments.push('--auto-open-devtools-for-tabs');
     if (options.headless) {
-      chromeArguments.push('--headless=new');
+      chromeArguments.push('--headless');
 
       chromeArguments.push(
           '--hide-scrollbars',
diff --git a/packages/playwright-core/src/server/chromium/chromium.ts b/packages/playwright-core/src/server/chromium/chromium.ts
index 597563efea..2bae0eaf5a 100644
--- a/packages/playwright-core/src/server/chromium/chromium.ts
+++ b/packages/playwright-core/src/server/chromium/chromium.ts
@@ -309,7 +309,7 @@ export class Chromium extends BrowserType {
     if (options.devtools)
       chromeArguments.push('--auto-open-devtools-for-tabs');
     if (options.headless) {
-      chromeArguments.push('--headless=new');
+      chromeArguments.push('--headless');
 
       chromeArguments.push(
           '--hide-scrollbars',
diff --git a/tests/library/download.spec.ts b/tests/library/download.spec.ts
index 791aa5f6d5..74b008c51b 100644
--- a/tests/library/download.spec.ts
+++ b/tests/library/download.spec.ts
@@ -637,7 +637,7 @@ it('should be able to download a inline PDF file via response interception', asy
 });
 
 it('should be able to download a inline PDF file via navigation', async ({ browser, server, asset, browserName, channel }) => {
-  it.skip(browserName === 'chromium' && channel !== 'chromium-headless-shell');
+  it.skip(browserName === 'chromium' && channel !== 'chromium-headless-shell', 'We expect PDF Viewer to open up in Chromium');
   const page = await browser.newPage();
   await page.goto(server.EMPTY_PAGE);
   await page.setContent(`
diff --git a/tests/library/emulation-focus.spec.ts b/tests/library/emulation-focus.spec.ts
index 5bbef6b164..e9a0480a67 100644
--- a/tests/library/emulation-focus.spec.ts
+++ b/tests/library/emulation-focus.spec.ts
@@ -104,7 +104,8 @@ it('should change document.activeElement', async ({ page, server }) => {
 it('should not affect screenshots', async ({ page, server, browserName, headless, isWindows, channel }) => {
   it.skip(browserName === 'webkit' && isWindows && !headless, 'WebKit/Windows/headed has a larger minimal viewport. See https://github.com/microsoft/playwright/issues/22616');
   it.skip(browserName === 'firefox' && !headless, 'Firefox headed produces a different image');
-  it.fixme(browserName === 'chromium' && channel !== 'chromium-headless-shell', 'https://github.com/microsoft/playwright/issues/33330');
+  // TODO: We want to see test results
+  // it.fixme(browserName === 'chromium' && channel !== 'chromium-headless-shell', 'https://github.com/microsoft/playwright/issues/33330');
 
   const page2 = await page.context().newPage();
   await Promise.all([
diff --git a/tests/library/permissions.spec.ts b/tests/library/permissions.spec.ts
index 7da179b2e6..451149878c 100644
--- a/tests/library/permissions.spec.ts
+++ b/tests/library/permissions.spec.ts
@@ -156,7 +156,7 @@ it('should support clipboard read', async ({ page, context, server, browserName,
   if (browserName !== 'webkit')
     expect(await getPermission(page, 'clipboard-read')).toBe('prompt');
 
-  if (browserName === 'chromium' && channel !== 'chromium-headless-shell') {
+  if (browserName === 'chromium' && channel === 'chromium-headless-shell') {
     // Chromium shows a dialog and does not resolve the promise.
     const error = await page.evaluate(() => navigator.clipboard.readText()).catch(e => e);
     expect(error.toString()).toContain('denied');
diff --git a/tests/library/screenshot.spec.ts b/tests/library/screenshot.spec.ts
index 2f8e516963..3e0b1921fc 100644
--- a/tests/library/screenshot.spec.ts
+++ b/tests/library/screenshot.spec.ts
@@ -23,7 +23,8 @@ browserTest.describe('page screenshot', () => {
   browserTest.skip(({ browserName, headless }) => browserName === 'firefox' && !headless, 'Firefox headed produces a different image.');
 
   browserTest('should run in parallel in multiple pages', async ({ server, contextFactory, browserName, channel }) => {
-    browserTest.fixme(browserName === 'chromium' && channel !== 'chromium-headless-shell', 'https://github.com/microsoft/playwright/issues/33330');
+    // TODO: We want to see test results
+    // browserTest.fixme(browserName === 'chromium' && channel !== 'chromium-headless-shell', 'https://github.com/microsoft/playwright/issues/33330');
     const context = await contextFactory();
     const N = 5;
     const pages = await Promise.all(Array(N).fill(0).map(async () => {