Filip/playwright
1
0
Fork 0
Code Issues Pull requests Actions Packages Projects Releases Wiki Activity

chore: follow-up to handling docker corner cases (#10981)

Browse source
This commit is contained in:
Andrey Lushnikov 2021-12-16 15:29:20 -08:00 committed by GitHub
parent 70ed020c87
commit 773ebe04c6
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
1 changed files with 1 additions and 18 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

19
packages/playwright-core/src/grid/dockerGridFactory.ts
View file

@ -64,26 +64,9 @@ async function launchDockerGridAgent(agentId: string, gridURL: string): Promise<
const pwImage = images.find(image => image.RepoTags?.includes(imageName)); const pwImage = images.find(image => image.RepoTags?.includes(imageName));
if (!pwImage) { if (!pwImage) {
const pwImages = images
.map(image => image.RepoTags?.find(tag => tag.startsWith('mcr.microsoft.com/playwright:')))
.filter((tag): tag is string => typeof tag === 'string');
const usage = pwImages.length > 0 ? [
``,
`Available images:`,
...pwImages.map(image => `- ${image}`),
``,
`Use available images via PWTEST_IMAGE_NAME environment variable:`,
` PWTEST_IMAGE_NAME=${pwImages[0]} playwright test`,
``
] : [];
const pullPrefix = pwImages.length > 0 ? 'Alternatively, please' : 'Please';
throw new Error(`\n` + utils.wrapInASCIIBox([ throw new Error(`\n` + utils.wrapInASCIIBox([
`Failed to find ${imageName} docker image.`, `Failed to find ${imageName} docker image.`,
...usage, `Please pull docker image with the following command:`,
`${pullPrefix} pull docker image with the following command:`,
``, ``,
` npx playwright install docker-image`, ` npx playwright install docker-image`,
``, ``,