From 7746cb52a7d2bff866553ac484ade92d36a6e4a9 Mon Sep 17 00:00:00 2001 From: Yury Semikhatsky Date: Wed, 17 Nov 2021 11:42:06 -0800 Subject: [PATCH] fix: do not send Fetch.continueRequest twice for auth requests (#10382) --- .../src/server/chromium/crNetworkManager.ts | 7 +------ 1 file changed, 1 insertion(+), 6 deletions(-) diff --git a/packages/playwright-core/src/server/chromium/crNetworkManager.ts b/packages/playwright-core/src/server/chromium/crNetworkManager.ts index f4668dae54..fd5f1e3a8b 100644 --- a/packages/playwright-core/src/server/chromium/crNetworkManager.ts +++ b/packages/playwright-core/src/server/chromium/crNetworkManager.ts @@ -161,11 +161,6 @@ export class CRNetworkManager { this._responseExtraInfoTracker.requestPaused(request.request, event); } - if (!this._userRequestInterceptionEnabled && this._protocolRequestInterceptionEnabled) { - this._client._sendMayFail('Fetch.continueRequest', { - requestId: event.requestId - }); - } if (!event.networkId) { // Fetch without networkId means that request was not recongnized by inspector, and // it will never receive Network.requestWillBeSent. Most likely, this is an internal request @@ -249,7 +244,7 @@ export class CRNetworkManager { let route = null; if (requestPausedEvent) { // We do not support intercepting redirects. - if (redirectedFrom) + if (redirectedFrom || (!this._userRequestInterceptionEnabled && this._protocolRequestInterceptionEnabled)) this._client._sendMayFail('Fetch.continueRequest', { requestId: requestPausedEvent.requestId }); else route = new RouteImpl(this._client, requestPausedEvent.requestId);