chore(bidi): mark test expected to timeout as fixme (#34176)

This commit is contained in:
Yury Semikhatsky 2024-12-31 13:18:25 -08:00 committed by GitHub
parent b2cbe7f2ec
commit 7769010e6e
No known key found for this signature in database
GPG key ID: B5690EEEBB952194
2 changed files with 11 additions and 6 deletions

View file

@ -45,15 +45,21 @@ class CsvReporter implements Reporter {
for (const project of this._suite.suites) { for (const project of this._suite.suites) {
for (const file of project.suites) { for (const file of project.suites) {
for (const test of file.allTests()) { for (const test of file.allTests()) {
if (test.ok()) // Report fixme tests as failing.
const fixme = test.annotations.find(a => a.type === 'fixme');
if (test.ok() && !fixme)
continue; continue;
const row = []; const row = [];
row.push(csvEscape(`${file.title} :: ${test.title}`)); row.push(csvEscape(`${file.title} :: ${test.title}`));
row.push(test.expectedStatus); row.push(test.expectedStatus);
row.push(test.outcome()); row.push(test.outcome());
const result = test.results.find(r => r.error); if (fixme) {
const errorMessage = stripAnsi(result?.error?.message.replace(/\s+/g, ' ').trim().substring(0, 1024)); row.push('fixme' + (fixme.description ? `: ${fixme.description}` : ''));
row.push(csvEscape(errorMessage ?? '')); } else {
const result = test.results.find(r => r.error);
const errorMessage = stripAnsi(result?.error?.message.replace(/\s+/g, ' ').trim().substring(0, 1024));
row.push(csvEscape(errorMessage ?? ''));
}
rows.push(row); rows.push(row);
} }
} }

View file

@ -188,8 +188,7 @@ const test = baseTest.extend<BrowserTestTestFixtures, BrowserTestWorkerFixtures>
}, { scope: 'worker' }], }, { scope: 'worker' }],
autoSkipBidiTest: [async ({ bidiTestSkipPredicate }, run) => { autoSkipBidiTest: [async ({ bidiTestSkipPredicate }, run) => {
if (bidiTestSkipPredicate(test.info())) test.fixme(bidiTestSkipPredicate(test.info()), 'marked as timeout in bidi expectations');
test.skip(true);
await run(); await run();
}, { auto: true, scope: 'test' }], }, { auto: true, scope: 'test' }],
}); });