From 7910f8a165cc4c893c6b4c3e7cbdf979c2701efa Mon Sep 17 00:00:00 2001 From: Pavel Feldman Date: Tue, 18 Oct 2022 20:00:17 -0400 Subject: [PATCH] Revert "chore(ct): type checking" (#18165) Reverts microsoft/playwright#17931 type checking fails on the bots --- tests/components/ct-react-vite/package.json | 3 +-- tests/components/ct-react-vite/tsconfig.json | 2 +- tests/components/ct-react/package.json | 3 +-- tests/components/ct-react/src/tests.spec.tsx | 8 +++---- tests/components/ct-solid/package.json | 3 +-- tests/components/ct-solid/tsconfig.json | 3 +-- tests/components/ct-svelte-vite/package.json | 2 +- .../src/components/Counter.svelte | 2 +- tests/components/ct-svelte-vite/src/main.ts | 2 +- .../components/ct-svelte-vite/src/svelte.d.ts | 4 ---- .../ct-svelte-vite/src/tests.spec.ts | 6 ++--- tests/components/ct-svelte-vite/tsconfig.json | 6 ++--- tests/components/ct-svelte/package.json | 7 +++--- .../ct-svelte/src/components/Counter.svelte | 2 +- tests/components/ct-svelte/src/tests.spec.ts | 6 ++--- tests/components/ct-svelte/tsconfig.json | 11 --------- tests/components/ct-vue-cli/.gitignore | 1 - tests/components/ct-vue-cli/jsconfig.json | 20 ++++++++++++++++ tests/components/ct-vue-cli/package.json | 4 +--- .../ct-vue-cli/src/components/Button.vue | 2 +- .../ct-vue-cli/src/components/Counter.vue | 4 ++-- .../ct-vue-cli/src/notation-jsx.spec.tsx | 13 ++++------- .../ct-vue-cli/src/notation-vue.spec.ts | 7 +++--- tests/components/ct-vue-cli/tsconfig.app.json | 12 ---------- .../ct-vue-cli/tsconfig.config.json | 8 ------- tests/components/ct-vue-cli/tsconfig.json | 14 ----------- .../components/ct-vue-cli/tsconfig.test.json | 10 -------- tests/components/ct-vue-cli/vue.d.ts | 4 ---- tests/components/ct-vue-vite/.gitignore | 1 - tests/components/ct-vue-vite/env.d.ts | 1 - tests/components/ct-vue-vite/package.json | 7 ++---- .../ct-vue-vite/src/components/Button.vue | 9 ++++++-- .../ct-vue-vite/src/components/Counter.vue | 12 ++++++---- .../ct-vue-vite/src/components/NamedSlots.vue | 1 + .../ct-vue-vite/src/notation-jsx.spec.tsx | 21 ++++++++--------- .../ct-vue-vite/src/notation-vue.spec.js | 4 ++-- .../ct-vue-vite/src/notation-vue.spec.ts | 13 +++++++---- .../components/ct-vue-vite/tsconfig.app.json | 12 ---------- .../ct-vue-vite/tsconfig.config.json | 8 ------- tests/components/ct-vue-vite/tsconfig.json | 14 ----------- .../components/ct-vue-vite/tsconfig.test.json | 9 -------- tests/components/ct-vue-vite/vue.d.ts | 1 + tests/components/ct-vue2-cli/.gitignore | 2 +- tests/components/ct-vue2-cli/package.json | 4 +--- .../ct-vue2-cli/src/components/Button.vue | 2 +- .../ct-vue2-cli/src/components/Counter.vue | 2 +- .../ct-vue2-cli/src/components/HelloWorld.vue | 2 +- .../ct-vue2-cli/src/notation-jsx.spec.tsx | 23 ++++++++----------- .../ct-vue2-cli/src/notation-vue.spec.ts | 10 ++++---- .../components/ct-vue2-cli/src/shims-vue.d.ts | 4 ---- tests/components/ct-vue2-cli/src/vue.d.ts | 1 + .../components/ct-vue2-cli/tsconfig.app.json | 12 ---------- .../ct-vue2-cli/tsconfig.config.json | 8 ------- tests/components/ct-vue2-cli/tsconfig.json | 14 ----------- .../components/ct-vue2-cli/tsconfig.test.json | 9 -------- tests/components/test-all.spec.js | 6 +---- 56 files changed, 117 insertions(+), 264 deletions(-) delete mode 100644 tests/components/ct-svelte-vite/src/svelte.d.ts delete mode 100644 tests/components/ct-svelte/tsconfig.json create mode 100644 tests/components/ct-vue-cli/jsconfig.json delete mode 100644 tests/components/ct-vue-cli/tsconfig.app.json delete mode 100644 tests/components/ct-vue-cli/tsconfig.config.json delete mode 100644 tests/components/ct-vue-cli/tsconfig.json delete mode 100644 tests/components/ct-vue-cli/tsconfig.test.json delete mode 100644 tests/components/ct-vue-cli/vue.d.ts delete mode 100644 tests/components/ct-vue-vite/env.d.ts delete mode 100644 tests/components/ct-vue-vite/tsconfig.app.json delete mode 100644 tests/components/ct-vue-vite/tsconfig.config.json delete mode 100644 tests/components/ct-vue-vite/tsconfig.json delete mode 100644 tests/components/ct-vue-vite/tsconfig.test.json create mode 100644 tests/components/ct-vue-vite/vue.d.ts delete mode 100644 tests/components/ct-vue2-cli/src/shims-vue.d.ts create mode 100644 tests/components/ct-vue2-cli/src/vue.d.ts delete mode 100644 tests/components/ct-vue2-cli/tsconfig.app.json delete mode 100644 tests/components/ct-vue2-cli/tsconfig.config.json delete mode 100644 tests/components/ct-vue2-cli/tsconfig.json delete mode 100644 tests/components/ct-vue2-cli/tsconfig.test.json diff --git a/tests/components/ct-react-vite/package.json b/tests/components/ct-react-vite/package.json index 4126048dbe..a2d9e02547 100644 --- a/tests/components/ct-react-vite/package.json +++ b/tests/components/ct-react-vite/package.json @@ -5,8 +5,7 @@ "scripts": { "dev": "vite", "build": "tsc && vite build", - "preview": "vite preview", - "typecheck": "tsc --noEmit" + "preview": "vite preview" }, "dependencies": { "react": "^17.0.2", diff --git a/tests/components/ct-react-vite/tsconfig.json b/tests/components/ct-react-vite/tsconfig.json index 3d0a51a86e..c8bdc64082 100644 --- a/tests/components/ct-react-vite/tsconfig.json +++ b/tests/components/ct-react-vite/tsconfig.json @@ -4,7 +4,7 @@ "useDefineForClassFields": true, "lib": ["DOM", "DOM.Iterable", "ESNext"], "allowJs": false, - "skipLibCheck": true, + "skipLibCheck": false, "esModuleInterop": false, "allowSyntheticDefaultImports": true, "strict": true, diff --git a/tests/components/ct-react/package.json b/tests/components/ct-react/package.json index d7012b6af0..3d6fb76e13 100644 --- a/tests/components/ct-react/package.json +++ b/tests/components/ct-react/package.json @@ -18,8 +18,7 @@ "scripts": { "start": "react-scripts start", "build": "react-scripts build", - "eject": "react-scripts eject", - "typecheck": "tsc --noEmit" + "eject": "react-scripts eject" }, "eslintConfig": { "extends": [ diff --git a/tests/components/ct-react/src/tests.spec.tsx b/tests/components/ct-react/src/tests.spec.tsx index 3f2eede57b..e53243871a 100644 --- a/tests/components/ct-react/src/tests.spec.tsx +++ b/tests/components/ct-react/src/tests.spec.tsx @@ -1,5 +1,5 @@ -import { test, expect } from '@playwright/experimental-ct-react'; -const { serverFixtures } = require('../../../../tests/config/serverFixtures'); +import { test, expect } from '@playwright/experimental-ct-react' +import { serverFixtures } from '../../../../tests/config/serverFixtures'; import Fetch from './components/Fetch'; import DelayedData from './components/DelayedData'; import Button from './components/Button'; @@ -143,7 +143,7 @@ test('get textContent of the empty fragment', async ({ mount }) => { const testWithServer = test.extend(serverFixtures); testWithServer('components routing should go through context', async ({ mount, context, server }) => { - server.setRoute('/hello', (req: any, res: any) => { + server.setRoute('/hello', (req, res) => { res.write('served via server'); res.end(); }); @@ -158,7 +158,7 @@ testWithServer('components routing should go through context', async ({ mount, c }); const whoServedTheRequest = Promise.race([ - server.waitForRequest('/hello').then((req: any) => `served via server: ${req.method} ${req.url}`), + server.waitForRequest('/hello').then((req) => `served via server: ${req.method} ${req.url}`), routedViaContext.then(req => `served via context: ${req}`), ]); diff --git a/tests/components/ct-solid/package.json b/tests/components/ct-solid/package.json index cdcfbc7808..8176ee5f4b 100644 --- a/tests/components/ct-solid/package.json +++ b/tests/components/ct-solid/package.json @@ -6,8 +6,7 @@ "start": "vite", "dev": "vite", "build": "vite build", - "serve": "vite preview", - "typecheck": "tsc --noEmit" + "serve": "vite preview" }, "license": "MIT", "devDependencies": { diff --git a/tests/components/ct-solid/tsconfig.json b/tests/components/ct-solid/tsconfig.json index 9bb6e17684..249b2732a7 100644 --- a/tests/components/ct-solid/tsconfig.json +++ b/tests/components/ct-solid/tsconfig.json @@ -10,7 +10,6 @@ "jsxImportSource": "solid-js", "types": ["vite/client"], "noEmit": true, - "isolatedModules": true, - "skipLibCheck": true + "isolatedModules": true } } diff --git a/tests/components/ct-svelte-vite/package.json b/tests/components/ct-svelte-vite/package.json index 457a0fa989..1c3b967d94 100644 --- a/tests/components/ct-svelte-vite/package.json +++ b/tests/components/ct-svelte-vite/package.json @@ -7,7 +7,7 @@ "dev": "vite", "build": "vite build", "preview": "vite preview", - "typecheck": "svelte-check --tsconfig ./tsconfig.json" + "check": "svelte-check --tsconfig ./tsconfig.json" }, "devDependencies": { "@sveltejs/vite-plugin-svelte": "^1.0.1", diff --git a/tests/components/ct-svelte-vite/src/components/Counter.svelte b/tests/components/ct-svelte-vite/src/components/Counter.svelte index baf642fdcf..2b8a064b46 100644 --- a/tests/components/ct-svelte-vite/src/components/Counter.svelte +++ b/tests/components/ct-svelte-vite/src/components/Counter.svelte @@ -1,7 +1,7 @@ diff --git a/tests/components/ct-svelte-vite/src/main.ts b/tests/components/ct-svelte-vite/src/main.ts index 4e7ad898e9..ca8aaba9be 100644 --- a/tests/components/ct-svelte-vite/src/main.ts +++ b/tests/components/ct-svelte-vite/src/main.ts @@ -2,7 +2,7 @@ import App from './App.svelte'; import './assets/index.css'; const app = new App({ - target: document.getElementById('app')! + target: document.getElementById('app') }); export default app; diff --git a/tests/components/ct-svelte-vite/src/svelte.d.ts b/tests/components/ct-svelte-vite/src/svelte.d.ts deleted file mode 100644 index 0fdb59facc..0000000000 --- a/tests/components/ct-svelte-vite/src/svelte.d.ts +++ /dev/null @@ -1,4 +0,0 @@ -declare module '*.svelte' { - const value: any; // Add better type definitions here if desired. - export default value; -} diff --git a/tests/components/ct-svelte-vite/src/tests.spec.ts b/tests/components/ct-svelte-vite/src/tests.spec.ts index 6ebcc4ee03..e7cc19f220 100644 --- a/tests/components/ct-svelte-vite/src/tests.spec.ts +++ b/tests/components/ct-svelte-vite/src/tests.spec.ts @@ -65,13 +65,13 @@ test('renderer updates event listeners without remounting', async ({ mount }) => }) test('emit an submit event when the button is clicked', async ({ mount }) => { - const messages: string[] = [] + const messages = [] const component = await mount(Button, { props: { title: 'Submit' }, on: { - submit: (data: string) => messages.push(data) + submit: data => messages.push(data) } }) await component.click() @@ -101,7 +101,7 @@ test('render a component with a named slot', async ({ mount }) => { }) test('run hooks', async ({ page, mount }) => { - const messages: string[] = [] + const messages = [] page.on('console', m => messages.push(m.text())) await mount(Button, { props: { diff --git a/tests/components/ct-svelte-vite/tsconfig.json b/tests/components/ct-svelte-vite/tsconfig.json index 898993ae64..4d6c04cf0a 100644 --- a/tests/components/ct-svelte-vite/tsconfig.json +++ b/tests/components/ct-svelte-vite/tsconfig.json @@ -13,10 +13,8 @@ * of JS in `.svelte` files. */ "allowJs": true, - "checkJs": true, - "skipLibCheck": true, - "strict": true + "checkJs": true }, - "include": ["src/**/*.d.ts", "src/**/*.ts", "src/**/*.js", "src/**/*.svelte", "src/**/*.spec.*/*"], + "include": ["src/**/*.d.ts", "src/**/*.ts", "src/**/*.js", "src/**/*.svelte"], "references": [{ "path": "./tsconfig.node.json" }] } diff --git a/tests/components/ct-svelte/package.json b/tests/components/ct-svelte/package.json index 5a491ded3b..ef1144a34e 100644 --- a/tests/components/ct-svelte/package.json +++ b/tests/components/ct-svelte/package.json @@ -5,8 +5,7 @@ "scripts": { "build": "rollup -c", "dev": "rollup -c -w", - "start": "sirv public --no-clear", - "typecheck": "tsc --noEmit" + "start": "sirv public --no-clear" }, "devDependencies": { "@rollup/plugin-commonjs": "^17.0.0", @@ -16,13 +15,13 @@ "rollup-plugin-livereload": "^2.0.0", "rollup-plugin-svelte": "^7.0.0", "rollup-plugin-terser": "^7.0.0", - "sirv-cli": "^2.0.0" + "svelte": "^3.0.0" }, "@standaloneDevDependencies": { "@playwright/experimental-ct-svelte": "^1.22.2", "@playwright/test": "^1.22.2" }, "dependencies": { - "svelte": "^3.0.0" + "sirv-cli": "^2.0.0" } } diff --git a/tests/components/ct-svelte/src/components/Counter.svelte b/tests/components/ct-svelte/src/components/Counter.svelte index e850f3a35a..2b8a064b46 100644 --- a/tests/components/ct-svelte/src/components/Counter.svelte +++ b/tests/components/ct-svelte/src/components/Counter.svelte @@ -1,4 +1,4 @@ - - - - diff --git a/tests/components/ct-vue-vite/src/components/NamedSlots.vue b/tests/components/ct-vue-vite/src/components/NamedSlots.vue index 582608df32..b7e95f4487 100644 --- a/tests/components/ct-vue-vite/src/components/NamedSlots.vue +++ b/tests/components/ct-vue-vite/src/components/NamedSlots.vue @@ -3,6 +3,7 @@
+
diff --git a/tests/components/ct-vue-vite/src/notation-jsx.spec.tsx b/tests/components/ct-vue-vite/src/notation-jsx.spec.tsx index 63569e5849..86501606bb 100644 --- a/tests/components/ct-vue-vite/src/notation-jsx.spec.tsx +++ b/tests/components/ct-vue-vite/src/notation-jsx.spec.tsx @@ -33,9 +33,8 @@ test('renderer updates props without remounting', async ({ mount }) => { test('renderer updates event listeners without remounting', async ({ mount }) => { const component = await mount() - - const messages: string[] = [] - await component.update( { + const messages = [] + await component.update( { messages.push(count) }} />) await component.click(); @@ -58,13 +57,10 @@ test('renderer updates slots without remounting', async ({ mount }) => { }) test('emit an submit event when the button is clicked', async ({ mount }) => { - const messages: string[] = [] - const component = await mount() await component.click() expect(messages).toEqual(['hello']) }) @@ -112,7 +108,7 @@ test('emit a event when a slot is clicked', async ({ mount }) => { }) test('run hooks', async ({ page, mount }) => { - const messages: string[] = [] + const messages = [] page.on('console', m => messages.push(m.text())) await mount( -