From 7abbbd0c84a196052c1342cd1de9287c2628a1d5 Mon Sep 17 00:00:00 2001 From: Josh Soref <2119212+jsoref@users.noreply.github.com> Date: Mon, 22 Jul 2024 09:45:22 -0400 Subject: [PATCH] docs: spelling (#31779) Fixes misspellings identified by the [check-spelling action](https://github.com/marketplace/actions/check-spelling). The misspellings have been reported at https://github.com/jsoref/playwright/actions/runs/10015023629#summary-27685777352 The action will report that the changes in this PR would make it happy: https://github.com/jsoref/playwright/actions/runs/10015023971#summary-27685778305 --- I understand that the commit messages will need to be reworded to match house style. For the time being, these are merely noting the changes they contain so that when I rebase or need to drop things, I can. -- I've already rebased once as someone fixed one of the items that my draft work was going to fix. --- ## Testing * The tests _mostly_ passed when I managed to trigger them, but there were a handful of things that I didn't quite understand * There are a large number of warnings relating to a bad interaction between any workflow that uses this local action https://github.com/microsoft/playwright/blob/b535139b3292885dccf9e27ba2753c6c8d337c16/.github/actions/run-test/action.yml#L74-L80 and the action it calls -- I've opened Azure/login#474 asking them to refactor their action so that it doesn't cause so much noise while running this repository's tests * I'm vaguely curious as to why this repository has a `branch` constraint for its `pull_request` events in its workflows -- that constraint gave me a number of additional headaches while trying to prepare this branch for this PR. --------- Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com> --- docs/src/accessibility-testing-java.md | 2 +- docs/src/accessibility-testing-js.md | 4 ++-- docs/src/api/class-frame.md | 2 +- docs/src/api/class-page.md | 6 +++--- docs/src/api/class-pageassertions.md | 2 +- docs/src/api/class-request.md | 2 +- docs/src/api/class-response.md | 4 ++-- docs/src/auth.md | 2 +- docs/src/best-practices-js.md | 4 ++-- docs/src/browsers.md | 2 +- docs/src/release-notes-csharp.md | 2 +- docs/src/release-notes-java.md | 2 +- docs/src/release-notes-js.md | 2 +- docs/src/release-notes-python.md | 2 +- ...rvice-workers-experimental-network-events-js.md | 2 +- docs/src/test-api/class-testoptions.md | 2 +- packages/playwright-core/types/types.d.ts | 14 +++++++------- packages/playwright/types/test.d.ts | 2 +- 18 files changed, 29 insertions(+), 29 deletions(-) diff --git a/docs/src/accessibility-testing-java.md b/docs/src/accessibility-testing-java.md index 15bb998481..9db8246bcb 100644 --- a/docs/src/accessibility-testing-java.md +++ b/docs/src/accessibility-testing-java.md @@ -135,7 +135,7 @@ If the element in question is used repeatedly in many pages, consider [using a t ### Disabling individual scan rules -If your application contains many different pre-existing violations of a specific rule, you can use [`AxeBuilder.disableRules()`](https://github.com/dequelabs/axe-core-maven-html/blob/develop/playwright/README.md#axebuilderdisablerulesliststring-rules) to temporarily disable individual rules until you're able to fix the issues. +If your application contains many different preexisting violations of a specific rule, you can use [`AxeBuilder.disableRules()`](https://github.com/dequelabs/axe-core-maven-html/blob/develop/playwright/README.md#axebuilderdisablerulesliststring-rules) to temporarily disable individual rules until you're able to fix the issues. You can find the rule IDs to pass to `disableRules()` in the `id` property of the violations you want to suppress. A [complete list of axe's rules](https://github.com/dequelabs/axe-core/blob/master/doc/rule-descriptions.md) can be found in `axe-core`'s documentation. diff --git a/docs/src/accessibility-testing-js.md b/docs/src/accessibility-testing-js.md index 96fe1f1865..65db5ae55c 100644 --- a/docs/src/accessibility-testing-js.md +++ b/docs/src/accessibility-testing-js.md @@ -147,7 +147,7 @@ If the element in question is used repeatedly in many pages, consider [using a t ### Disabling individual scan rules -If your application contains many different pre-existing violations of a specific rule, you can use [`AxeBuilder.disableRules()`](https://github.com/dequelabs/axe-core-npm/blob/develop/packages/playwright/README.md#axebuilderdisablerulesrules-stringarray) to temporarily disable individual rules until you're able to fix the issues. +If your application contains many different preexisting violations of a specific rule, you can use [`AxeBuilder.disableRules()`](https://github.com/dequelabs/axe-core-npm/blob/develop/packages/playwright/README.md#axebuilderdisablerulesrules-stringarray) to temporarily disable individual rules until you're able to fix the issues. You can find the rule IDs to pass to `disableRules()` in the `id` property of the violations you want to suppress. A [complete list of axe's rules](https://github.com/dequelabs/axe-core/blob/master/doc/rule-descriptions.md) can be found in `axe-core`'s documentation. @@ -167,7 +167,7 @@ test('should not have any accessibility violations outside of rules with known i ### Using snapshots to allow specific known issues -If you would like to allow for a more granular set of known issues, you can use [Snapshots](./test-snapshots.md) to verify that a set of pre-existing violations has not changed. This approach avoids the downsides of using `AxeBuilder.exclude()` at the cost of slightly more complexity and fragility. +If you would like to allow for a more granular set of known issues, you can use [Snapshots](./test-snapshots.md) to verify that a set of preexisting violations has not changed. This approach avoids the downsides of using `AxeBuilder.exclude()` at the cost of slightly more complexity and fragility. Do not use a snapshot of the entire `accessibilityScanResults.violations` array. It contains implementation details of the elements in question, such as a snippet of their rendered HTML; if you include these in your snapshots, it will make your tests prone to breaking every time one of the components in question changes for an unrelated reason: diff --git a/docs/src/api/class-frame.md b/docs/src/api/class-frame.md index 65ef1b714d..4da22fe989 100644 --- a/docs/src/api/class-frame.md +++ b/docs/src/api/class-frame.md @@ -154,7 +154,7 @@ Raw JavaScript content to be injected into frame. * since: v1.8 - `type` <[string]> -Script type. Use 'module' in order to load a Javascript ES6 module. See +Script type. Use 'module' in order to load a JavaScript ES6 module. See [script](https://developer.mozilla.org/en-US/docs/Web/HTML/Element/script) for more details. ## async method: Frame.addStyleTag diff --git a/docs/src/api/class-page.md b/docs/src/api/class-page.md index d419ba0b7b..b64173affe 100644 --- a/docs/src/api/class-page.md +++ b/docs/src/api/class-page.md @@ -688,7 +688,7 @@ Raw JavaScript content to be injected into frame. * since: v1.8 - `type` <[string]> -Script type. Use 'module' in order to load a Javascript ES6 module. See +Script type. Use 'module' in order to load a JavaScript ES6 module. See [script](https://developer.mozilla.org/en-US/docs/Web/HTML/Element/script) for more details. ## async method: Page.addStyleTag @@ -2312,7 +2312,7 @@ Attribute name to get the value for. - returns: <[null]|[Response]> Returns the main resource response. In case of multiple redirects, the navigation will resolve with the response of the -last redirect. If can not go back, returns `null`. +last redirect. If cannot go back, returns `null`. Navigate to the previous page in history. @@ -2330,7 +2330,7 @@ Navigate to the previous page in history. - returns: <[null]|[Response]> Returns the main resource response. In case of multiple redirects, the navigation will resolve with the response of the -last redirect. If can not go forward, returns `null`. +last redirect. If cannot go forward, returns `null`. Navigate to the next page in history. diff --git a/docs/src/api/class-pageassertions.md b/docs/src/api/class-pageassertions.md index 51076e5e07..2dcd17b3ac 100644 --- a/docs/src/api/class-pageassertions.md +++ b/docs/src/api/class-pageassertions.md @@ -59,7 +59,7 @@ namespace PlaywrightTests; public class ExampleTests : PageTest { [TestMethod] - public async Task NavigatetoLoginPage() + public async Task NavigateToLoginPage() { await Page.GetByRole(AriaRole.Button, new() { Name = "Sign In" }).ClickAsync(); await Expect(Page).ToHaveURLAsync(new Regex(".*/login")); diff --git a/docs/src/api/class-request.md b/docs/src/api/class-request.md index fcf231f754..e13d9de69f 100644 --- a/docs/src/api/class-request.md +++ b/docs/src/api/class-request.md @@ -124,7 +124,7 @@ Headers with multiple entries, such as `Set-Cookie`, appear in the array multipl * since: v1.15 - returns: <[null]|[string]> -Returns the value of the header matching the name. The name is case insensitive. +Returns the value of the header matching the name. The name is case-insensitive. ### param: Request.headerValue.name * since: v1.15 diff --git a/docs/src/api/class-response.md b/docs/src/api/class-response.md index 13ff68b85b..cddaf69659 100644 --- a/docs/src/api/class-response.md +++ b/docs/src/api/class-response.md @@ -59,7 +59,7 @@ Headers with multiple entries, such as `Set-Cookie`, appear in the array multipl * since: v1.15 - returns: <[null]|[string]> -Returns the value of the header matching the name. The name is case insensitive. If multiple headers have +Returns the value of the header matching the name. The name is case-insensitive. If multiple headers have the same name (except `set-cookie`), they are returned as a list separated by `, `. For `set-cookie`, the `\n` separator is used. If no headers are found, `null` is returned. ### param: Response.headerValue.name @@ -72,7 +72,7 @@ Name of the header. * since: v1.15 - returns: <[Array]<[string]>> -Returns all values of the headers matching the name, for example `set-cookie`. The name is case insensitive. +Returns all values of the headers matching the name, for example `set-cookie`. The name is case-insensitive. ### param: Response.headerValues.name * since: v1.15 diff --git a/docs/src/auth.md b/docs/src/auth.md index c008771a5c..1224292775 100644 --- a/docs/src/auth.md +++ b/docs/src/auth.md @@ -263,7 +263,7 @@ existing authentication state instead. Playwright provides a way to reuse the signed-in state in the tests. That way you can log in only once and then skip the log in step for all of the tests. -Web apps use cookie-based or token-based authentication, where authenticated state is stored as [cookies](https://developer.mozilla.org/en-US/docs/Web/HTTP/Cookies) or in [local storage](https://developer.mozilla.org/en-US/docs/Web/API/Storage). Playwright provides [`method: BrowserContext.storageState`] method that can be used to retrieve storage state from authenticated contexts and then create new contexts with pre-populated state. +Web apps use cookie-based or token-based authentication, where authenticated state is stored as [cookies](https://developer.mozilla.org/en-US/docs/Web/HTTP/Cookies) or in [local storage](https://developer.mozilla.org/en-US/docs/Web/API/Storage). Playwright provides [`method: BrowserContext.storageState`] method that can be used to retrieve storage state from authenticated contexts and then create new contexts with prepopulated state. Cookies and local storage state can be used across different browsers. They depend on your application's authentication model: some apps might require both cookies and local storage. diff --git a/docs/src/best-practices-js.md b/docs/src/best-practices-js.md index 3694418533..1cac5477b7 100644 --- a/docs/src/best-practices-js.md +++ b/docs/src/best-practices-js.md @@ -43,7 +43,7 @@ You can also reuse the signed-in state in the tests with [setup project](./auth. ### Avoid testing third-party dependencies -Only test what you control. Don't try to test links to external sites or third party servers that you do not control. Not only is it time consuming and can slow down your tests but also you can not control the content of the page you are linking to, or if there are cookie banners or overlay pages or anything else that might cause your test to fail. +Only test what you control. Don't try to test links to external sites or third party servers that you do not control. Not only is it time consuming and can slow down your tests but also you cannot control the content of the page you are linking to, or if there are cookie banners or overlay pages or anything else that might cause your test to fail. Instead, use the [Playwright Network API](/network.md#handle-requests) and guarantee the response needed. @@ -215,7 +215,7 @@ Playwright comes with a range of tooling to help you write tests. - The [test generator](./codegen.md) can generate tests and pick locators for you. - The [trace viewer](./trace-viewer.md) gives you a full trace of your tests as a local PWA that can easily be shared. With the trace viewer you can view the timeline, inspect DOM snapshots for each action, view network requests and more. - The [UI Mode](./test-ui-mode) lets you explore, run and debug tests with a time travel experience complete with watch mode. All test files are loaded into the testing sidebar where you can expand each file and describe block to individually run, view, watch and debug each test. -- [Typescript](./test-typescript) in Playwright works out of the box and gives you better IDE integrations. Your IDE will show you everything you can do and highlight when you do something wrong. No TypeScript experience is needed and it is not necessary for your code to be in TypeScript, all you need to do is create your tests with a `.ts` extension. +- [TypeScript](./test-typescript) in Playwright works out of the box and gives you better IDE integrations. Your IDE will show you everything you can do and highlight when you do something wrong. No TypeScript experience is needed and it is not necessary for your code to be in TypeScript, all you need to do is create your tests with a `.ts` extension. ### Test across all browsers diff --git a/docs/src/browsers.md b/docs/src/browsers.md index 391e0aba20..5dfd6322ba 100644 --- a/docs/src/browsers.md +++ b/docs/src/browsers.md @@ -763,7 +763,7 @@ pwsh bin/Debug/netX/playwright.ps1 install Playwright downloads Chromium, WebKit and Firefox browsers into the OS-specific cache folders: - `%USERPROFILE%\AppData\Local\ms-playwright` on Windows -- `~/Library/Caches/ms-playwright` on MacOS +- `~/Library/Caches/ms-playwright` on macOS - `~/.cache/ms-playwright` on Linux These browsers will take a few hundred megabytes of disk space when installed: diff --git a/docs/src/release-notes-csharp.md b/docs/src/release-notes-csharp.md index 9172478402..df1d45cd2c 100644 --- a/docs/src/release-notes-csharp.md +++ b/docs/src/release-notes-csharp.md @@ -1012,7 +1012,7 @@ Read more in [our documentation](./test-assertions). ### Announcements -- v1.20 is the last release to receive WebKit update for macOS 10.15 Catalina. Please update MacOS to keep using latest & greatest WebKit! +- v1.20 is the last release to receive WebKit update for macOS 10.15 Catalina. Please update macOS to keep using latest & greatest WebKit! ### Browser Versions diff --git a/docs/src/release-notes-java.md b/docs/src/release-notes-java.md index 54c4963216..3980a1b0cf 100644 --- a/docs/src/release-notes-java.md +++ b/docs/src/release-notes-java.md @@ -1008,7 +1008,7 @@ This version was also tested against the following stable channels: ### Announcements -- v1.20 is the last release to receive WebKit update for macOS 10.15 Catalina. Please update MacOS to keep using latest & greatest WebKit! +- v1.20 is the last release to receive WebKit update for macOS 10.15 Catalina. Please update macOS to keep using latest & greatest WebKit! ### Browser Versions diff --git a/docs/src/release-notes-js.md b/docs/src/release-notes-js.md index cd4ec8354e..043c15062a 100644 --- a/docs/src/release-notes-js.md +++ b/docs/src/release-notes-js.md @@ -1841,7 +1841,7 @@ This version was also tested against the following stable channels: - We now ship a designated Python docker image `mcr.microsoft.com/playwright/python`. Please switch over to it if you use Python. This is the last release that includes Python inside our javascript `mcr.microsoft.com/playwright` docker image. -- v1.20 is the last release to receive WebKit update for macOS 10.15 Catalina. Please update MacOS to keep using latest & greatest WebKit! +- v1.20 is the last release to receive WebKit update for macOS 10.15 Catalina. Please update macOS to keep using latest & greatest WebKit! ### Browser Versions diff --git a/docs/src/release-notes-python.md b/docs/src/release-notes-python.md index 25fbd3ef04..15176ca472 100644 --- a/docs/src/release-notes-python.md +++ b/docs/src/release-notes-python.md @@ -969,7 +969,7 @@ This version was also tested against the following stable channels: - We now ship a designated Python docker image `mcr.microsoft.com/playwright/python`. Please switch over to it if you use Python. This is the last release that includes Python inside our javascript `mcr.microsoft.com/playwright` docker image. -- v1.20 is the last release to receive WebKit update for macOS 10.15 Catalina. Please update MacOS to keep using latest & greatest WebKit! +- v1.20 is the last release to receive WebKit update for macOS 10.15 Catalina. Please update macOS to keep using latest & greatest WebKit! ### Browser Versions diff --git a/docs/src/service-workers-experimental-network-events-js.md b/docs/src/service-workers-experimental-network-events-js.md index 0928460b54..43f32d7e61 100644 --- a/docs/src/service-workers-experimental-network-events-js.md +++ b/docs/src/service-workers-experimental-network-events-js.md @@ -21,7 +21,7 @@ Playwright's inspection and routing of requests made by Service Workers are **ex Set the `PW_EXPERIMENTAL_SERVICE_WORKER_NETWORK_EVENTS` environment variable to `1` (or any other value) to enable the feature. Only Chrome/Chromium are currently supported. -If you're using (or are interested in using this this feature), please comment on [this issue](https://github.com/microsoft/playwright/issues/15684) letting us know your use case. +If you're using (or are interested in using this feature), please comment on [this issue](https://github.com/microsoft/playwright/issues/15684) letting us know your use case. ## Service Worker Fetch diff --git a/docs/src/test-api/class-testoptions.md b/docs/src/test-api/class-testoptions.md index ac6b29473c..d862287f13 100644 --- a/docs/src/test-api/class-testoptions.md +++ b/docs/src/test-api/class-testoptions.md @@ -158,7 +158,7 @@ export default defineConfig({ certs: [{ certPath: './cert.pem', keyPath: './key.pem', - passphase: 'mysecretpassword', + passphrase: 'mysecretpassword', }], }], }, diff --git a/packages/playwright-core/types/types.d.ts b/packages/playwright-core/types/types.d.ts index 01665bfee4..686b493850 100644 --- a/packages/playwright-core/types/types.d.ts +++ b/packages/playwright-core/types/types.d.ts @@ -1887,7 +1887,7 @@ export interface Page { path?: string; /** - * Script type. Use 'module' in order to load a Javascript ES6 module. See + * Script type. Use 'module' in order to load a JavaScript ES6 module. See * [script](https://developer.mozilla.org/en-US/docs/Web/HTML/Element/script) for more details. */ type?: string; @@ -2896,7 +2896,7 @@ export interface Page { /** * Returns the main resource response. In case of multiple redirects, the navigation will resolve with the response of - * the last redirect. If can not go back, returns `null`. + * the last redirect. If cannot go back, returns `null`. * * Navigate to the previous page in history. * @param options @@ -2926,7 +2926,7 @@ export interface Page { /** * Returns the main resource response. In case of multiple redirects, the navigation will resolve with the response of - * the last redirect. If can not go forward, returns `null`. + * the last redirect. If cannot go forward, returns `null`. * * Navigate to the next page in history. * @param options @@ -5581,7 +5581,7 @@ export interface Frame { path?: string; /** - * Script type. Use 'module' in order to load a Javascript ES6 module. See + * Script type. Use 'module' in order to load a JavaScript ES6 module. See * [script](https://developer.mozilla.org/en-US/docs/Web/HTML/Element/script) for more details. */ type?: string; @@ -19011,7 +19011,7 @@ export interface Request { }>>; /** - * Returns the value of the header matching the name. The name is case insensitive. + * Returns the value of the header matching the name. The name is case-insensitive. * @param name Name of the header. */ headerValue(name: string): Promise; @@ -19272,7 +19272,7 @@ export interface Response { }>>; /** - * Returns the value of the header matching the name. The name is case insensitive. If multiple headers have the same + * Returns the value of the header matching the name. The name is case-insensitive. If multiple headers have the same * name (except `set-cookie`), they are returned as a list separated by `, `. For `set-cookie`, the `\n` separator is * used. If no headers are found, `null` is returned. * @param name Name of the header. @@ -19280,7 +19280,7 @@ export interface Response { headerValue(name: string): Promise; /** - * Returns all values of the headers matching the name, for example `set-cookie`. The name is case insensitive. + * Returns all values of the headers matching the name, for example `set-cookie`. The name is case-insensitive. * @param name Name of the header. */ headerValues(name: string): Promise>; diff --git a/packages/playwright/types/test.d.ts b/packages/playwright/types/test.d.ts index aa8b54049b..9d1d053a70 100644 --- a/packages/playwright/types/test.d.ts +++ b/packages/playwright/types/test.d.ts @@ -5229,7 +5229,7 @@ export interface PlaywrightTestOptions { * certs: [{ * certPath: './cert.pem', * keyPath: './key.pem', - * passphase: 'mysecretpassword', + * passphrase: 'mysecretpassword', * }], * }], * },