From 7b1fac90bb4770a1e89be91a414ede6a48575543 Mon Sep 17 00:00:00 2001 From: Dmitry Gozman Date: Fri, 28 Aug 2020 12:05:11 -0700 Subject: [PATCH] test: mark all crash tests as flaky on firefox win (#3675) All crash tests do not actually crash sometimes on firefox win. --- test/page-event-crash.spec.ts | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/test/page-event-crash.spec.ts b/test/page-event-crash.spec.ts index 2c023d368e..e9d458ad1e 100644 --- a/test/page-event-crash.spec.ts +++ b/test/page-event-crash.spec.ts @@ -26,7 +26,7 @@ function crash(pageImpl, browserName) { pageImpl._delegate._session.send('Page.crash', {}).catch(e => {}); } -it.fail(options.WIRE)('should emit crash event when page crashes', async ({page, browserName, toImpl}) => { +it.fail(options.WIRE).flaky(options.FIREFOX && WIN)('should emit crash event when page crashes', async ({page, browserName, toImpl}) => { await page.setContent(`
This page should crash
`); crash(toImpl(page), browserName); await new Promise(f => page.on('crash', f)); @@ -41,7 +41,7 @@ it.fail(options.WIRE).flaky(options.FIREFOX && WIN)('should throw on any action expect(err.message).toContain('crash'); }); -it.fail(options.WIRE)('should cancel waitForEvent when page crashes', async ({page, browserName, toImpl}) => { +it.fail(options.WIRE).flaky(options.FIREFOX && WIN)('should cancel waitForEvent when page crashes', async ({page, browserName, toImpl}) => { await page.setContent(`
This page should crash
`); const promise = page.waitForEvent('response').catch(e => e); crash(toImpl(page), browserName); @@ -49,7 +49,7 @@ it.fail(options.WIRE)('should cancel waitForEvent when page crashes', async ({pa expect(error.message).toContain('Page crashed'); }); -it.fixme(options.WIRE)('should cancel navigation when page crashes', async ({page, browserName, toImpl, server}) => { +it.fixme(options.WIRE).flaky(options.FIREFOX && WIN)('should cancel navigation when page crashes', async ({page, browserName, toImpl, server}) => { await page.setContent(`
This page should crash
`); server.setRoute('/one-style.css', () => {}); const promise = page.goto(server.PREFIX + '/one-style.html').catch(e => e);