Filip/playwright
1
0
Fork 0
Code Issues Pull requests Actions Packages Projects Releases Wiki Activity

fix(docker): take language binding version in consideration (#19924)

Browse source
This commit is contained in:
Max Schmitt 2023-01-06 19:47:37 +01:00 committed by GitHub
parent b376110b77
commit 7bbaf2af21
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
1 changed files with 3 additions and 3 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

6
packages/playwright-core/src/server/registry/dependencies.ts
View file

@ -26,7 +26,7 @@ import { deps } from './nativeDeps';
import { getPlaywrightVersion } from '../../common/userAgent'; import { getPlaywrightVersion } from '../../common/userAgent';
const BIN_DIRECTORY = path.join(__dirname, '..', '..', '..', 'bin'); const BIN_DIRECTORY = path.join(__dirname, '..', '..', '..', 'bin');
const packageJSON = require('../../../package.json'); const languageBindingVersion = process.env.PW_CLI_DISPLAY_VERSION || require('../../../package.json').version;
const dockerVersionFilePath = '/ms-playwright/.docker-info'; const dockerVersionFilePath = '/ms-playwright/.docker-info';
export async function writeDockerVersion(dockerImageNameTemplate: string) { export async function writeDockerVersion(dockerImageNameTemplate: string) {
@ -38,8 +38,8 @@ export async function writeDockerVersion(dockerImageNameTemplate: string) {
export function dockerVersion(dockerImageNameTemplate: string): { driverVersion: string, dockerImageName: string } { export function dockerVersion(dockerImageNameTemplate: string): { driverVersion: string, dockerImageName: string } {
return { return {
driverVersion: packageJSON.version, driverVersion: languageBindingVersion,
dockerImageName: dockerImageNameTemplate.replace('%version%', packageJSON.version), dockerImageName: dockerImageNameTemplate.replace('%version%', languageBindingVersion),
}; };
} }