Filip/playwright
1
0
Fork 0
Code Issues Pull requests Actions Packages Projects Releases Wiki Activity

feat(firefox): support timezone override (#1578)

Browse source
This commit is contained in:
Yury Semikhatsky 2020-04-01 22:10:56 -07:00 committed by GitHub
parent e76f8de474
commit 7c2ddc2e00
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
3 changed files with 8 additions and 3 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

2
package.json
View file

@ -9,7 +9,7 @@
"main": "index.js", "main": "index.js",
"playwright": { "playwright": {
"chromium_revision": "754895", "chromium_revision": "754895",
"firefox_revision": "1067", "firefox_revision": "1069",
"webkit_revision": "1185" "webkit_revision": "1185"
}, },
"scripts": { "scripts": {

5
src/firefox/ffBrowser.ts
View file

@ -96,6 +96,7 @@ export class FFBrowser extends EventEmitter implements Browser {
javaScriptDisabled: options.javaScriptEnabled === false ? true : undefined, javaScriptDisabled: options.javaScriptEnabled === false ? true : undefined,
viewport, viewport,
locale: options.locale, locale: options.locale,
timezoneId: options.timezoneId,
removeOnDetach: true removeOnDetach: true
}); });
const context = new FFBrowserContext(this, browserContextId, options); const context = new FFBrowserContext(this, browserContextId, options);
@ -197,6 +198,10 @@ export class FFBrowserContext extends BrowserContextBase {
assertBrowserContextIsNotOwned(this); assertBrowserContextIsNotOwned(this);
const { targetId } = await this._browser._connection.send('Browser.newPage', { const { targetId } = await this._browser._connection.send('Browser.newPage', {
browserContextId: this._browserContextId || undefined browserContextId: this._browserContextId || undefined
}).catch(e => {
if (e.message.includes('Failed to override timezone'))
throw new Error(`Invalid timezone ID: ${this._options.timezoneId}`);
throw e;
}); });
const ffPage = this._browser._ffPages.get(targetId)!; const ffPage = this._browser._ffPages.get(targetId)!;
const pageOrError = await ffPage.pageOrError(); const pageOrError = await ffPage.pageOrError();

4
test/emulation.spec.js
View file

@ -255,7 +255,7 @@ module.exports.describe = function({testRunner, expect, playwright, headless, FF
}); });
}); });
describe.fail(FFOX)('BrowserContext({timezoneId})', function() { describe('BrowserContext({timezoneId})', function() {
it('should work', async ({ browser }) => { it('should work', async ({ browser }) => {
const func = () => new Date(1479579154987).toString(); const func = () => new Date(1479579154987).toString();
{ {
@ -342,7 +342,7 @@ module.exports.describe = function({testRunner, expect, playwright, headless, FF
await context.close(); await context.close();
} }
}); });
it.fail(FFOX)('should format date', async({browser, server}) => { it('should format date', async({browser, server}) => {
{ {
const context = await browser.newContext({ locale: 'en-US', timezoneId: 'America/Los_Angeles' }); const context = await browser.newContext({ locale: 'en-US', timezoneId: 'America/Los_Angeles' });
const page = await context.newPage(); const page = await context.newPage();