Filip/playwright
1
0
Fork 0
Code Issues Pull requests Actions Packages Projects Releases Wiki Activity

chore: fix the split view, reset window on timeline click (#27007)

Browse source
This commit is contained in:
Pavel Feldman 2023-09-11 18:16:02 -07:00 committed by GitHub
parent d9eabda09d
commit 7c838653d6
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
2 changed files with 4 additions and 9 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

9
packages/trace-viewer/src/ui/timeline.tsx
View file

@ -182,15 +182,10 @@ export const Timeline: React.FunctionComponent<{
const action = model?.actions.findLast(action => action.startTime <= time); const action = model?.actions.findLast(action => action.startTime <= time);
if (action) if (action)
onSelected(action); onSelected(action);
// Include both, last action as well as the click position. setSelectedTime(undefined);
if (selectedTime && (time < selectedTime.minimum || time > selectedTime.maximum)) {
const minimum = action ? Math.max(Math.min(action.startTime, time), boundaries.minimum) : boundaries.minimum;
const maximum = action ? Math.min(Math.max(action.endTime, time), boundaries.maximum) : boundaries.maximum;
setSelectedTime({ minimum, maximum });
}
} }
setDragWindow(undefined); setDragWindow(undefined);
}, [boundaries, dragWindow, measure, model, selectedTime, setSelectedTime, onSelected]); }, [boundaries, dragWindow, measure, model, setSelectedTime, onSelected]);
const onMouseMove = React.useCallback((event: React.MouseEvent) => { const onMouseMove = React.useCallback((event: React.MouseEvent) => {
if (!ref.current) if (!ref.current)

4
packages/web/src/components/splitView.tsx
View file

@ -47,11 +47,11 @@ export const SplitView: React.FC<SplitViewProps> = ({
let size: number; let size: number;
if (orientation === 'vertical') { if (orientation === 'vertical') {
size = vSize / window.devicePixelRatio; size = vSize / window.devicePixelRatio;
if (measure && measure.height < vSize) if (measure && measure.height < size)
size = measure.height - 10; size = measure.height - 10;
} else { } else {
size = hSize / window.devicePixelRatio; size = hSize / window.devicePixelRatio;
if (measure && measure.width < hSize) if (measure && measure.width < size)
size = measure.width - 10; size = measure.width - 10;
} }