Filip/playwright
1
0
Fork 0
Code Issues Pull requests Actions Packages Projects Releases Wiki Activity

fix lint issues

Browse source
This commit is contained in:
jonghoonpark 2024-03-09 23:03:33 +09:00
parent e6bab209d6
commit 7ccb006b01
2 changed files with 22 additions and 22 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

42
packages/trace-viewer/src/ui/uiModeView.tsx
View file

@ -117,27 +117,6 @@ export const UIModeView: React.FC<{}> = ({
}); });
}, [reloadTests]); }, [reloadTests]);
React.useEffect(() => {
const onShortcutEvent = (e: KeyboardEvent) => {
if (e.code === 'KeyR' && (e.metaKey || e.ctrlKey)){
e.preventDefault();
runTests('bounce-if-busy', visibleTestIds)
} else if (e.code === 'KeyS' && (e.metaKey || e.ctrlKey)) {
e.preventDefault();
sendMessageNoReply('stop')
} else if (e.code === 'KeyU' && (e.metaKey || e.ctrlKey)) {
e.preventDefault();
reloadTests()
}
}
addEventListener("keydown", onShortcutEvent);
return () => {
removeEventListener("keydown", onShortcutEvent)
}
}, [visibleTestIds]);
updateRootSuite = React.useCallback((config: reporterTypes.FullConfig, rootSuite: reporterTypes.Suite, loadErrors: reporterTypes.TestError[], newProgress: Progress | undefined) => { updateRootSuite = React.useCallback((config: reporterTypes.FullConfig, rootSuite: reporterTypes.Suite, loadErrors: reporterTypes.TestError[], newProgress: Progress | undefined) => {
const selectedProjects = config.configFile ? settings.getObject<string[] | undefined>(config.configFile + ':projects', undefined) : undefined; const selectedProjects = config.configFile ? settings.getObject<string[] | undefined>(config.configFile + ':projects', undefined) : undefined;
for (const projectName of projectFilters.keys()) { for (const projectName of projectFilters.keys()) {
@ -198,6 +177,27 @@ export const UIModeView: React.FC<{}> = ({
}); });
}, [projectFilters, runningState, testModel]); }, [projectFilters, runningState, testModel]);
React.useEffect(() => {
const onShortcutEvent = (e: KeyboardEvent) => {
if (e.code === 'KeyR' && (e.metaKey || e.ctrlKey)){
e.preventDefault();
runTests('bounce-if-busy', visibleTestIds);
} else if (e.code === 'KeyS' && (e.metaKey || e.ctrlKey)) {
e.preventDefault();
sendMessageNoReply('stop');
} else if (e.code === 'KeyU' && (e.metaKey || e.ctrlKey)) {
e.preventDefault();
reloadTests();
}
};
addEventListener('keydown', onShortcutEvent);
return () => {
removeEventListener('keydown', onShortcutEvent);
};
}, [runTests, reloadTests, visibleTestIds]);
const isRunningTest = !!runningState; const isRunningTest = !!runningState;
const dialogRef = React.useRef<HTMLDialogElement>(null); const dialogRef = React.useRef<HTMLDialogElement>(null);
const openInstallDialog = React.useCallback((e: React.MouseEvent) => { const openInstallDialog = React.useCallback((e: React.MouseEvent) => {

2
tests/playwright-test/ui-mode-test-shortcut.spec.ts
View file

@ -26,7 +26,7 @@ const basicTestTree = {
test('test 2', async () => { await new Promise(() => {}); }); test('test 2', async () => { await new Promise(() => {}); });
test('test 3', async () => {}); test('test 3', async () => {});
` `
} };
test('should run on Meta(command) with R', async ({ runUITest }) => { test('should run on Meta(command) with R', async ({ runUITest }) => {
const { page } = await runUITest(basicTestTree); const { page } = await runUITest(basicTestTree);