Filip/playwright
1
0
Fork 0
Code Issues Pull requests Actions Packages Projects Releases Wiki Activity

fix(binding): catch binding resolution against the closed page (#4583)

Browse source
This commit is contained in:
Pavel Feldman 2020-12-03 10:51:59 -08:00 committed by GitHub
parent 5002b83b4a
commit 7e30669eb0
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
2 changed files with 11 additions and 2 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

4
src/client/page.ts
View file

@ -649,9 +649,9 @@ export class BindingCall extends ChannelOwner<channels.BindingCallChannel, chann
result = await func(source, JSHandle.from(this._initializer.handle)); result = await func(source, JSHandle.from(this._initializer.handle));
else else
result = await func(source, ...this._initializer.args!.map(parseResult)); result = await func(source, ...this._initializer.args!.map(parseResult));
this._channel.resolve({ result: serializeArgument(result) }); this._channel.resolve({ result: serializeArgument(result) }).catch(() => {});
} catch (e) { } catch (e) {
this._channel.reject({ error: serializeError(e) }); this._channel.reject({ error: serializeError(e) }).catch(() => {});
} }
} }
} }

9
test/page-expose-function.spec.ts
View file

@ -222,3 +222,12 @@ it('exposeBindingHandle should throw for multiple arguments', async ({page}) =>
}).catch(e => e); }).catch(e => e);
expect(error.message).toContain('exposeBindingHandle supports a single argument, 2 received'); expect(error.message).toContain('exposeBindingHandle supports a single argument, 2 received');
}); });
it('should not result in unhandled rejection', async ({page}) => {
await page.exposeFunction('foo', async () => {
await page.close();
});
await page.evaluate(() => {
(window as any).foo();
});
});