Filip/playwright
1
0
Fork 0
Code Issues Pull requests Actions Packages Projects Releases Wiki Activity

chore: tree gardening (#23111)

Browse source 
https://github.com/microsoft/playwright/issues/23107
https://github.com/microsoft/playwright/issues/23108
https://github.com/microsoft/playwright/issues/23110
This commit is contained in:
Andrey Lushnikov 2023-05-18 00:54:34 +00:00 committed by GitHub
parent 7b1b2dd741
commit 7ff82760de
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
2 changed files with 4 additions and 1 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

1
tests/library/browsertype-launch-selenium.spec.ts
View file

@ -180,6 +180,7 @@ test('selenium grid 3.141.59 standalone non-chromium', async ({ browserName, bro
test('selenium grid 3.141.59 standalone chromium through run-driver', async ({ browserName, childProcess, waitForPort }, testInfo) => { test('selenium grid 3.141.59 standalone chromium through run-driver', async ({ browserName, childProcess, waitForPort }, testInfo) => {
test.skip(browserName !== 'chromium'); test.skip(browserName !== 'chromium');
test.fixme(true, 'https://github.com/microsoft/playwright/issues/23110');
const port = testInfo.workerIndex + 15123; const port = testInfo.workerIndex + 15123;
const grid = childProcess({ const grid = childProcess({

4
tests/library/tracing.spec.ts
View file

@ -577,7 +577,8 @@ test('should record global request trace', async ({ request, context, server },
})); }));
}); });
test('should store global request traces separately', async ({ request, server, playwright }, testInfo) => { test('should store global request traces separately', async ({ request, server, playwright, browserName, mode }, testInfo) => {
test.fixme(browserName === 'chromium' && mode === 'driver', 'https://github.com/microsoft/playwright/issues/23108');
const request2 = await playwright.request.newContext(); const request2 = await playwright.request.newContext();
await Promise.all([ await Promise.all([
(request as any)._tracing.start({ snapshots: true }), (request as any)._tracing.start({ snapshots: true }),
@ -636,6 +637,7 @@ test('should store postData for global request', async ({ request, server }, tes
}); });
test('should not flush console events', async ({ context, page }, testInfo) => { test('should not flush console events', async ({ context, page }, testInfo) => {
test.fixme(true, 'https://github.com/microsoft/playwright/issues/23107');
await context.tracing.start(); await context.tracing.start();
const promise = new Promise<void>(f => { const promise = new Promise<void>(f => {
let counter = 0; let counter = 0;