From 8264bec01e778fa9787352a4158edcc10eb8b1f7 Mon Sep 17 00:00:00 2001 From: Pavel Feldman Date: Tue, 27 Feb 2024 11:50:24 -0800 Subject: [PATCH] fix(ff): stop gap for setInputFiles race (#29696) --- .../playwright-core/src/server/firefox/ffPage.ts | 16 +++++++--------- 1 file changed, 7 insertions(+), 9 deletions(-) diff --git a/packages/playwright-core/src/server/firefox/ffPage.ts b/packages/playwright-core/src/server/firefox/ffPage.ts index d2d2a03412..a93551b8cd 100644 --- a/packages/playwright-core/src/server/firefox/ffPage.ts +++ b/packages/playwright-core/src/server/firefox/ffPage.ts @@ -544,15 +544,13 @@ export class FFPage implements PageDelegate { } async setInputFilePaths(progress: Progress, handle: dom.ElementHandle, files: string[]): Promise { - await Promise.all([ - this._session.send('Page.setFileInputFiles', { - frameId: handle._context.frame._id, - objectId: handle._objectId, - files - }), - handle.dispatchEvent(progress.metadata, 'input'), - handle.dispatchEvent(progress.metadata, 'change') - ]); + await this._session.send('Page.setFileInputFiles', { + frameId: handle._context.frame._id, + objectId: handle._objectId, + files + }); + await handle.dispatchEvent(progress.metadata, 'input'); + await handle.dispatchEvent(progress.metadata, 'change'); } async adoptElementHandle(handle: dom.ElementHandle, to: dom.FrameExecutionContext): Promise> {