Filip/playwright
1
0
Fork 0
Code Issues Pull requests Actions Packages Projects Releases Wiki Activity

fix(pause): ignore page.pause on the server (#23417)

Browse source 
Fixes #23051.
This commit is contained in:
Dmitry Gozman 2023-06-02 08:32:30 -07:00 committed by GitHub
parent 82ecd692d1
commit 835f14d7c9
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
3 changed files with 14 additions and 13 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

2
packages/playwright-core/src/server/debugger.ts
View file

@ -120,6 +120,8 @@ export class Debugger extends EventEmitter implements InstrumentationListener {
} }
function shouldPauseOnCall(sdkObject: SdkObject, metadata: CallMetadata): boolean { function shouldPauseOnCall(sdkObject: SdkObject, metadata: CallMetadata): boolean {
if (sdkObject.attribution.playwright.options.isServer)
return false;
if (!sdkObject.attribution.browser?.options.headful && !isUnderTest()) if (!sdkObject.attribution.browser?.options.headful && !isUnderTest())
return false; return false;
return metadata.method === 'pause'; return metadata.method === 'pause';

12
tests/library/browsertype-connect.spec.ts
View file

@ -157,6 +157,18 @@ for (const kind of ['launchServer', 'run-server'] as const) {
await browser.close(); await browser.close();
}); });
test('should ignore page.pause when headed', async ({ connect, startRemoteServer, browserType }) => {
const headless = (browserType as any)._defaultLaunchOptions.headless;
(browserType as any)._defaultLaunchOptions.headless = false;
const remoteServer = await startRemoteServer(kind);
const browser = await connect(remoteServer.wsEndpoint());
const browserContext = await browser.newContext();
const page = await browserContext.newPage();
await page.pause();
await browser.close();
(browserType as any)._defaultLaunchOptions.headless = headless;
});
test('should be able to visit ipv6 through localhost', async ({ connect, startRemoteServer, ipV6ServerPort }) => { test('should be able to visit ipv6 through localhost', async ({ connect, startRemoteServer, ipV6ServerPort }) => {
test.fail(!!process.env.INSIDE_DOCKER, 'docker does not support IPv6 by default'); test.fail(!!process.env.INSIDE_DOCKER, 'docker does not support IPv6 by default');
const remoteServer = await startRemoteServer(kind); const remoteServer = await startRemoteServer(kind);

13
tests/library/debug-controller.spec.ts
View file

@ -230,19 +230,6 @@ test('test', async ({ page }) => {
}); });
}); });
test('should pause and resume', async ({ backend, connectedBrowser }) => {
const events = [];
backend.on('paused', event => events.push(event));
const context = await connectedBrowser._newContextForReuse();
const page = await context.newPage();
await page.setContent('<button>Submit</button>');
const pausePromise = page.pause();
await expect.poll(() => events[events.length - 1]).toEqual({ paused: true });
await backend.resume();
await pausePromise;
});
test('should reset routes before reuse', async ({ server, connectedBrowserFactory }) => { test('should reset routes before reuse', async ({ server, connectedBrowserFactory }) => {
const browser1 = await connectedBrowserFactory(); const browser1 = await connectedBrowserFactory();
const context1 = await browser1._newContextForReuse(); const context1 = await browser1._newContextForReuse();