Filip/playwright
1
0
Fork 0
Code Issues Pull requests Actions Packages Projects Releases Wiki Activity

fix: select issue in Windows with Edge (#31270)

Browse source
This commit is contained in:
Fumiaki MATSUSHIMA 2024-06-17 17:28:07 +09:00 committed by GitHub
parent 1cbc67144a
commit 838c572209
No known key found for this signature in database
GPG key ID: B5690EEEBB952194
2 changed files with 2 additions and 1 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

2
packages/playwright-core/src/server/injected/recorder/recorder.ts
View file

@ -356,7 +356,7 @@ class RecordActionTool implements RecorderTool {
return; return;
this._performAction({ this._performAction({
name: 'select', name: 'select',
selector: this._hoveredModel!.selector, selector: this._activeModel!.selector,
options: [...selectElement.selectedOptions].map(option => option.value), options: [...selectElement.selectedOptions].map(option => option.value),
signals: [] signals: []
}); });

1
tests/library/inspector/cli-codegen-1.spec.ts
View file

@ -557,6 +557,7 @@ await page.Locator("#checkbox").UncheckAsync();`);
const locator = await recorder.hoverOverElement('select'); const locator = await recorder.hoverOverElement('select');
expect(locator).toBe(`locator('#age')`); expect(locator).toBe(`locator('#age')`);
await page.locator('select').click();
const [message, sources] = await Promise.all([ const [message, sources] = await Promise.all([
page.waitForEvent('console', msg => msg.type() !== 'error'), page.waitForEvent('console', msg => msg.type() !== 'error'),