Filip/playwright
1
0
Fork 0
Code Issues Pull requests Actions Packages Projects Releases Wiki Activity

chore: replace __proto__ by getPrototypeOf (#17386)

Browse source
This commit is contained in:
Jérémy Lal 2022-09-21 04:01:12 +02:00 committed by GitHub
parent df143031e7
commit 840a1f6436
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
4 changed files with 5 additions and 3 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

1
.eslintrc.js
View file

@ -71,6 +71,7 @@ module.exports = {
"valid-typeof": 2, "valid-typeof": 2,
"no-implicit-globals": [2], "no-implicit-globals": [2],
"no-unused-expressions": [2, { "allowShortCircuit": true, "allowTernary": true, "allowTaggedTemplates": true}], "no-unused-expressions": [2, { "allowShortCircuit": true, "allowTernary": true, "allowTaggedTemplates": true}],
"no-proto": 2,
// es2015 features // es2015 features
"require-yield": 2, "require-yield": 2,

3
packages/playwright-core/src/protocol/serializers.ts
View file

@ -184,5 +184,6 @@ function isURL(obj: any): obj is URL {
} }
function isError(obj: any): obj is Error { function isError(obj: any): obj is Error {
return obj instanceof Error || obj?.__proto__?.name === 'Error' || (obj?.__proto__ && isError(obj.__proto__)); const proto = obj ? Object.getPrototypeOf(obj) : null;
return obj instanceof Error || proto?.name === 'Error' || (proto && isError(proto));
} }

2
packages/playwright-core/src/server/isomorphic/utilityScriptSerializers.ts
View file

@ -48,7 +48,7 @@ export function source() {
function isError(obj: any): obj is Error { function isError(obj: any): obj is Error {
try { try {
return obj instanceof Error || (obj && obj.__proto__ && obj.__proto__.name === 'Error'); return obj instanceof Error || (obj && Object.getPrototypeOf(obj)?.name === 'Error');
} catch (error) { } catch (error) {
return false; return false;
} }

2
packages/playwright-core/src/utils/index.ts
View file

@ -87,7 +87,7 @@ export function isObject(obj: any): obj is NonNullable<object> {
} }
export function isError(obj: any): obj is Error { export function isError(obj: any): obj is Error {
return obj instanceof Error || (obj && obj.__proto__ && obj.__proto__.name === 'Error'); return obj instanceof Error || (obj && Object.getPrototypeOf(obj)?.name === 'Error');
} }
const debugEnv = getFromENV('PWDEBUG') || ''; const debugEnv = getFromENV('PWDEBUG') || '';