Filip/playwright
1
0
Fork 0
Code Issues Pull requests Actions Packages Projects Releases Wiki Activity

chore: remove force_expr parameter from python api (#5295)

Browse source
This commit is contained in:
Pavel Feldman 2021-02-03 16:39:08 -08:00 committed by GitHub
parent 34adc28ed3
commit 847bea2f83
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
4 changed files with 4 additions and 28 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

4
docs/src/api/class-frame.md
View file

@ -1037,7 +1037,7 @@ async def run(playwright):
webkit = playwright.webkit webkit = playwright.webkit
browser = await webkit.launch() browser = await webkit.launch()
page = await browser.new_page() page = await browser.new_page()
await page.evaluate("window.x = 0; setTimeout(() => { window.x = 100 }, 1000);", force_expr=True) await page.evaluate("window.x = 0; setTimeout(() => { window.x = 100 }, 1000);")
await page.main_frame.wait_for_function("() => window.x > 0") await page.main_frame.wait_for_function("() => window.x > 0")
await browser.close() await browser.close()
@ -1054,7 +1054,7 @@ def run(playwright):
webkit = playwright.webkit webkit = playwright.webkit
browser = webkit.launch() browser = webkit.launch()
page = browser.new_page() page = browser.new_page()
page.evaluate("window.x = 0; setTimeout(() => { window.x = 100 }, 1000);", force_expr=True) page.evaluate("window.x = 0; setTimeout(() => { window.x = 100 }, 1000);")
page.main_frame.wait_for_function("() => window.x > 0") page.main_frame.wait_for_function("() => window.x > 0")
browser.close() browser.close()

4
docs/src/api/class-page.md
View file

@ -2239,7 +2239,7 @@ async def run(playwright):
webkit = playwright.webkit webkit = playwright.webkit
browser = await webkit.launch() browser = await webkit.launch()
page = await browser.new_page() page = await browser.new_page()
await page.evaluate("window.x = 0; setTimeout(() => { window.x = 100 }, 1000);", force_expr=True) await page.evaluate("window.x = 0; setTimeout(() => { window.x = 100 }, 1000);")
await page.wait_for_function("() => window.x > 0") await page.wait_for_function("() => window.x > 0")
await browser.close() await browser.close()
@ -2256,7 +2256,7 @@ def run(playwright):
webkit = playwright.webkit webkit = playwright.webkit
browser = webkit.launch() browser = webkit.launch()
page = browser.new_page() page = browser.new_page()
page.evaluate("window.x = 0; setTimeout(() => { window.x = 100 }, 1000);", force_expr=True) page.evaluate("window.x = 0; setTimeout(() => { window.x = 100 }, 1000);")
page.wait_for_function("() => window.x > 0") page.wait_for_function("() => window.x > 0")
browser.close() browser.close()

7
docs/src/api/params.md
View file

@ -479,13 +479,6 @@ Receives the event data and resolves to truthy value when the waiting should res
Maximum time to wait for in milliseconds. Defaults to `30000` (30 seconds). Pass `0` to disable timeout. Maximum time to wait for in milliseconds. Defaults to `30000` (30 seconds). Pass `0` to disable timeout.
The default value can be changed by using the [`method: BrowserContext.setDefaultTimeout`]. The default value can be changed by using the [`method: BrowserContext.setDefaultTimeout`].
## python-evaluate-force-expression
* langs: python
- `force_expr` <boolean>
Whether to treat given `expression` as JavaScript evaluate expression, even though it looks like an arrow function.
Optional.
## shared-context-params-list ## shared-context-params-list
- %%-context-option-acceptdownloads-%% - %%-context-option-acceptdownloads-%%
- %%-context-option-ignorehttpserrors-%% - %%-context-option-ignorehttpserrors-%%

17
docs/src/api/python.md
View file

@ -266,20 +266,3 @@ Will throw an error if the socket is closed before the `event` is fired.
### param: WebSocket.waitForEvent2.event = %%-wait-for-event-event-%% ### param: WebSocket.waitForEvent2.event = %%-wait-for-event-event-%%
### option: WebSocket.waitForEvent2.predicate = %%-python-wait-for-event-predicate-%% ### option: WebSocket.waitForEvent2.predicate = %%-python-wait-for-event-predicate-%%
### option: WebSocket.waitForEvent2.timeout = %%-python-wait-for-event-timeout-%% ### option: WebSocket.waitForEvent2.timeout = %%-python-wait-for-event-timeout-%%
### param: ElementHandle.evalOnSelector.foce_expression = %%-python-evaluate-force-expression-%%
### param: ElementHandle.evalOnSelectorAll.foce_expression = %%-python-evaluate-force-expression-%%
### param: Frame.evalOnSelector.foce_expression = %%-python-evaluate-force-expression-%%
### param: Frame.evalOnSelectorAll.foce_expression = %%-python-evaluate-force-expression-%%
### param: Frame.evaluate.foce_expression = %%-python-evaluate-force-expression-%%
### param: Frame.evaluateHandle.foce_expression = %%-python-evaluate-force-expression-%%
### param: Frame.waitForFunction.foce_expression = %%-python-evaluate-force-expression-%%
### param: JSHandle.evaluate.foce_expression = %%-python-evaluate-force-expression-%%
### param: JSHandle.evaluateHandle.foce_expression = %%-python-evaluate-force-expression-%%
### param: Page.evalOnSelector.foce_expression = %%-python-evaluate-force-expression-%%
### param: Page.evalOnSelectorAll.foce_expression = %%-python-evaluate-force-expression-%%
### param: Page.evaluate.foce_expression = %%-python-evaluate-force-expression-%%
### param: Page.evaluateHandle.foce_expression = %%-python-evaluate-force-expression-%%
### param: Page.waitForFunction.foce_expression = %%-python-evaluate-force-expression-%%
### param: Worker.evaluate.foce_expression = %%-python-evaluate-force-expression-%%
### param: Worker.evaluateHandle.foce_expression = %%-python-evaluate-force-expression-%%