Filip/playwright
1
0
Fork 0
Code Issues Pull requests Actions Packages Projects Releases Wiki Activity

fix(rpc): Frame.dblclick is missing notWaitAfter (#3210)

Browse source
This commit is contained in:
Dmitry Gozman 2020-07-29 11:45:19 -07:00 committed by GitHub
parent 77b1c4b883
commit 84a17f27eb
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
4 changed files with 8 additions and 0 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

1
src/rpc/channels.ts
View file

@ -924,6 +924,7 @@ export type FrameContentResult = {
export type FrameDblclickParams = { export type FrameDblclickParams = {
selector: string, selector: string,
force?: boolean, force?: boolean,
noWaitAfter?: boolean,
modifiers?: ('Alt' | 'Control' | 'Meta' | 'Shift')[], modifiers?: ('Alt' | 'Control' | 'Meta' | 'Shift')[],
position?: { position?: {
x: number, x: number,

1
src/rpc/protocol.yml
View file

@ -1049,6 +1049,7 @@ Frame:
parameters: parameters:
selector: string selector: string
force: boolean? force: boolean?
noWaitAfter: boolean?
modifiers: modifiers:
type: array? type: array?
items: items:

1
src/rpc/validator.ts
View file

@ -498,6 +498,7 @@ export function createScheme(tChannel: (name: string) => Validator): Scheme {
scheme.FrameDblclickParams = tObject({ scheme.FrameDblclickParams = tObject({
selector: tString, selector: tString,
force: tOptional(tBoolean), force: tOptional(tBoolean),
noWaitAfter: tOptional(tBoolean),
modifiers: tOptional(tArray(tEnum(['Alt', 'Control', 'Meta', 'Shift']))), modifiers: tOptional(tArray(tEnum(['Alt', 'Control', 'Meta', 'Shift']))),
position: tOptional(tObject({ position: tOptional(tObject({
x: tNumber, x: tNumber,

5
test/autowaiting.jest.js
View file

@ -154,6 +154,11 @@ describe('Auto waiting', () => {
await page.setContent(`<a href="${server.EMPTY_PAGE}">empty.html</a>`); await page.setContent(`<a href="${server.EMPTY_PAGE}">empty.html</a>`);
await page.click('a', { noWaitAfter: true }); await page.click('a', { noWaitAfter: true });
}); });
it('should work with dblclick noWaitAfter: true', async({page, server}) => {
server.setRoute('/empty.html', async () => {});
await page.setContent(`<a href="${server.EMPTY_PAGE}">empty.html</a>`);
await page.dblclick('a', { noWaitAfter: true });
});
it('should work with waitForLoadState(load)', async({page, server}) => { it('should work with waitForLoadState(load)', async({page, server}) => {
const messages = []; const messages = [];
server.setRoute('/empty.html', async (req, res) => { server.setRoute('/empty.html', async (req, res) => {