Filip/playwright
1
0
Fork 0
Code Issues Pull requests Actions Packages Projects Releases Wiki Activity

browser(webkit): ctrl+click on windows (#11667)

Browse source
This commit is contained in:
Yury Semikhatsky 2022-01-26 18:32:19 -08:00 committed by GitHub
parent b1fbc4fdbe
commit 84a5400d0d
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
3 changed files with 18 additions and 2 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

4
browser_patches/webkit/BUILD_NUMBER
View file

@ -1,2 +1,2 @@
1603 1604
Changed: yurys@chromium.org Wed Jan 26 15:11:07 PST 2022 Changed: yurys@chromium.org Thu, Jan 27, 2022 1:59:07 AM

15
browser_patches/webkit/embedder/Playwright/win/WebKitBrowserWindow.cpp
View file

@ -100,6 +100,7 @@ WebKitBrowserWindow::WebKitBrowserWindow(BrowserWindowClient& client, HWND mainW
policyClient.base.version = 1; policyClient.base.version = 1;
policyClient.base.clientInfo = this; policyClient.base.clientInfo = this;
policyClient.decidePolicyForResponse_deprecatedForUseWithV0 = decidePolicyForResponse; policyClient.decidePolicyForResponse_deprecatedForUseWithV0 = decidePolicyForResponse;
policyClient.decidePolicyForNavigationAction = decidePolicyForNavigationAction;
WKPageSetPagePolicyClient(page, &policyClient.base); WKPageSetPagePolicyClient(page, &policyClient.base);
resetZoom(); resetZoom();
} }
@ -384,6 +385,20 @@ void WebKitBrowserWindow::didNotHandleKeyEvent(WKPageRef, WKNativeEventPtr event
PostMessage(thisWindow.m_hMainWnd, event->message, event->wParam, event->lParam); PostMessage(thisWindow.m_hMainWnd, event->message, event->wParam, event->lParam);
} }
void WebKitBrowserWindow::decidePolicyForNavigationAction(WKPageRef page, WKFrameRef frame, WKFrameNavigationType navigationType, WKEventModifiers modifiers, WKEventMouseButton mouseButton, WKFrameRef originatingFrame, WKURLRequestRef request, WKFramePolicyListenerRef listener, WKTypeRef userData, const void* clientInfo)
{
WebKitBrowserWindow* browserWindow = reinterpret_cast<WebKitBrowserWindow*>(const_cast<void*>(clientInfo));
if (navigationType == kWKFrameNavigationTypeLinkClicked &&
mouseButton == kWKEventMouseButtonLeftButton &&
(modifiers & (kWKEventModifiersShiftKey | kWKEventModifiersControlKey)) != 0) {
WKRetainPtr<WKPageRef> newPage = createViewCallback(WKPageCopyPageConfiguration(page), false);
WKPageLoadURLRequest(newPage.get(), request);
WKFramePolicyListenerIgnore(listener);
return;
}
WKFramePolicyListenerUse(listener);
}
void WebKitBrowserWindow::decidePolicyForResponse(WKPageRef page, WKFrameRef frame, WKURLResponseRef response, WKURLRequestRef request, WKFramePolicyListenerRef listener, WKTypeRef userData, const void* clientInfo) void WebKitBrowserWindow::decidePolicyForResponse(WKPageRef page, WKFrameRef frame, WKURLResponseRef response, WKURLRequestRef request, WKFramePolicyListenerRef listener, WKTypeRef userData, const void* clientInfo)
{ {
if (WKURLResponseIsAttachment(response)) if (WKURLResponseIsAttachment(response))

1
browser_patches/webkit/embedder/Playwright/win/WebKitBrowserWindow.h
View file

@ -72,6 +72,7 @@ private:
static void handleJavaScriptDialog(WKPageRef page, bool accept, WKStringRef value, const void *clientInfo); static void handleJavaScriptDialog(WKPageRef page, bool accept, WKStringRef value, const void *clientInfo);
static WKRect getWindowFrame(WKPageRef page, const void *clientInfo); static WKRect getWindowFrame(WKPageRef page, const void *clientInfo);
static void didNotHandleKeyEvent(WKPageRef, WKNativeEventPtr, const void*); static void didNotHandleKeyEvent(WKPageRef, WKNativeEventPtr, const void*);
static void decidePolicyForNavigationAction(WKPageRef, WKFrameRef, WKFrameNavigationType, WKEventModifiers, WKEventMouseButton, WKFrameRef, WKURLRequestRef, WKFramePolicyListenerRef, WKTypeRef, const void* clientInfo);
static void decidePolicyForResponse(WKPageRef, WKFrameRef, WKURLResponseRef, WKURLRequestRef, WKFramePolicyListenerRef, WKTypeRef, const void*); static void decidePolicyForResponse(WKPageRef, WKFrameRef, WKURLResponseRef, WKURLRequestRef, WKFramePolicyListenerRef, WKTypeRef, const void*);
BrowserWindowClient& m_client; BrowserWindowClient& m_client;