From 85c42939b1a3455fb8b19f7e8d8f4b6934cd960a Mon Sep 17 00:00:00 2001 From: Yury Semikhatsky Date: Thu, 25 Jan 2024 12:55:29 -0800 Subject: [PATCH] devops: do not use broken overwrite: true for uploads (#29160) Reverting parts of https://github.com/microsoft/playwright/pull/29080 related to use of overwrite: true as it is racy and [fails](https://github.com/microsoft/playwright/actions/runs/7641699534/job/20819588957?pr=28932#step:10:63) time to time with parallel jobs: ![image](https://github.com/microsoft/playwright/assets/9798949/cd484e2d-2875-4950-9247-5ea033c6e92d) Reference https://github.com/actions/upload-artifact/issues/506 --- .github/actions/upload-blob-report/action.yml | 5 ++--- .github/workflows/create_test_report.yml | 2 +- 2 files changed, 3 insertions(+), 4 deletions(-) diff --git a/.github/actions/upload-blob-report/action.yml b/.github/actions/upload-blob-report/action.yml index 7cb86716d9..87eda3baf8 100644 --- a/.github/actions/upload-blob-report/action.yml +++ b/.github/actions/upload-blob-report/action.yml @@ -29,6 +29,5 @@ runs: if: always() && github.event_name == 'pull_request' uses: actions/upload-artifact@v4 with: - name: pull-request-number - path: pull_request_number.txt - overwrite: true \ No newline at end of file + name: pull-request-${{ inputs.job_name }} + path: pull_request_number.txt \ No newline at end of file diff --git a/.github/workflows/create_test_report.yml b/.github/workflows/create_test_report.yml index 94ca4b7e87..58a6d3f155 100644 --- a/.github/workflows/create_test_report.yml +++ b/.github/workflows/create_test_report.yml @@ -49,7 +49,7 @@ jobs: - name: Read pull request number uses: ./.github/actions/download-artifact with: - namePrefix: 'pull-request-number' + namePrefix: 'pull-request' path: '.' - name: Comment on PR