Filip/playwright
1
0
Fork 0
Code Issues Pull requests Actions Packages Projects Releases Wiki Activity

address feedback

Browse source
This commit is contained in:
Simon Knott 2024-11-14 10:29:37 +01:00
parent 79ad3e2b65
commit 85fd54aa18
No known key found for this signature in database
GPG key ID: 8CEDC00028084AEC
1 changed files with 8 additions and 3 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

11
packages/trace-viewer/src/sw/snapshotRenderer.ts
View file

@ -427,14 +427,17 @@ function snapshotScript(...targetIds: (string | undefined)[]) {
for (const canvas of canvasElements) { for (const canvas of canvasElements) {
const context = canvas.getContext('2d')!; const context = canvas.getContext('2d')!;
drawCheckerboard(context, canvas);
const boundingRectAttribute = canvas.getAttribute('__playwright_bounding_rect__'); const boundingRectAttribute = canvas.getAttribute('__playwright_bounding_rect__');
canvas.removeAttribute('__playwright_bounding_rect__'); canvas.removeAttribute('__playwright_bounding_rect__');
if (!boundingRectAttribute) if (!boundingRectAttribute)
continue; continue;
const boundingRect = JSON.parse(boundingRectAttribute) as { left: number, top: number, right: number, bottom: number }; let boundingRect: { left: number, top: number, right: number, bottom: number };
try {
boundingRect = JSON.parse(boundingRectAttribute);
} catch (e) {
continue;
}
const partiallyUncaptured = boundingRect.right > 1 || boundingRect.bottom > 1; const partiallyUncaptured = boundingRect.right > 1 || boundingRect.bottom > 1;
const fullyUncaptured = boundingRect.left > 1 || boundingRect.top > 1; const fullyUncaptured = boundingRect.left > 1 || boundingRect.top > 1;
@ -443,6 +446,8 @@ function snapshotScript(...targetIds: (string | undefined)[]) {
continue; continue;
} }
drawCheckerboard(context, canvas);
context.drawImage(img, boundingRect.left * img.width, boundingRect.top * img.height, (boundingRect.right - boundingRect.left) * img.width, (boundingRect.bottom - boundingRect.top) * img.height, 0, 0, canvas.width, canvas.height); context.drawImage(img, boundingRect.left * img.width, boundingRect.top * img.height, (boundingRect.right - boundingRect.left) * img.width, (boundingRect.bottom - boundingRect.top) * img.height, 0, 0, canvas.width, canvas.height);
if (isUnderTest) if (isUnderTest)
// eslint-disable-next-line no-console // eslint-disable-next-line no-console