From 866c60254b8b7370d3d42844442e34ed0bc18b7f Mon Sep 17 00:00:00 2001 From: Dmitry Gozman Date: Thu, 23 Jan 2020 15:44:31 -0800 Subject: [PATCH] fix(firefox): disable ICC color correction based on OS display (#614) This way screenshots will be consistent across host environments. --- src/server/ffPlaywright.ts | 6 ++++++ test/golden-firefox/mock-binary-response.png | Bin 6051 -> 6001 bytes 2 files changed, 6 insertions(+) diff --git a/src/server/ffPlaywright.ts b/src/server/ffPlaywright.ts index 6dba2b2e78..4b3fbb9062 100644 --- a/src/server/ffPlaywright.ts +++ b/src/server/ffPlaywright.ts @@ -369,6 +369,12 @@ const DEFAULT_PREFERENCES = { 'geo.provider.testing': true, // Do not scan Wifi 'geo.wifi.scan': false, + + // No ICC color correction. See + // https://developer.mozilla.org/en/docs/Mozilla/Firefox/Releases/3.5/ICC_color_correction_in_Firefox. + 'gfx.color_management.mode': 0, + 'gfx.color_management.rendering_intent': 3, + // No hang monitor 'hangmonitor.timeout': 0, // Show chrome errors and warnings in the error console diff --git a/test/golden-firefox/mock-binary-response.png b/test/golden-firefox/mock-binary-response.png index be9f4a44684f9120e7906196017816579dce2fa5..e7eaf597796ed93d0b8b1f5755cbd17b4fb4aa4e 100644 GIT binary patch literal 6001 zcmZ8_1yGb<*u98^0>T1HgER>Ib_ro=sa@$*q+IEc?hp_Jsii?WWGN{r=};P^yBj2> zrQy5&=Rfn!d^@u>_kHiZ?|q)nmzR~&a!=iz^?E(}^5(~Z6E1F|+Vk24@_Pc0)Shz-6hC6EckdnyAh*l^P{&H~ z=#iq^h)wGqUd^7FtQ;Fvgr$zHv`I-Q2L}rimXXD_gnw2EQ^M(9B$SX8JIk_~A>+63 z0EWM{_q=J{%QoXE?OP_ZZot`hu6;dpy)-8j`n$M#e)(hql~-E2FEzGljgFViOZzH2YkWqv>6PJyu9~$smoi5RG9BlKAs~1`1MAKfQ%Zy+V?c zsUOmdb)l*FOG`_i=bu1)yrX{QG5QBF7xlsf1WeBMmv&}rk0RhA>irp#s?yT_{)U-| zV+U#O2Z&sDrU7f2^r?tm{g1)k>R~H8J4)8p+zZ~PbJ)W61`gZfJP&E%KPoLpU_wIL zF#64p@0}hVT0A(sJdMh`@w+l%HR|BU$5SK>Cp0hb?HsRPvs#xu(kf3{H>0=iHcY6eXbek3~}Q*3WQsY|LTt2Uf09 zlJrE00S(NPc>(>Le(nSJbOiUTtDZqMmnlkYxt0+>{=s+MzH-xF(?O00%W@Zgcf%|; zL<4e??jHRt?Aoh($}o9mDB?g%qA^&kCuC$~1ot>x^=^l|?oc}Y?zgdG!}em%K>{6)M3FGSPeOj7Qa# z5l1ehMut)T%=aQ9B4iPWn3NPnZ|`eyV-s_8ez!mR);2crQ0wR4M2*R_nIwJbAiTIs z7J*Tu@fAE<_kE>x6G>@lXMM=s+}vb+wO7BmbV28z_r9;XpLZk^JoGW@t74Q#${u

<0g|XJM)hZ=&#n zzV+AW`QYctE>^cmj%z)S?%usif@{@Ab{)+*)RpS?C{+hT;z|Th69`t{ZPOVHFg7>u z%(%TWkDwFHt&k3gW;dMXlTX`1|Cdp_as=1e7|ozZh@|9Gpcmq z-P$k9*WZO`kkZi=A04?wNCXB3wsmwYudW8b_|)vjk(_W;2eVnE^rVi!lGt|8Rp+vx zeHAC3(@c`_yLZ24Yn{6L`^T3-xTE9a<=oxj10gH~5fKy@sP8&=yP^t7~OWo7R@jelU6j}Tk;)4wD=oD}VWQTT{PK$eq`(R#+w z>@zL$T5Ntqa9mv6o`w2pW+S$z?rtrK2Lde@u4rCeLYIw-e9uWv=5UgG_wLy*wFLg9 zwY{8>`1%1NrU1;JL;u5mYu%Y8933DX^3+joa6=vt=Dw?vtZ*O{#GmboyK%gu}oNXp!X<$HyjG#3H+45Rfm+AO~ zL_$2;msoS1w2+x(o$Ud-Tc*qRKf9?oT`swqXi=1u1tCQGi87iu@rV}D4gKQdaIbvH z+S$QjDPH@{m;C&Exw&fVDSs0GbaAiwvX6~iaR6sK&{Q8u{JXlkUM)SO6KN~bsfgo8 zqKFUdg-nwM;dH1Y^BiBx-J-#h$pg2jFm^`$9rD-A*e2R!*>N>>b%#A%-zt-u+;6W> zA<~OmTRp^*SN6AR1qB7}J7t|D(xoQdF@h*B5VB81G`X}N;(B_|_6)mM-7{5TK2tORHVcEne$39Mu5?B&NX8xg z9vCUqh6a#WPgj0zKMEf?@HkrMO#7Bj-|~y7){*USf5xUrnfmhyBUX>jvo-lub}p9{ z0oN{2!Rul{_T^GJ8bkGNc5l3PpM{2nxr~dmv*S5AISEh`QBhHy66X{Zq3Ojvp9Cyk zpDs*Dya6FuY7M$iK%kksazR8{I32>fCZFSRe@KhFk3|BPNEF zmX0o3qugeu>M|%MI@%9``PtixK07eWLwA=l0R*BWB@H0x#Kpl?=St0S@ zMC3VkIMJUoQojTa3m5O|A^ zHZ`g@(vPd4bE)$Ed9&^tAI9cWuT!b0sEFNO9rYCG;|GL^10XCwvuJIGJcx)@ChI@W zi$*n0MVVO>{0_|hqL2UH+xvX+Bk>=2$ViCBt5=Bk@5R#7(-j`0P^#U|*W!d@X)qr? zx&+ttd=#zU`tAz>JLH#i^2{`6m+kRz9D>JD85yd|%0%bq=iIMLKiJOIJzJdoqDvC+ zrh^)XeJhZSmO^wjiz4Nat9Y4($xhFmnwpx=dJ z?~y_@W*X2DRDV*^Ur(-b;ERbWgIcMd93SHo5Uh+B>$xE~IXEnOEb+f^uS;BnmA|yV zTvZGkstMT3qEk*bY=GaLih5=5>}*YjF@O(|JxWy7<~*Wt8mV%4K=YY^U64^T3v#Vr z+4*x z4GryfoLQ!ddBkjNZ2Z5oK*_}G?B^B6okz6Wz{A*|Ev;J1mPATlbt`t`P;FqgHiKb& zZ#M?N>>|s`%A}6nxLSzGlx2$%WOyf>{rQ9bjd0DLXRkzABg%9MbpWaZ@M zCd4yln1zHAzG~(fSy>e*U0l>Zb;|MmrkQ*+I%7ZTxk0oMxU}4DA=qhDV}$GJ;|=kA zn(hI@N}a77H$AO8JUmRvYZSoOq?gF#e+8+(@qeKzTO-Qcrwj{?d>(tnw-s{J^@;HI zV@Hj6L1Cf1swz7iPRY+-!Is+miK*Ej%$&YLaS z^08e#J;Ueo#r>K9P0#jQiGdo`cC2`u+x5gZpisPA(fl~$Kt@o2(aXz=iJ4j0VYyA* z&VBBkmbP|<@2!u&zdwwZSH0gvm7=ZY3;uTrPl?7suZHFrce}1JGc&U-S{Le-2>xl` z>ur?S@t}+{COQtEvvP(U0)fy<`dm?To>_vaj@A-Te73W2oZnR!f+aHnB)us@dl7ps z$hf`~A?BR6!NI76H=ZH9#vS`$i)3VEts!LWx^sgU-B?n4Ku#EI-maPZfVIWWILPL&~T+K$^VCZY;5cbOf)(^uA!qNe|vKc zk$!7pBCD&bo8mje)>G^BJC2Ja;O*iMzg?B9oAIoIf>1`8PZlYoslravR~j?2Q)R|@ zR^O=^@A>)p?aniu70Uq@m6DRu1rqgCFh#A911zDG2$Q-*FfuYWpRw2I4kFHOWn8Z(rs z@pZD?G^~GOOZI#@3nHF+nc|B&UKxMIk=0ZsHnK>s;s7_c6rF@;^NYqE=~jP z6?H=tzZ&_f$=-Cno`T9gBz{UAyZ7qVE2RtxI!@NPdbf$G0NqUT$B&nHcF=L8C=`m2 zkg&9>s_D0WmmMo;c|Met@vg70ThG=&L`6lj-K1~TDIC=l3JHFn0@3p9>5US`? zy{11U+%$QK15UZ&po4}--K;M;u)bbYSXdZL)7e=s(J?;$8RWiw-J(E+`9KFC;qX1% z)s$X4dnYI3{l%ZF>#G{N8W)8Oi;Z!^F&d7Jj`nVD=0MQ#r~~#t*x!F5#GX)IVY+ka z$k5c(6c7}o>6{x}ljGp-?!LbyDY@FU#4L8uM%DmZ!Z|!T^qt_S6|MziB-GT?B0V9q zWYbNnvVZPBP^ECJI_8!$5AEvf&dGkgsduQd?yyy_IX!Vh|7&WvBDG6=NKhd|!n^Cm zz>`Z0!6{^g@MmwOOFM(xTjn_QG2zAW=7>mWbTs5Yaec7&*1nTlDF>(4oFD=O0#S^a zoSKHv(e(}IDC(4(bTc$@8`Q;ZY*_4A@9H9{U~iunHWyxE5HDXo!p0@Eplk2!%o}?r zc$2TLqZ1MtsfyRLJLH$eETZNtix(QP@q7qE$03r1Er)c@+z5V1PWS%@+YB(|$#7!kKWXbgsVui>a4`tS&N6cv^uY-tpC zZ)a=X#Q`y`q^vwu=faiYdn4Q$MBLfk9kRS^1e)MV3as&o2~AB+8EYQ_I@h!#q4ZcBU$V zqM}IF2QnffBZ;xFuy*F^Db!qV@>DbWK?k|H&@72TMy~(x!~Re%TI+dYb#-+`3Acap zt?AACd;td+1b(I;rH?J0sLX>*Sm(tb7@<--M%W;Z3nfAHQDGT1WK{(*RL?J zP}AifQQP^3?ku^m;IJ@eI6N^g!$;T4W5NK#tye_|untf}qM!{mXjacIFJpm>tgRK6 zmzTfu{&)yUNkbExp048P2;>^rNN{*~`^X5Hxw*MYnn-&Lt0IZ?;@;i>nA_gP1&qX& zm-EHM!~nQ4>yBY9dR=x`Pfu@oW##CEY@PGymcX1_BvIDGyMiY*g7$^eEMc8?R?&(ng zFjiVoVcZkPsgy28MLT%z0 zdU9l7AdZfX4)Dw5ytG3)GQJDGIgC$ERsdapB?mb8>3X-d)z!fqMG8_0p%t1{ZPJYMcK4&I3f_;P`m8PiO%!PBcil3a8&HAfbapLtEP01H&kwj+?`*|4bvW zhx_;Mv#_v~f-VGzlVCKu4V(ukihqU!IC*&mg{+zyN=Zpc5PMxhQnzqW&7{43eR{Jp znMFl}Aikd-()9qLNhM%GV)Z@w_}F>gbDJlC1kE6semd_JX`bQz7(D*24M9#EV4k$y znQDIL4K=`X2p=B_&_lF=6O4-^cl|Tl-4)I3vDbKdCkM(eC^&w@ADB%e8CqI)mm0Q~e*fM+ zH)n9UvIq7Db6QubbK8pm5CY0={DvCbj0X;+sHo_LvT{yCLn^49-FMj7*uvfy0>B1f zVPhKx{UR+b?f${RQY*3KD(GJB;o$)&IyzDZIjJHi7ucUtHaa>A(?vjc60oVq#$2M1?5qLlZ)Hw`a* ze41QqN=i!Bf!UKP;axXXO5F3!t;{Jo<8jve^J*t@h zg<}U~92PdNbEZ9w0`Rh~FHe61+;3J`^C<=%LMA9e;3QcvjAQ}f@YdE=#msE|n?@~) zi;th5S4fDRl~wLC@iAzl34w`&OHAD>l(e9xuKp8X6OMd|M;D?QOV;Gi@knk7Yd~>mFX095R@e6=+nPDq#OG`_l ug!ctQRX|`M`2Wew{6!(hKN8`;A*QT*&&eZ{Z3L|JJMwZWvL(`Q{r?BPA-)^{ literal 6051 zcmZ8lWmHsOwAa5VsFZ}XbW68@h#(~l%@ERpgv0;}N{oa8<1m19IEqLk-61st3|+zy z5<>_g-Te-0y$^4_55QX7bMM*b?EQxqxRW|ZVUz_rO*6(|9xOMQyFz^9y0{M^`-xFd&8Q!Rs`SGCgd#+oPKH_<& zo4+T7p9x^cY++}cw3C&tQMK)3oypEO6ZFWry~dx7J(%TSx!0uh@NM;I4hHYogsz@k zeLe5(2e;brFWx!X3%c#2UQZdcN_u*4K1DA-Kfkl5XQ7Qk>3d<}KZnH?I(2({&K%t@ zJaTd=fhYU=78WPkGaFP|#>TYH&d#!Oa_q4hltfpVn3z7r#lfMnLi9UJy=?;nl**KP z#>Ngk$zuIs!~B=a^YZdY?^>ps{M{Lo#m<3BNTBUb6q+YsKZ-13XtDDh(Q|j*E(`vdE7~_{`|&)mHM?Uh2g^!iPzpdU#FfD8yg!dC@SLm`m&3PAak(E zjH!Cx=sd$54w8_D)I)zN&j9M3qJYPTi-A3j$-Pq_$K5=i&4=n&$IqLZnwI#i7-(r} zSuv^^8dCG>qMwfznk}!aD7KV1jMQO?{y5yRs*A2o+CS$iJ^?{fG^ym7YQI*eBr-BG z(ttqL8M`QyPMe#9uRWp3t74QsM{D<-i!9MxM4u9WIZd`>eq$*uBf~2!j3N*SbO_k~ zKeM|+=3FLmXyGcPc>#Uq_2=tZjfX5+ZAUC{qm$*2f9_IJJ~A{k9MfZFVbL!a{cc?% z)Acr$B;=i{F~id@u?@AZ+}?=Sz7g~A`_yAKDIBPj6o$dUL7KaFho+`Zr|7R=zkc7m zf`poynn?N47;Y(#-j;h@`^1ig{C4(NJNz|e%9xbD_G41|nBLPF|LgxT45eUF|x zq9+g=N~88lzIKABGO8u&bIf5Ak3_xam?3QB{(@|Fc6P%~pM1I!{AV{Ppxbo97(AXH z6i~I~^Ufhk@cIM{SCia3a^_lkJB@A0!ZAPkY)TV(#upn4w+d4=u3hEMs;au{;o(6P z`7XAe(<&{A%6tXE=YKZxlyUGfeDsw5hqJ`w- zh2iNpa3`32cK5BZonVMJNN1m<3hl(fdFD+3c#x#!$t zFE6hM1mdkDGSOuyBx9oEUGNUie50G(^duF%tcSSEQlp-}e#@_431m#to+tZjeUN%r z&WQqOF%>QCdn17-F&d)u?)}STgJBCB%^P|G zarVgvtpLaunU>ATJ3Ly7L5Mj{JN$bc)yn8#{IH+D|4u*ryj(D6a<8_(@3VZY2A7ko z>u`=PE6CLOz}1G>V{-Nxw~h@xM)IAUuP?t2BP2$nO3idTU?}otn;ONw!K;U?z01t= zJ5r>{XJCVoMS90ZdU~VH$vxrILZ6N*{I@f)w5pIcDUdB%J!!+|O#5i>J0zQp$04E#b7 zAO%1vI+}uvj7;P%H#_@PWy;OX&Dp_B^(!y@e>ne zF24l2y1TIfyxiQ8@SfDvRJ!mXJYM6`qbnh7l+4Ui*@A8^E`<7xpPU>VAy$nGYoY6G zu2V`#yQRDzNb`F7ybleHF}ZwV&Kv$~`3CCz4L+>Y2Zd@eT9^%aHHf{>Tgj?md(4oN zy?q;kR+%qU68S!=Rv`fHARt@s)d>Rjrb|18&7Ayutae z^+I%K#H3Ygzaqt_syWPhx*N&KMBjkdEkps<4GRzVo^OwW?CfCatl8pl17l-w8?5U_?~A4C$pTSJo%cK-Bd78gg?)jg=Ktra29 zDl4OMb#(>R*N;{ttVTseEi5jU+O+%!lbvpBL5xjrFsfa|l-lhbuM{@Gmuq-s$5{y4 z7c)NT(`ZzWk@ZUnlcHz11VQM;LSs!0{k3b?Mt=R0d;JgpQ3coEpYx(0otu}p^$Ti! z)${KNe`{MCw!JbuleW0AX_lXU+zUAXeaQ`-FOIKq`fh?k$R;DeHw*LVQ&=%-8~ zdinCDhL#o;^uO-zZZQc7kdG4Au_C(gPibi%!3pZ>>IyCEt9r|T_T*4=tD6{+l47l=u9fA$Fv%7w;O6$UIL?E2sHO;lJFwXE>cEG z5@kx$rl7NrDn}D@+GTEki5dz;zu9(fJU-m+wvk*VR^XJ679V&Qf_0Zs;vX0LA zB&eU0MLrrIbIg}u$pDJC)#GMA% zwmy9*ii>J+4ZPLfA3oo8Y>vNyYVo#bMl;Qql5O7=>*?){jE>Iv{ypr&hZ~?ABch`_ zfQH^gwNR%=d8Kn-HZm`mJc4 zZ8fJjSRgrNN;{(5M6TWRa-&!V zbx=&Oyt3=_Pb`=CgoQzHYCq9C&%Z9CsWb;~n|)Uc5s$V)2TS`EF!C8QHf zrb6wwW3EMGAVsT&Vjh=@M<8w;EgNeh+y>|a&d=F{d8H)?jYn<>bXhR@Sx5(=);W*4 zZN?C@Je)%zCMG7bo7%6NSyB=+UjAY@Q$2e0$ha$nSJrhgw2fC*=rbn9p`89ipQ8=h zrvhKT0w|(2>?T26BZu#jB^DM$9ee0UMn+;>^6cg}a0^XYqVol$6~_n4`Rw)!saPZ= zy2bHBcung?nOG3x-rgRw{A=XbuWUZAUOh>_Q^2_Z$6O#{imx`!_23J+rarX}Fbz>C z3uFMwAR;D?`|_oD6VHM&{QLLs;X<75=I*YlKmtM*ID(k`JR52EWYhQBIy#XkRCaFe za;=D;qQ}VCnD_3o{(sl54GzX0xKF%ZGCfAp6d>nZQG`@vb+wE&{H(IoDu)~W;G3e? z0tq7{qZ^N#5DtS01J()@@~2~+wUM+M`v0*cDz5eC-Q{YVB0%(eF)KAf)?XsZuSO=&wh<@yPOCMw`~C5I*G zr%F8V!P4Gef%8lHG-oYnXJm&!`KfRnQ`jDU%> z=H3wzG`~9oEX&Q?w}A}U*xF{4+^SUJ7Zhyk>be!F+B%S-5{r9I&%mH~VBWdG4M8hJ z0`Gc!d>pVlsJ^@Yn+dD|k~$e!#nP21WI;)EG+lxHNXMC=Ra#lO*p(m%h~bO>!Fr?D zN=qm)5J6ifr--sLaWgYBB&*UrLz-{0%1uQ@iEY;M3CGd zrGEqtSnWQ|!OKgmsHn)Ji`E9O0t=z8qZ3tFcprk6jm*m82GyLCTN1%UD-*Os9f0-$ z!M=b0o|InnT|`90KHuEj9DaOU-^dix+m*&F=S4(EN5{d*S^IjA5vPd*kG86t&Z15? zwi%>cXe6@xXYFuUC}UP`35mSCJg^M%YW%_icPBp)zS$MUTV{X@7%Q^M1REl}-b@;J zWrTGn34i<&NNczlrG@y2kXOIVsNXuQ?{50y%NDb~&x*X~7K0ZTBrD*bFWuba)j;P0 zM8nqEIWh}-L5v%s0;=@gz`29(`0X(Ui;azsSGBVvus-DG=DtHm7yc6+)WO%+*T*sq zJy4GV#v}dnXL&W4m)EyrTFdmH>D;2c791{*X)$Lo>Kj{~K8>mjB4k-jpYk`~t#3?E zlzlS!BHU@N|L;SLL}q+qVj27*Xn$j-pUyf!+1YtTu%0C|)6X&9xWEMGAs36gY ze0&j~K2ee1Q_yg7;sf0U7`DtUE@A=HuizW~Wo&J2FS~JKVqzYhRE*3_z_rd|$oZlO zyrs973<`w;|ELK_0&r`l@5VGAKmX;+U|HMQ$$_S(rfp{oJ1K*B7{$ZGcL1JOx9gua zHa5b1e7GbfX>^*5$0sxzRa7J#85vn<)yN3&F#5xyBgr}_5*Tdp6eIxNFLo1+@358QCW%W?7T9&)32n?69)rl5SNe`92j5|5utcT%?kld1HQtU8i&Kt z)6?sjo8Ni_fsg|$_uRoj%xggdybiu~hxO6o;^Gs)L|a>1VCJ)Vb}$2~A~Z9T6HsJN zs?^7r7|M!@ip{+}T2@6-=OHeDI~WY6tgaq@dK&P7g0;`JxN)?oP7%5{I5b4)Ns$;C z9YyFS)Bv_JH#h&Dl@2Muxx4rMuJ=9K>R?@&X;Kmv7XF@{{V6rI zE8n;P-vn0zwx#pAIGEv$gLammpC34ALn|v(S{f73kF^JpFVrrRXJ{A)`h-fk0U)1Z zQc~F8zX4!<#b4q@!Bj*>CMk+Z24SIHUS6IeYI_+zp!-N}k^A?NivIhv>+7h}QZYIa ztA*dbGf#ANqkmXbZ-aQ|*Vc4izm{h6=#Gz%_q#Yd;1?00V|`d|-$B0rZ#*<9iH?|@ zd6xC!kQg`%3U#UqiVQ@?*tRvv>B7g|)41APEC z93;v1aC7c*000&M%z>V~xw-j@prD|%$24j4_G0(o=;%_E%=9A=($#A>N_;o09tEXM zH@w*q6%)H83(Yv5NV>+`w{OF|y;VTsz&(0{x#MFM6>LAqvVn<-8YloT4&7awqyxKx zIy~GR)~)s3xCfwv>F5B#5mVgLv$XuNX?q`N?X&vVQLAIcI{;$&1qIIT?mR+5WPmon zWT?h#@fPR>2)T2!VJpl&?2e-Pw7^M$iL4m{1R;}L!bm|!za_;Ljku1L909&}Zxd~g=jjT5&5)Yoz z{H;b=U(d?TjbM>~&DYQ1HuEG(QF4OIUVr>izmQyT_Yyv5)jY|&`}*PbGQvywD^?8rk{})k`Bg@aY7bV z5yg>w2?+@`H8r9EcuydDn&7R<%1V%>hTRdbJi?eZpw)C)SO_oya|FVWBm0luvxgng ztiTvt7ZMV>LB<$XP_W7>E%)HTx2&x9A3xp(4?PUuPW%>znwjC2deh8GY_0;TgySnf o^9?dS<(_BEuH_5PfV?0kKahU`Hwnjq;rkWMClJ-5$2KAV1Gu5|hX4Qo