From 8699d3b9c5eaacfb6ba645764832bcf6a6a5b0aa Mon Sep 17 00:00:00 2001 From: Yury Semikhatsky Date: Tue, 14 Jan 2025 14:57:42 -0800 Subject: [PATCH] test(bidi): create inspected page before initializing recorder (#34323) --- tests/library/selector-generator.spec.ts | 6 +++++- 1 file changed, 5 insertions(+), 1 deletion(-) diff --git a/tests/library/selector-generator.spec.ts b/tests/library/selector-generator.spec.ts index 1feaf538e7..1dcd50ebd2 100644 --- a/tests/library/selector-generator.spec.ts +++ b/tests/library/selector-generator.spec.ts @@ -28,7 +28,11 @@ async function generateMultiple(pageOrFrame: Page | Frame, target: string): Prom it.describe('selector generator', () => { it.skip(({ mode }) => mode !== 'default'); - it.beforeEach(async ({ context }) => { + it.beforeEach(async ({ context, page }) => { + // Make sure `page`(fixture) is created before enabling recorder, so that + // we properly wait for `extendInjectedScript` call to finish. Otherwise + // if the page is created later, there is a race between ConsoleAPI + // initialization and playwright.selector(e) call in `generate()` function above. await (context as any)._enableRecorder({ language: 'javascript' }); });