Filip/playwright
1
0
Fork 0
Code Issues Pull requests Actions Packages Projects Releases Wiki Activity

test: update download test expectations (#6394)

Browse source
This commit is contained in:
Yury Semikhatsky 2021-05-04 18:59:39 +00:00 committed by GitHub
parent 5326f39021
commit 86df1df8e7
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
2 changed files with 18 additions and 2 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

12
tests/config/utils.ts
View file

@ -58,3 +58,15 @@ export function expectedSSLError(browserName: string): string {
} }
return expectedSSLError; return expectedSSLError;
} }
export function chromiumVersionLessThan(a: string, b: string) {
const left: number[] = a.split('.').map(e => Number(e));
const right: number[] = b.split('.').map(e => Number(e));
for (let i = 0; i < 4; i++) {
if (left[i] > right[i])
return false;
if (left[i] < right[i])
return true;
}
return false;
}

8
tests/download.spec.ts
View file

@ -19,6 +19,7 @@ import fs from 'fs';
import path from 'path'; import path from 'path';
import util from 'util'; import util from 'util';
import crypto from 'crypto'; import crypto from 'crypto';
import { chromiumVersionLessThan } from './config/utils';
it.describe('download event', () => { it.describe('download event', () => {
it.beforeEach(async ({server}) => { it.beforeEach(async ({server}) => {
@ -361,7 +362,7 @@ it.describe('download event', () => {
expect(fs.existsSync(path.join(path1, '..'))).toBeFalsy(); expect(fs.existsSync(path.join(path1, '..'))).toBeFalsy();
}); });
it('should close the context without awaiting the failed download', async ({browser, server, httpsServer, browserName}, testInfo) => { it('should close the context without awaiting the failed download', async ({browser, server, httpsServer, browserName, browserVersion}, testInfo) => {
it.skip(browserName !== 'chromium', 'Only Chromium downloads on alt-click'); it.skip(browserName !== 'chromium', 'Only Chromium downloads on alt-click');
const page = await browser.newPage({ acceptDownloads: true }); const page = await browser.newPage({ acceptDownloads: true });
@ -379,7 +380,10 @@ it.describe('download event', () => {
page.context().close(), page.context().close(),
]); ]);
expect(downloadPath).toBe(null); expect(downloadPath).toBe(null);
expect(saveError.message).toContain('File deleted upon browser context closure.'); if (chromiumVersionLessThan(browserVersion, '91.0.4472.0'))
expect(saveError.message).toContain('File deleted upon browser context closure.');
else
expect(saveError.message).toContain('File not found on disk. Check download.failure() for details.');
}); });
it('should close the context without awaiting the download', async ({browser, server, browserName, platform}, testInfo) => { it('should close the context without awaiting the download', async ({browser, server, browserName, platform}, testInfo) => {