Filip/playwright
1
0
Fork 0
Code Issues Pull requests Actions Packages Projects Releases Wiki Activity

feat(devices): add more Android device descriptions (#6413)

Browse source 
Adds device descriptions for:
- Galaxy S8
- Galaxy S9+
- Galaxy Tab S4
- Pixel 3
- Pixel 4
These devices are regarded as worthy of targeting by BrowserStack.

Sources (both have identical data for these 5 devices):
1. https://github.com/aerokube/moon-deploy/blob/master/moon-local.yaml#L199
2. https://www.danhendricks.com/2018/04/adding-iphone-galaxy-chrome-mobile-emulated-devices/#heading_device_data
This commit is contained in:
Michael Rienstra 2021-05-05 14:02:28 -07:00 committed by GitHub
parent 765d74987f
commit 8737207d5a
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
2 changed files with 120 additions and 0 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

110
src/server/deviceDescriptors.js
View file

@ -151,6 +151,72 @@ module.exports = {
'hasTouch': true,
'defaultBrowserType': 'chromium'
},
'Galaxy S8': {
'userAgent': 'Mozilla/5.0 (Linux; Android 7.0; SM-G950U Build/NRD90M) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/62.0.3202.84 Mobile Safari/537.36',
'viewport': {
'width': 360,
'height': 740
},
'deviceScaleFactor': 3,
'isMobile': true,
'hasTouch': true,
'defaultBrowserType': 'chromium'
},
'Galaxy S8 landscape': {
'userAgent': 'Mozilla/5.0 (Linux; Android 7.0; SM-G950U Build/NRD90M) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/62.0.3202.84 Mobile Safari/537.36',
'viewport': {
'width': 740,
'height': 360
},
'deviceScaleFactor': 3,
'isMobile': true,
'hasTouch': true,
'defaultBrowserType': 'chromium'
},
'Galaxy S9+': {
'userAgent': 'Mozilla/5.0 (Linux; Android 8.0.0; SM-G965U Build/R16NW) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/63.0.3239.111 Mobile Safari/537.36',
'viewport': {
'width': 320,
'height': 658
},
'deviceScaleFactor': 4.5,
'isMobile': true,
'hasTouch': true,
'defaultBrowserType': 'chromium'
},
'Galaxy S9+ landscape': {
'userAgent': 'Mozilla/5.0 (Linux; Android 8.0.0; SM-G965U Build/R16NW) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/63.0.3239.111 Mobile Safari/537.36',
'viewport': {
'width': 658,
'height': 320
},
'deviceScaleFactor': 4.5,
'isMobile': true,
'hasTouch': true,
'defaultBrowserType': 'chromium'
},
'Galaxy Tab S4': {
'userAgent': 'Mozilla/5.0 (Linux; Android 8.1.0; SM-T837A) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/70.0.3538.80 Safari/537.36',
'viewport': {
'width': 712,
'height': 1138
},
'deviceScaleFactor': 2.25,
'isMobile': true,
'hasTouch': true,
'defaultBrowserType': 'chromium'
},
'Galaxy Tab S4 landscape': {
'userAgent': 'Mozilla/5.0 (Linux; Android 8.1.0; SM-T837A) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/70.0.3538.80 Safari/537.36',
'viewport': {
'width': 1138,
'height': 712
},
'deviceScaleFactor': 2.25,
'isMobile': true,
'hasTouch': true,
'defaultBrowserType': 'chromium'
},
'iPad (gen 6)': {
'userAgent': 'Mozilla/5.0 (iPad; CPU OS 12_2 like Mac OS X) AppleWebKit/605.1.15 (KHTML, like Gecko) Version/13.0 Mobile/15E148 Safari/604.1',
'viewport': {
@ -969,6 +1035,50 @@ module.exports = {
'hasTouch': true,
'defaultBrowserType': 'chromium'
},
'Pixel 3': {
'userAgent': 'Mozilla/5.0 (Linux; Android 9; Pixel 3 Build/PQ1A.181105.017.A1) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/66.0.3359.158 Mobile Safari/537.36',
'viewport': {
'width': 393,
'height': 786
},
'deviceScaleFactor': 2.75,
'isMobile': true,
'hasTouch': true,
'defaultBrowserType': 'chromium'
},
'Pixel 3 landscape': {
'userAgent': 'Mozilla/5.0 (Linux; Android 9; Pixel 3 Build/PQ1A.181105.017.A1) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/66.0.3359.158 Mobile Safari/537.36',
'viewport': {
'width': 786,
'height': 393
},
'deviceScaleFactor': 2.75,
'isMobile': true,
'hasTouch': true,
'defaultBrowserType': 'chromium'
},
'Pixel 4': {
'userAgent': 'Mozilla/5.0 (Linux; Android 10; Pixel 4) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/81.0.4044.138 Mobile Safari/537.36',
'viewport': {
'width': 353,
'height': 745
},
'deviceScaleFactor': 3,
'isMobile': true,
'hasTouch': true,
'defaultBrowserType': 'chromium'
},
'Pixel 4 landscape': {
'userAgent': 'Mozilla/5.0 (Linux; Android 10; Pixel 4) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/81.0.4044.138 Mobile Safari/537.36',
'viewport': {
'width': 745,
'height': 353
},
'deviceScaleFactor': 3,
'isMobile': true,
'hasTouch': true,
'defaultBrowserType': 'chromium'
},
'Pixel 4a (5G)': {
'userAgent': 'Mozilla/5.0 (Linux; Android 11; Pixel 4a (5G)) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/89.0.4389.105 Mobile Safari/537.36',
'screen': {

10
types/types.d.ts vendored
View file

@ -11088,6 +11088,12 @@ type Devices = {
"Galaxy S III landscape": DeviceDescriptor;
"Galaxy S5": DeviceDescriptor;
"Galaxy S5 landscape": DeviceDescriptor;
"Galaxy S8": DeviceDescriptor;
"Galaxy S8 landscape": DeviceDescriptor;
"Galaxy S9+": DeviceDescriptor;
"Galaxy S9+ landscape": DeviceDescriptor;
"Galaxy Tab S4": DeviceDescriptor;
"Galaxy Tab S4 landscape": DeviceDescriptor;
"iPad (gen 6)": DeviceDescriptor;
"iPad (gen 6) landscape": DeviceDescriptor;
"iPad (gen 7)": DeviceDescriptor;
@ -11158,6 +11164,10 @@ type Devices = {
"Pixel 2 landscape": DeviceDescriptor;
"Pixel 2 XL": DeviceDescriptor;
"Pixel 2 XL landscape": DeviceDescriptor;
"Pixel 3": DeviceDescriptor;
"Pixel 3 landscape": DeviceDescriptor;
"Pixel 4": DeviceDescriptor;
"Pixel 4 landscape": DeviceDescriptor;
"Pixel 4a (5G)": DeviceDescriptor;
"Pixel 4a (5G) landscape": DeviceDescriptor;
"Pixel 5": DeviceDescriptor;