Filip/playwright
1
0
Fork 0
Code Issues Pull requests Actions Packages Projects Releases Wiki Activity

chore(bidi): Do not wait for browsingContext.close if runBeforeUnload is true

Browse source
This commit is contained in:
Julian Descottes 2025-01-10 19:15:10 +01:00
parent ac116248f9
commit 8778e02217
2 changed files with 8 additions and 3 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

9
packages/playwright-core/src/server/bidi/bidiPage.ts
View file

@ -390,10 +390,17 @@ export class BidiPage implements PageDelegate {
} }
async closePage(runBeforeUnload: boolean): Promise<void> { async closePage(runBeforeUnload: boolean): Promise<void> {
await this._session.send('browsingContext.close', { const onClose = this._session.send('browsingContext.close', {
context: this._session.sessionId, context: this._session.sessionId,
promptUnload: runBeforeUnload, promptUnload: runBeforeUnload,
}); });
// Only wait for the browsingContext to close if runBeforeUnload is false.
// Otherwise a before unload prompt might be displayed and should be handled
// by the caller.
// See NOTE on https://playwright.dev/docs/api/class-page#page-close
if (!runBeforeUnload)
await onClose;
} }
async setBackgroundColor(color?: { r: number; g: number; b: number; a: number; }): Promise<void> { async setBackgroundColor(color?: { r: number; g: number; b: number; a: number; }): Promise<void> {

2
tests/bidi/expectations/bidi-chromium-library.txt
View file

@ -1,5 +1,3 @@
library/beforeunload.spec.ts › should access page after beforeunload [timeout]
library/beforeunload.spec.ts › should run beforeunload if asked for @smoke [timeout]
library/browsercontext-events.spec.ts › console event should work in immediately closed popup [timeout] library/browsercontext-events.spec.ts › console event should work in immediately closed popup [timeout]
library/browsercontext-events.spec.ts › console event should work in popup 2 [timeout] library/browsercontext-events.spec.ts › console event should work in popup 2 [timeout]
library/browsercontext-events.spec.ts › dialog event should work in immediately closed popup [timeout] library/browsercontext-events.spec.ts › dialog event should work in immediately closed popup [timeout]