Filip/playwright
1
0
Fork 0
Code Issues Pull requests Actions Packages Projects Releases Wiki Activity

test: unflake launcher test (#2224)

Browse source 
We throw an exception and then gracefully close the browser.
If something went wrong, we should timeout before the test times out,
kill the process and report the original exception.
This commit is contained in:
Dmitry Gozman 2020-05-13 17:19:07 -07:00 committed by GitHub
parent 03cae92ff2
commit 884860b803
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
1 changed files with 1 additions and 1 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

2
test/launcher.spec.js
View file

@ -58,7 +58,7 @@ describe('Playwright', function() {
}); });
it('should handle exception', async({browserType, defaultBrowserOptions}) => { it('should handle exception', async({browserType, defaultBrowserOptions}) => {
const e = new Error('Dummy'); const e = new Error('Dummy');
const options = { ...defaultBrowserOptions, __testHookBeforeCreateBrowser: () => { throw e; } }; const options = { ...defaultBrowserOptions, __testHookBeforeCreateBrowser: () => { throw e; }, timeout: 9000 };
const error = await browserType.launch(options).catch(e => e); const error = await browserType.launch(options).catch(e => e);
expect(error).toBe(e); expect(error).toBe(e);
}); });