Filip/playwright
1
0
Fork 0
Code Issues Pull requests Actions Packages Projects Releases Wiki Activity

devops: add macOS 13 coverage (#23065)

Browse source 
Coverage https://github.com/microsoft/playwright/issues/22226
This commit is contained in:
Max Schmitt 2023-05-17 01:13:09 +02:00 committed by GitHub
parent 89f1940509
commit 89aa02228f
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
2 changed files with 8 additions and 4 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

2
.github/workflows/tests_secondary.yml vendored
View file

@ -57,7 +57,7 @@ jobs:
strategy: strategy:
fail-fast: false fail-fast: false
matrix: matrix:
os: [macos-11, macos-12] os: [macos-12, macos-13]
browser: [chromium, firefox, webkit] browser: [chromium, firefox, webkit]
runs-on: ${{ matrix.os }} runs-on: ${{ matrix.os }}
steps: steps:

10
tests/library/signals.spec.ts
View file

@ -18,6 +18,7 @@
import { playwrightTest as test, expect } from '../config/browserTest'; import { playwrightTest as test, expect } from '../config/browserTest';
import { execSync } from 'child_process'; import { execSync } from 'child_process';
import fs from 'fs'; import fs from 'fs';
import os from 'os';
test.slow(); test.slow();
@ -56,7 +57,8 @@ test('should remove temp dir on process.exit', async ({ startRemoteServer, serve
test.describe('signals', () => { test.describe('signals', () => {
test.skip(({ platform }) => platform === 'win32'); test.skip(({ platform }) => platform === 'win32');
test('should report browser close signal 2', async ({ startRemoteServer, server }) => { test('should report browser close signal 2', async ({ startRemoteServer, server, isMac, browserName }) => {
test.fixme(isMac && browserName === 'webkit' && parseInt(os.release(), 10) >= 22, 'https://github.com/microsoft/playwright/issues/22226');
const remoteServer = await startRemoteServer('launchServer', { url: server.EMPTY_PAGE }); const remoteServer = await startRemoteServer('launchServer', { url: server.EMPTY_PAGE });
const pid = await remoteServer.out('pid'); const pid = await remoteServer.out('pid');
process.kill(-pid, 'SIGKILL'); process.kill(-pid, 'SIGKILL');
@ -90,7 +92,8 @@ test.describe('signals', () => {
expect(await remoteServer.childExitCode()).toBe(0); expect(await remoteServer.childExitCode()).toBe(0);
}); });
test('should kill the browser on double SIGINT and remove temp dir', async ({ startRemoteServer, server }) => { test('should kill the browser on double SIGINT and remove temp dir', async ({ startRemoteServer, server, isMac, browserName }) => {
test.fixme(isMac && browserName === 'webkit' && parseInt(os.release(), 10) >= 22, 'https://github.com/microsoft/playwright/issues/22226');
const remoteServer = await startRemoteServer('launchServer', { stallOnClose: true, url: server.EMPTY_PAGE }); const remoteServer = await startRemoteServer('launchServer', { stallOnClose: true, url: server.EMPTY_PAGE });
const tempDir = await remoteServer.out('tempDir'); const tempDir = await remoteServer.out('tempDir');
const before = fs.existsSync(tempDir); const before = fs.existsSync(tempDir);
@ -105,7 +108,8 @@ test.describe('signals', () => {
expect(after).toBe(false); expect(after).toBe(false);
}); });
test('should kill the browser on SIGINT + SIGTERM', async ({ startRemoteServer, server }) => { test('should kill the browser on SIGINT + SIGTERM', async ({ startRemoteServer, server, isMac, browserName }) => {
test.fixme(isMac && browserName === 'webkit' && parseInt(os.release(), 10) >= 22, 'https://github.com/microsoft/playwright/issues/22226');
const remoteServer = await startRemoteServer('launchServer', { stallOnClose: true, url: server.EMPTY_PAGE }); const remoteServer = await startRemoteServer('launchServer', { stallOnClose: true, url: server.EMPTY_PAGE });
process.kill(remoteServer.child().pid, 'SIGINT'); process.kill(remoteServer.child().pid, 'SIGINT');
await remoteServer.out('stalled'); await remoteServer.out('stalled');