Filip/playwright
1
0
Fork 0
Code Issues Pull requests Actions Packages Projects Releases Wiki Activity

fix(tracing): do not reset frame counter on every chunk (#13689)

Browse source
This commit is contained in:
Pavel Feldman 2022-04-21 14:40:30 -08:00 committed by GitHub
parent 5753f7a7fa
commit 89b8fdd4e5
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
1 changed files with 1 additions and 2 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

3
packages/playwright-core/src/server/trace/recorder/tracing.ts
View file

@ -391,10 +391,9 @@ export class Tracing extends SdkObject implements InstrumentationListener, Snaps
private _startScreencastInPage(page: Page) { private _startScreencastInPage(page: Page) {
page.setScreencastOptions(kScreencastOptions); page.setScreencastOptions(kScreencastOptions);
const prefix = page.guid; const prefix = page.guid;
let frameSeq = 0;
this._screencastListeners.push( this._screencastListeners.push(
eventsHelper.addEventListener(page, Page.Events.ScreencastFrame, params => { eventsHelper.addEventListener(page, Page.Events.ScreencastFrame, params => {
const suffix = String(++frameSeq).padStart(10, '0'); const suffix = params.timestamp || Date.now();
const sha1 = `${prefix}-${suffix}.jpeg`; const sha1 = `${prefix}-${suffix}.jpeg`;
const event: trace.ScreencastFrameTraceEvent = { const event: trace.ScreencastFrameTraceEvent = {
type: 'screencast-frame', type: 'screencast-frame',