From 8bb6d73b448653ce5bc4f87e7fb478edf0c9d14d Mon Sep 17 00:00:00 2001 From: Dmitry Gozman Date: Mon, 10 Aug 2020 20:49:53 -0700 Subject: [PATCH] feat(rpc): keep non-rpc linux bots for now (#3381) --- .github/workflows/tests.yml | 2 +- index.js | 7 ++++++- test/harness/testOptions.js | 2 +- 3 files changed, 8 insertions(+), 3 deletions(-) diff --git a/.github/workflows/tests.yml b/.github/workflows/tests.yml index 3198fd058b..095bfe1a80 100644 --- a/.github/workflows/tests.yml +++ b/.github/workflows/tests.yml @@ -198,7 +198,7 @@ jobs: fail-fast: false matrix: browser: [chromium, firefox, webkit] - transport: [wire, object] + transport: [wire, none] runs-on: ubuntu-18.04 steps: - uses: actions/checkout@v2 diff --git a/index.js b/index.js index 31266294c2..f7247b83ed 100644 --- a/index.js +++ b/index.js @@ -21,4 +21,9 @@ const path = require('path'); const playwright = new Playwright(__dirname, require(path.join(__dirname, 'browsers.json'))['browsers']); playwright.electron = new Electron(); -module.exports = setupInProcess(playwright); +if (process.env.PWCHANNEL === 'none') { + playwright._toImpl = x => x; + module.exports = playwright; +} else { + module.exports = setupInProcess(playwright); +} diff --git a/test/harness/testOptions.js b/test/harness/testOptions.js index 15cb3028c2..946d1390c5 100644 --- a/test/harness/testOptions.js +++ b/test/harness/testOptions.js @@ -29,7 +29,7 @@ testOptions.CHROMIUM = browserName === 'chromium'; testOptions.FFOX = browserName === 'firefox'; testOptions.WEBKIT = browserName === 'webkit'; testOptions.USES_HOOKS = process.env.PWCHANNEL === 'wire'; -testOptions.CHANNEL = true; +testOptions.CHANNEL = process.env.PWCHANNEL !== 'none'; testOptions.HEADLESS = !!valueFromEnv('HEADLESS', true); testOptions.ASSETS_DIR = path.join(__dirname, '..', 'assets'); testOptions.GOLDEN_DIR = path.join(__dirname, '..', 'golden-' + browserName);