Filip/playwright
1
0
Fork 0
Code Issues Pull requests Actions Packages Projects Releases Wiki Activity

docs: fix auth example (#4528)

Browse source 
We should wait for selector instead of asserting it.
This commit is contained in:
Dmitry Gozman 2020-11-25 11:32:46 -08:00 committed by GitHub
parent 62f7437a2c
commit 8cc8b777d0
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
1 changed files with 3 additions and 3 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

6
docs/examples/authentication.js
View file

@ -5,7 +5,7 @@ const assert = require('assert');
* In this script, we will login on GitHub.com through Chromium, * In this script, we will login on GitHub.com through Chromium,
* and reuse the login cookies state inside WebKit. This recipe can be * and reuse the login cookies state inside WebKit. This recipe can be
* used to speed up tests by logging in once and reusing login state. * used to speed up tests by logging in once and reusing login state.
* *
* Steps summary * Steps summary
* 1. Login on GitHub.com in Chromium * 1. Login on GitHub.com in Chromium
* 2. Export cookies from Chromium browser context * 2. Export cookies from Chromium browser context
@ -34,7 +34,7 @@ const account = { login: '', password: '' };
// Get cookies from Chromium browser context // Get cookies from Chromium browser context
const cookies = await crContext.cookies(); const cookies = await crContext.cookies();
await crBrowser.close(); await crBrowser.close();
// Create WebKit browser context and load cookies // Create WebKit browser context and load cookies
const wkBrowser = await webkit.launch(); const wkBrowser = await webkit.launch();
const wkContext = await wkBrowser.newContext(); const wkContext = await wkBrowser.newContext();
@ -50,5 +50,5 @@ const account = { login: '', password: '' };
const verifyIsLoggedIn = async (page) => { const verifyIsLoggedIn = async (page) => {
await page.click('summary[aria-label="View profile and more"]') await page.click('summary[aria-label="View profile and more"]')
assert(await page.$(`text="Your profile"`)); assert(await page.waitForSelector(`text="Your profile"`));
} }