Filip/playwright
1
0
Fork 0
Code Issues Pull requests Actions Packages Projects Releases Wiki Activity

fix: throw if quality=0 is passed for png screenshot (#4812)

Browse source
This commit is contained in:
Yury Semikhatsky 2020-12-23 09:53:14 -08:00 committed by GitHub
parent e7ee426202
commit 8d4c46ac19
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
2 changed files with 11 additions and 1 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

2
src/server/screenshotter.ts
View file

@ -205,7 +205,7 @@ function validateScreenshotOptions(options: types.ScreenshotOptions): 'png' | 'j
if (!format) if (!format)
format = 'png'; format = 'png';
if (options.quality) { if (options.quality !== undefined) {
assert(format === 'jpeg', 'options.quality is unsupported for the ' + format + ' screenshots'); assert(format === 'jpeg', 'options.quality is unsupported for the ' + format + ' screenshots');
assert(typeof options.quality === 'number', 'Expected options.quality to be a number but found ' + (typeof options.quality)); assert(typeof options.quality === 'number', 'Expected options.quality to be a number but found ' + (typeof options.quality));
assert(Number.isInteger(options.quality), 'Expected options.quality to be an integer'); assert(Number.isInteger(options.quality), 'Expected options.quality to be an integer');

10
test/page-screenshot.spec.ts
View file

@ -292,6 +292,16 @@ describe('page screenshot', (suite, { browserName, headful }) => {
expect(error.message).toContain('path: unsupported mime type "text/plain"'); expect(error.message).toContain('path: unsupported mime type "text/plain"');
}); });
it('quality option should throw for png', async ({page}) => {
const error = await page.screenshot({ quality: 10 }).catch(e => e);
expect(error.message).toContain('options.quality is unsupported for the png');
});
it('zero quality option should throw for png', async ({page}) => {
const error = await page.screenshot({ quality: 0, type: 'png' }).catch(e => e);
expect(error.message).toContain('options.quality is unsupported for the png');
});
it('should prefer type over extension', async ({page, testInfo}) => { it('should prefer type over extension', async ({page, testInfo}) => {
const outputPath = testInfo.outputPath('file.png'); const outputPath = testInfo.outputPath('file.png');
const buffer = await page.screenshot({ path: outputPath, type: 'jpeg' }); const buffer = await page.screenshot({ path: outputPath, type: 'jpeg' });