Filip/playwright
1
0
Fork 0
Code Issues Pull requests Actions Packages Projects Releases Wiki Activity

fix: add snapshots for page and elementHandle screenshots (#12411)

Browse source 
Fixes #12280
This commit is contained in:
Andrey Lushnikov 2022-02-28 12:52:54 -07:00 committed by GitHub
parent 47045ba48d
commit 8d94ed134c
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
2 changed files with 6 additions and 0 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

2
packages/playwright-core/src/protocol/channels.ts
View file

@ -4034,6 +4034,7 @@ export const commandsWithTracingSnapshots = new Set([
'Page.goBack', 'Page.goBack',
'Page.goForward', 'Page.goForward',
'Page.reload', 'Page.reload',
'Page.screenshot',
'Page.setViewportSize', 'Page.setViewportSize',
'Page.keyboardDown', 'Page.keyboardDown',
'Page.keyboardUp', 'Page.keyboardUp',
@ -4105,6 +4106,7 @@ export const commandsWithTracingSnapshots = new Set([
'ElementHandle.isHidden', 'ElementHandle.isHidden',
'ElementHandle.isVisible', 'ElementHandle.isVisible',
'ElementHandle.press', 'ElementHandle.press',
'ElementHandle.screenshot',
'ElementHandle.scrollIntoViewIfNeeded', 'ElementHandle.scrollIntoViewIfNeeded',
'ElementHandle.selectOption', 'ElementHandle.selectOption',
'ElementHandle.selectText', 'ElementHandle.selectText',

4
packages/playwright-core/src/protocol/protocol.yml
View file

@ -1012,6 +1012,8 @@ Page:
selector: string selector: string
returns: returns:
binary: binary binary: binary
tracing:
snapshot: true
setExtraHTTPHeaders: setExtraHTTPHeaders:
parameters: parameters:
@ -2171,6 +2173,8 @@ ElementHandle:
selector: string selector: string
returns: returns:
binary: binary binary: binary
tracing:
snapshot: true
scrollIntoViewIfNeeded: scrollIntoViewIfNeeded:
parameters: parameters: