fixes

.github/workflows/tests_bidi.yml

@@ -1,14 +1,14 @@
 name: tests BiDi
 
 on:
-  push:
+  workflow_dispatch:
-    branches:
-      - main
-      - release-*
   pull_request:
     branches:
       - main
-      - release-*
+    paths:
+      - .github/workflows/tests_bidi.yml
+  schedule:
+    - cron: '0 0 * * *'
 
 env:
   FORCE_COLOR: 1
@@ -18,7 +18,7 @@ jobs:
   test_bidi:
     name: BiDi
     environment: ${{ github.event_name == 'push' && 'allow-uploading-flakiness-results' || null }}
-    runs-on: ubuntu-latest
+    runs-on: ubuntu-24.04
     permissions:
       id-token: write   # This is required for OIDC login (azure/login) to succeed
       contents: read    # This is required for actions/checkout to succeed
@@ -26,23 +26,21 @@ jobs:
       fail-fast: false
       matrix:
         # TODO: add Firefox
-        project: [chrome]
+        channel: [bidi-chrome-beta]
     steps:
     - uses: actions/checkout@v4
-    - name: Configure executable path
+    - name: Install browser
       run: |
-        if [ ${{ matrix.project }} == "chrome" ]; then
+        if [[ ${{ matrix.channel }} == bidi-chrome-beta ]]; then
-          echo "BIDIPATH=/opt/google/chrome/chrome" >> $GITHUB_ENV
+          curl -O https://dl.google.com/linux/direct/google-chrome-beta_current_amd64.deb
-        else
+          sudo dpkg -i google-chrome-beta_current_amd64.deb
-          sudo apt-get install -y firefox
-          echo "BIDIPATH=/usr/bin/firefox" >> $GITHUB_ENV
         fi
     - uses: ./.github/actions/run-test
       with:
         node-version: 20
         browsers-to-install: chromium
-        command: npm run biditest -- --project=*${{ matrix.project }}*
+        command: npm run biditest -- --project=${{ matrix.channel }}*
-        bot-name: bidi-${{ matrix.project }}
+        bot-name: bidi-${{ matrix.channel }}
         flakiness-client-id: ${{ secrets.AZURE_FLAKINESS_DASHBOARD_CLIENT_ID }}
         flakiness-tenant-id: ${{ secrets.AZURE_FLAKINESS_DASHBOARD_TENANT_ID }}
         flakiness-subscription-id: ${{ secrets.AZURE_FLAKINESS_DASHBOARD_SUBSCRIPTION_ID }}

packages/playwright-core/src/server/registry/index.ts

@@ -354,7 +354,7 @@ function readDescriptors(browsersJSON: BrowsersJSON) {
 
 export type BrowserName = 'chromium' | 'firefox' | 'webkit' | 'bidi';
 type InternalTool = 'ffmpeg' | 'firefox-beta' | 'chromium-tip-of-tree' | 'android';
-type BidiChannel = 'bidi-firefox-stable' | 'bidi-chrome-canary';
+type BidiChannel = 'bidi-firefox-stable' | 'bidi-chrome-canary' | 'bidi-chrome-beta';
 type ChromiumChannel = 'chrome' | 'chrome-beta' | 'chrome-dev' | 'chrome-canary' | 'msedge' | 'msedge-beta' | 'msedge-dev' | 'msedge-canary';
 const allDownloadable = ['chromium', 'firefox', 'webkit', 'ffmpeg', 'firefox-beta', 'chromium-tip-of-tree'];
 
@@ -530,6 +530,11 @@ export class Registry {
       'darwin': '/Applications/Firefox.app/Contents/MacOS/firefox',
       'win32': '\\Mozilla Firefox\\firefox.exe',
     }));
+    this._executables.push(this._createBidiChannel('bidi-chrome-beta', {
+      'linux': '/opt/google/chrome-beta/chrome',
+      'darwin': '/Applications/Google Chrome Beta.app/Contents/MacOS/Google Chrome Beta',
+      'win32': `\\Google\\Chrome Beta\\Application\\chrome.exe`,
+    }));
     this._executables.push(this._createBidiChannel('bidi-chrome-canary', {
       'linux': '',
       'darwin': '/Applications/Google Chrome Canary.app/Contents/MacOS/Google Chrome Canary',

tests/bidi/playwright.config.ts

@@ -47,9 +47,9 @@ const config: Config<PlaywrightWorkerOptions & PlaywrightTestOptions & TestModeW
   expect: {
     timeout: 10000,
   },
-  maxFailures: 200,
+  maxFailures: 0,
-  timeout: 30000,
+  timeout: 15 * 1000,
-  globalTimeout: 5400000,
+  globalTimeout: 30 * 60 * 1000,
   workers: process.env.CI ? 2 : undefined,
   fullyParallel: !process.env.CI,
   forbidOnly: !!process.env.CI,
@@ -63,7 +63,7 @@ if (executablePath && !process.env.TEST_WORKER_INDEX)
   console.error(`Using executable at ${executablePath}`);
 const testIgnore: RegExp[] = [];
 const browserToChannels = {
-  '_bidiChromium': ['bidi-chrome-canary'],
+  '_bidiChromium': ['bidi-chrome-beta'],
   '_bidiFirefox': ['bidi-firefox-stable'],
 };
 for (const [key, channels] of Object.entries(browserToChannels)) {
@@ -81,7 +81,6 @@ for (const [key, channels] of Object.entries(browserToChannels)) {
           channel,
           video: 'off',
           launchOptions: {
-            channel: 'bidi-chrome-canary',
             executablePath,
           },
           trace: trace ? 'on' : undefined,