Filip/playwright
1
0
Fork 0
Code Issues Pull requests Actions Packages Projects Releases Wiki Activity

test: unskip various proxy tests (#32595)

Browse source 
Unskipping of various tests and revert the rest of
https://github.com/microsoft/playwright/pull/6350 since the upstream bug
has been fixed.
This commit is contained in:
Max Schmitt 2024-09-12 20:31:22 +02:00 committed by GitHub
parent ef4be6afff
commit 8e82f53ceb
No known key found for this signature in database
GPG key ID: B5690EEEBB952194
3 changed files with 0 additions and 15 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

4
tests/library/browsercontext-proxy.spec.ts
View file

@ -25,10 +25,6 @@ it.beforeEach(({ server }) => {
}); });
it('should work when passing the proxy only on the context level', async ({ browserName, platform, browserType, server, proxyServer }) => { it('should work when passing the proxy only on the context level', async ({ browserName, platform, browserType, server, proxyServer }) => {
// Currently an upstream bug in the network stack of Chromium which leads that
// the wrong proxy gets used in the BrowserContext.
it.fixme(browserName === 'chromium' && platform === 'win32');
proxyServer.forwardTo(server.PORT); proxyServer.forwardTo(server.PORT);
let browser; let browser;
try { try {

9
tests/library/client-certificates.spec.ts
View file

@ -76,15 +76,6 @@ const test = base.extend<TestOptions>({
}, },
}); });
test.use({
launchOptions: async ({ launchOptions }, use) => {
await use({
...launchOptions,
proxy: { server: 'per-context' }
});
}
});
const kDummyFileName = __filename; const kDummyFileName = __filename;
const kValidationSubTests: [BrowserContextOptions, string][] = [ const kValidationSubTests: [BrowserContextOptions, string][] = [
[{ clientCertificates: [{ origin: 'test' }] }, 'None of cert, key, passphrase or pfx is specified'], [{ clientCertificates: [{ origin: 'test' }] }, 'None of cert, key, passphrase or pfx is specified'],

2
tests/library/proxy.spec.ts
View file

@ -145,7 +145,6 @@ it('should authenticate', async ({ browserType, server }) => {
}); });
it('should work with authenticate followed by redirect', async ({ browserName, browserType, server }) => { it('should work with authenticate followed by redirect', async ({ browserName, browserType, server }) => {
it.fixme(browserName === 'firefox', 'https://github.com/microsoft/playwright/issues/10095');
function hasAuth(req, res) { function hasAuth(req, res) {
const auth = req.headers['proxy-authorization']; const auth = req.headers['proxy-authorization'];
if (!auth) { if (!auth) {
@ -324,7 +323,6 @@ async function setupSocksForwardingServer(port: number, forwardPort: number) {
} }
it('should use SOCKS proxy for websocket requests', async ({ browserName, platform, browserType, server }, testInfo) => { it('should use SOCKS proxy for websocket requests', async ({ browserName, platform, browserType, server }, testInfo) => {
it.fixme(browserName === 'webkit' && platform !== 'linux');
const { proxyServerAddr, closeProxyServer } = await setupSocksForwardingServer(testInfo.workerIndex + 2048 + 2, server.PORT); const { proxyServerAddr, closeProxyServer } = await setupSocksForwardingServer(testInfo.workerIndex + 2048 + 2, server.PORT);
const browser = await browserType.launch({ const browser = await browserType.launch({
proxy: { proxy: {