Filip/playwright
1
0
Fork 0
Code Issues Pull requests Actions Packages Projects Releases Wiki Activity

feat(firefox): roll Firefox to r1200 (#4316)

Browse source 
This roll includes:
- fix for the firefox flakiness related to popups
- fix for browser context closing with beforeunload events

References #4021
This commit is contained in:
Andrey Lushnikov 2020-11-02 21:00:37 -08:00 committed by GitHub
parent 1c39689dd6
commit 8fed0b3319
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
2 changed files with 1 additions and 3 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

2
browsers.json
View file

@ -8,7 +8,7 @@
}, },
{ {
"name": "firefox", "name": "firefox",
"revision": "1198", "revision": "1200",
"download": true "download": true
}, },
{ {

2
test/beforeunload.spec.ts
View file

@ -29,7 +29,6 @@ it('should close browser with beforeunload page', (test, {browserName}) => {
}); });
it('should close browsercontext with beforeunload page', (test, {browserName}) => { it('should close browsercontext with beforeunload page', (test, {browserName}) => {
test.fixme(browserName === 'firefox');
}, async ({server, contextFactory }) => { }, async ({server, contextFactory }) => {
const browserContext = await contextFactory(); const browserContext = await contextFactory();
const page = await browserContext.newPage(); const page = await browserContext.newPage();
@ -75,7 +74,6 @@ it('should run beforeunload if asked for', async ({context, server, isChromium,
it('should access page after beforeunload', (test, { browserName }) => { it('should access page after beforeunload', (test, { browserName }) => {
test.fixme(browserName === 'chromium'); test.fixme(browserName === 'chromium');
test.fixme(browserName === 'firefox');
}, async ({contextFactory, server}) => { }, async ({contextFactory, server}) => {
const context = await contextFactory(); const context = await contextFactory();
const page = await context.newPage(); const page = await context.newPage();