Filip/playwright
1
0
Fork 0
Code Issues Pull requests Actions Packages Projects Releases Wiki Activity

fix: eslint failures fix

Browse source
This commit is contained in:
JacksonLei123 2024-11-23 19:51:39 -05:00
parent 3560c50590
commit 90b675d8ca
1 changed files with 3 additions and 5 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

8
packages/playwright-core/src/server/registry/browserFetcher.ts
View file

@ -40,9 +40,8 @@ export async function downloadBrowserWithProgressBar(title: string, browserDirec
for (let attempt = 1; attempt <= retryCount; ++attempt) { for (let attempt = 1; attempt <= retryCount; ++attempt) {
debugLogger.log('install', `downloading ${title} - attempt #${attempt}`); debugLogger.log('install', `downloading ${title} - attempt #${attempt}`);
const url = downloadURLs[(attempt - 1) % downloadURLs.length]; const url = downloadURLs[(attempt - 1) % downloadURLs.length];
if (!quiet) { if (!quiet)
logPolitely(`Downloading ${title}` + colors.dim(` from ${url}`)); logPolitely(`Downloading ${title}` + colors.dim(` from ${url}`));
}
const { error } = await downloadBrowserWithProgressBarOutOfProcess(title, browserDirectory, url, zipPath, executablePath, downloadConnectionTimeout, quiet); const { error } = await downloadBrowserWithProgressBarOutOfProcess(title, browserDirectory, url, zipPath, executablePath, downloadConnectionTimeout, quiet);
if (!error) { if (!error) {
debugLogger.log('install', `SUCCESS installing ${title}`); debugLogger.log('install', `SUCCESS installing ${title}`);
@ -65,9 +64,8 @@ export async function downloadBrowserWithProgressBar(title: string, browserDirec
if (await existsAsync(zipPath)) if (await existsAsync(zipPath))
await fs.promises.unlink(zipPath); await fs.promises.unlink(zipPath);
} }
if (!quiet) { if (!quiet)
logPolitely(`${title} downloaded to ${browserDirectory}`); logPolitely(`${title} downloaded to ${browserDirectory}`);
}
return true; return true;
} }
@ -87,7 +85,7 @@ function downloadBrowserWithProgressBarOutOfProcess(title: string, browserDirect
if (message?.method === 'progress') if (message?.method === 'progress')
progress(message.params.done, message.params.total); progress(message.params.done, message.params.total);
}); });
} }
cp.on('exit', code => { cp.on('exit', code => {
if (code !== 0) { if (code !== 0) {
promise.resolve({ error: new Error(`Download failure, code=${code}`) }); promise.resolve({ error: new Error(`Download failure, code=${code}`) });