From 90e76f9adb542f94dc623be6d93f1f79822e0a60 Mon Sep 17 00:00:00 2001 From: Max Schmitt Date: Thu, 10 Mar 2022 19:42:52 +0100 Subject: [PATCH] test: rename #smoke to @smoke as test tags (#12652) --- tests/beforeunload.spec.ts | 2 +- tests/browser.spec.ts | 2 +- tests/browsercontext-add-cookies.spec.ts | 2 +- tests/browsercontext-add-init-script.spec.ts | 2 +- tests/browsercontext-base-url.spec.ts | 2 +- tests/browsercontext-basic.spec.ts | 4 ++-- tests/browsercontext-cookies.spec.ts | 2 +- tests/browsercontext-credentials.spec.ts | 2 +- tests/browsercontext-csp.spec.ts | 2 +- tests/browsercontext-device.spec.ts | 2 +- tests/browsercontext-dsf.spec.ts | 2 +- tests/browsercontext-fetch.spec.ts | 2 +- tests/browsercontext-locale.spec.ts | 2 +- tests/browsercontext-timezone-id.spec.ts | 2 +- tests/capabilities.spec.ts | 18 +++++++++--------- tests/defaultbrowsercontext-1.spec.ts | 2 +- tests/download.spec.ts | 2 +- tests/emulation-focus.spec.ts | 2 +- tests/geolocation.spec.ts | 2 +- tests/global-fetch.spec.ts | 2 +- tests/har.spec.ts | 2 +- tests/headful.spec.ts | 2 +- tests/ignorehttpserrors.spec.ts | 2 +- tests/logger.spec.ts | 2 +- tests/page/elementhandle-click.spec.ts | 2 +- .../elementhandle-scroll-into-view.spec.ts | 2 +- tests/page/frame-evaluate.spec.ts | 2 +- tests/page/frame-frame-element.spec.ts | 2 +- tests/page/frame-goto.spec.ts | 2 +- tests/page/frame-hierarchy.spec.ts | 2 +- tests/page/interception.spec.ts | 2 +- tests/page/jshandle-as-element.spec.ts | 2 +- tests/page/jshandle-evaluate.spec.ts | 2 +- tests/page/jshandle-json-value.spec.ts | 2 +- tests/page/jshandle-properties.spec.ts | 2 +- tests/page/jshandle-to-string.spec.ts | 2 +- tests/page/locator-click.spec.ts | 2 +- tests/page/locator-element-handle.spec.ts | 2 +- tests/page/locator-evaluate.spec.ts | 2 +- tests/page/locator-frame.spec.ts | 2 +- tests/page/locator-misc-1.spec.ts | 2 +- tests/page/locator-misc-2.spec.ts | 2 +- tests/page/locator-query.spec.ts | 2 +- tests/page/network-post-data.spec.ts | 2 +- tests/page/page-accessibility.spec.ts | 2 +- tests/page/page-add-init-script.spec.ts | 2 +- tests/page/page-add-style-tag.spec.ts | 2 +- tests/page/page-check.spec.ts | 2 +- tests/page/page-click.spec.ts | 2 +- tests/page/page-dialog.spec.ts | 2 +- tests/page/page-dispatchevent.spec.ts | 2 +- tests/page/page-drag.spec.ts | 2 +- tests/page/page-emulate-media.spec.ts | 4 ++-- tests/page/page-evaluate.spec.ts | 2 +- tests/page/page-event-console.spec.ts | 2 +- tests/page/page-event-network.spec.ts | 8 ++++---- tests/page/page-event-popup.spec.ts | 2 +- tests/page/page-expose-function.spec.ts | 2 +- tests/page/page-fill.spec.ts | 2 +- tests/page/page-focus.spec.ts | 2 +- tests/page/page-goto.spec.ts | 2 +- tests/page/page-history.spec.ts | 2 +- tests/page/page-keyboard.spec.ts | 2 +- tests/page/page-mouse.spec.ts | 2 +- tests/page/page-network-request.spec.ts | 2 +- tests/page/page-network-response.spec.ts | 2 +- tests/page/page-route.spec.ts | 2 +- tests/page/page-screenshot.spec.ts | 2 +- tests/page/page-select-option.spec.ts | 2 +- tests/page/page-set-content.spec.ts | 2 +- tests/page/page-set-extra-http-headers.spec.ts | 2 +- tests/page/page-set-input-files.spec.ts | 2 +- tests/page/queryselector.spec.ts | 2 +- tests/page/selectors-css.spec.ts | 2 +- tests/page/selectors-frame.spec.ts | 2 +- tests/page/selectors-react.spec.ts | 2 +- tests/page/selectors-text.spec.ts | 2 +- tests/page/selectors-vue.spec.ts | 2 +- tests/page/wheel.spec.ts | 2 +- tests/page/workers.spec.ts | 2 +- tests/popup.spec.ts | 2 +- tests/port-forwarding-server.spec.ts | 2 +- tests/proxy.spec.ts | 2 +- tests/resource-timing.spec.ts | 2 +- tests/tap.spec.ts | 2 +- tests/video.spec.ts | 2 +- tests/web-socket.spec.ts | 2 +- 87 files changed, 100 insertions(+), 100 deletions(-) diff --git a/tests/beforeunload.spec.ts b/tests/beforeunload.spec.ts index 27e03aaffb..3779de6de1 100644 --- a/tests/beforeunload.spec.ts +++ b/tests/beforeunload.spec.ts @@ -52,7 +52,7 @@ it('should close page with beforeunload listener', async ({ context, server }) = await newPage.close(); }); -it('should run beforeunload if asked for #smoke', async ({ context, server, browserName }) => { +it('should run beforeunload if asked for @smoke', async ({ context, server, browserName }) => { const newPage = await context.newPage(); await newPage.goto(server.PREFIX + '/beforeunload.html'); // We have to interact with a page so that 'beforeunload' handlers diff --git a/tests/browser.spec.ts b/tests/browser.spec.ts index 4a1dc61431..e80325946e 100644 --- a/tests/browser.spec.ts +++ b/tests/browser.spec.ts @@ -16,7 +16,7 @@ import { browserTest as test, expect } from './config/browserTest'; -test('should create new page #smoke', async function({ browser }) { +test('should create new page @smoke', async function({ browser }) { const page1 = await browser.newPage(); expect(browser.contexts().length).toBe(1); diff --git a/tests/browsercontext-add-cookies.spec.ts b/tests/browsercontext-add-cookies.spec.ts index 15a79ef4be..4e82e1f31d 100644 --- a/tests/browsercontext-add-cookies.spec.ts +++ b/tests/browsercontext-add-cookies.spec.ts @@ -17,7 +17,7 @@ import { contextTest as it, playwrightTest, expect } from './config/browserTest'; -it('should work #smoke', async ({ context, page, server }) => { +it('should work @smoke', async ({ context, page, server }) => { await page.goto(server.EMPTY_PAGE); await context.addCookies([{ url: server.EMPTY_PAGE, diff --git a/tests/browsercontext-add-init-script.spec.ts b/tests/browsercontext-add-init-script.spec.ts index 69e3482b89..788ee1bd2e 100644 --- a/tests/browsercontext-add-init-script.spec.ts +++ b/tests/browsercontext-add-init-script.spec.ts @@ -17,7 +17,7 @@ import { contextTest as it, expect } from './config/browserTest'; -it('should work with browser context scripts #smoke', async ({ context, server }) => { +it('should work with browser context scripts @smoke', async ({ context, server }) => { await context.addInitScript(() => window['temp'] = 123); const page = await context.newPage(); await page.addInitScript(() => window['injected'] = window['temp']); diff --git a/tests/browsercontext-base-url.spec.ts b/tests/browsercontext-base-url.spec.ts index 24ac41c240..ea0ffc42f8 100644 --- a/tests/browsercontext-base-url.spec.ts +++ b/tests/browsercontext-base-url.spec.ts @@ -17,7 +17,7 @@ import { browserTest as it, expect } from './config/browserTest'; -it('should construct a new URL when a baseURL in browser.newContext is passed to page.goto #smoke', async function({ browser, server }) { +it('should construct a new URL when a baseURL in browser.newContext is passed to page.goto @smoke', async function({ browser, server }) { const context = await browser.newContext({ baseURL: server.PREFIX, }); diff --git a/tests/browsercontext-basic.spec.ts b/tests/browsercontext-basic.spec.ts index 30a4657f50..aaa309bdf5 100644 --- a/tests/browsercontext-basic.spec.ts +++ b/tests/browsercontext-basic.spec.ts @@ -18,7 +18,7 @@ import { browserTest as it, expect } from './config/browserTest'; import { attachFrame, verifyViewport } from './config/utils'; -it('should create new context #smoke', async function({ browser }) { +it('should create new context @smoke', async function({ browser }) { expect(browser.contexts().length).toBe(0); const context = await browser.newContext(); expect(browser.contexts().length).toBe(1); @@ -41,7 +41,7 @@ it('window.open should use parent tab context', async function({ browser, server await context.close(); }); -it('should isolate localStorage and cookies #smoke', async function({ browser, server }) { +it('should isolate localStorage and cookies @smoke', async function({ browser, server }) { // Create two incognito contexts. const context1 = await browser.newContext(); const context2 = await browser.newContext(); diff --git a/tests/browsercontext-cookies.spec.ts b/tests/browsercontext-cookies.spec.ts index 22a173557d..fed3670ed8 100644 --- a/tests/browsercontext-cookies.spec.ts +++ b/tests/browsercontext-cookies.spec.ts @@ -21,7 +21,7 @@ it('should return no cookies in pristine browser context', async ({ context, pag expect(await context.cookies()).toEqual([]); }); -it('should get a cookie #smoke', async ({ context, page, server, defaultSameSiteCookieValue }) => { +it('should get a cookie @smoke', async ({ context, page, server, defaultSameSiteCookieValue }) => { await page.goto(server.EMPTY_PAGE); const documentCookie = await page.evaluate(() => { document.cookie = 'username=John Doe'; diff --git a/tests/browsercontext-credentials.spec.ts b/tests/browsercontext-credentials.spec.ts index 80d70e2333..cb411b2ecf 100644 --- a/tests/browsercontext-credentials.spec.ts +++ b/tests/browsercontext-credentials.spec.ts @@ -42,7 +42,7 @@ it('should work with setHTTPCredentials', async ({ browser, server, browserName, await context.close(); }); -it('should work with correct credentials #smoke', async ({ browser, server }) => { +it('should work with correct credentials @smoke', async ({ browser, server }) => { server.setAuth('/empty.html', 'user', 'pass'); const context = await browser.newContext({ httpCredentials: { username: 'user', password: 'pass' } diff --git a/tests/browsercontext-csp.spec.ts b/tests/browsercontext-csp.spec.ts index a36eeb0414..32c4ba5e49 100644 --- a/tests/browsercontext-csp.spec.ts +++ b/tests/browsercontext-csp.spec.ts @@ -18,7 +18,7 @@ import { browserTest as it, expect } from './config/browserTest'; import { attachFrame } from './config/utils'; -it('should bypass CSP meta tag #smoke', async ({ browser, server }) => { +it('should bypass CSP meta tag @smoke', async ({ browser, server }) => { // Make sure CSP prohibits addScriptTag. { const context = await browser.newContext(); diff --git a/tests/browsercontext-device.spec.ts b/tests/browsercontext-device.spec.ts index c41e099a23..4c0366cc9c 100644 --- a/tests/browsercontext-device.spec.ts +++ b/tests/browsercontext-device.spec.ts @@ -20,7 +20,7 @@ import { browserTest as it, expect } from './config/browserTest'; it.describe('device', () => { it.skip(({ browserName }) => browserName === 'firefox'); - it('should work #smoke', async ({ playwright, browser, server }) => { + it('should work @smoke', async ({ playwright, browser, server }) => { const iPhone = playwright.devices['iPhone 6']; const context = await browser.newContext({ ...iPhone }); const page = await context.newPage(); diff --git a/tests/browsercontext-dsf.spec.ts b/tests/browsercontext-dsf.spec.ts index 52ce9f9735..b341a40107 100644 --- a/tests/browsercontext-dsf.spec.ts +++ b/tests/browsercontext-dsf.spec.ts @@ -16,7 +16,7 @@ import { browserTest as it, expect } from './config/browserTest'; -it('should fetch lodpi assets #smoke', async ({ contextFactory, server }) => { +it('should fetch lodpi assets @smoke', async ({ contextFactory, server }) => { const context = await contextFactory({ deviceScaleFactor: 1 }); diff --git a/tests/browsercontext-fetch.spec.ts b/tests/browsercontext-fetch.spec.ts index 344e44a388..4abf4be71a 100644 --- a/tests/browsercontext-fetch.spec.ts +++ b/tests/browsercontext-fetch.spec.ts @@ -42,7 +42,7 @@ it.afterAll(() => { http.globalAgent = prevAgent; }); -it('get should work #smoke', async ({ context, server }) => { +it('get should work @smoke', async ({ context, server }) => { const response = await context.request.get(server.PREFIX + '/simple.json'); expect(response.url()).toBe(server.PREFIX + '/simple.json'); expect(response.status()).toBe(200); diff --git a/tests/browsercontext-locale.spec.ts b/tests/browsercontext-locale.spec.ts index 506654b7c7..c957897ddc 100644 --- a/tests/browsercontext-locale.spec.ts +++ b/tests/browsercontext-locale.spec.ts @@ -17,7 +17,7 @@ import { browserTest as it, expect } from './config/browserTest'; -it('should affect accept-language header #smoke', async ({ browser, server }) => { +it('should affect accept-language header @smoke', async ({ browser, server }) => { const context = await browser.newContext({ locale: 'fr-CH' }); const page = await context.newPage(); const [request] = await Promise.all([ diff --git a/tests/browsercontext-timezone-id.spec.ts b/tests/browsercontext-timezone-id.spec.ts index 58cafed299..548058606d 100644 --- a/tests/browsercontext-timezone-id.spec.ts +++ b/tests/browsercontext-timezone-id.spec.ts @@ -17,7 +17,7 @@ import { browserTest as it, expect } from './config/browserTest'; -it('should work #smoke', async ({ browser, browserName }) => { +it('should work @smoke', async ({ browser, browserName }) => { const func = () => new Date(1479579154987).toString(); { const context = await browser.newContext({ locale: 'en-US', timezoneId: 'America/Jamaica' }); diff --git a/tests/capabilities.spec.ts b/tests/capabilities.spec.ts index b8d574fbae..3fdb180aa3 100644 --- a/tests/capabilities.spec.ts +++ b/tests/capabilities.spec.ts @@ -18,7 +18,7 @@ import os from 'os'; import url from 'url'; import { contextTest as it, expect } from './config/browserTest'; -it('SharedArrayBuffer should work #smoke', async function({ contextFactory, httpsServer, browserName }) { +it('SharedArrayBuffer should work @smoke', async function({ contextFactory, httpsServer, browserName }) { it.fail(browserName === 'webkit', 'no shared array buffer on webkit'); const context = await contextFactory({ ignoreHTTPSErrors: true }); const page = await context.newPage(); @@ -31,14 +31,14 @@ it('SharedArrayBuffer should work #smoke', async function({ contextFactory, http expect(await page.evaluate(() => typeof SharedArrayBuffer)).toBe('function'); }); -it('Web Assembly should work #smoke', async function({ page, server, browserName, platform }) { +it('Web Assembly should work @smoke', async function({ page, server, browserName, platform }) { it.fail(browserName === 'webkit' && platform === 'win32'); await page.goto(server.PREFIX + '/wasm/table2.html'); expect(await page.evaluate('loadTable()')).toBe('42, 83'); }); -it('WebSocket should work #smoke', async ({ page, server }) => { +it('WebSocket should work @smoke', async ({ page, server }) => { server.sendOnWebSocketConnection('incoming'); const value = await page.evaluate(port => { let cb; @@ -51,7 +51,7 @@ it('WebSocket should work #smoke', async ({ page, server }) => { expect(value).toBe('incoming'); }); -it('should respect CSP #smoke', async ({ page, server }) => { +it('should respect CSP @smoke', async ({ page, server }) => { server.setRoute('/empty.html', async (req, res) => { res.setHeader('Content-Security-Policy', `script-src 'unsafe-inline';`); res.end(` @@ -65,7 +65,7 @@ it('should respect CSP #smoke', async ({ page, server }) => { expect(await page.evaluate(() => window['testStatus'])).toBe('SUCCESS'); }); -it('should play video #smoke', async ({ page, asset, browserName, platform }) => { +it('should play video @smoke', async ({ page, asset, browserName, platform }) => { // TODO: the test passes on Windows locally but fails on GitHub Action bot, // apparently due to a Media Pack issue in the Windows Server. // Also the test is very flaky on Linux WebKit. @@ -83,7 +83,7 @@ it('should play video #smoke', async ({ page, asset, browserName, platform }) => await page.$eval('video', v => v.pause()); }); -it('should play audio #smoke', async ({ page, server, browserName, platform }) => { +it('should play audio @smoke', async ({ page, server, browserName, platform }) => { it.fixme(browserName === 'firefox' && platform === 'win32', 'https://github.com/microsoft/playwright/issues/10887'); it.fixme(browserName === 'firefox' && platform === 'linux', 'https://github.com/microsoft/playwright/issues/10887'); it.fixme(browserName === 'webkit' && platform === 'win32', 'https://github.com/microsoft/playwright/issues/10892'); @@ -95,7 +95,7 @@ it('should play audio #smoke', async ({ page, server, browserName, platform }) = expect(await page.$eval('audio', e => e.currentTime)).toBeGreaterThan(0.2); }); -it('should support webgl #smoke', async ({ page, browserName, headless }) => { +it('should support webgl @smoke', async ({ page, browserName, headless }) => { it.fixme(browserName === 'firefox' && headless); const hasWebGL = await page.evaluate(() => { @@ -105,7 +105,7 @@ it('should support webgl #smoke', async ({ page, browserName, headless }) => { expect(hasWebGL).toBe(true); }); -it('should support webgl 2 #smoke', async ({ page, browserName, headless }) => { +it('should support webgl 2 @smoke', async ({ page, browserName, headless }) => { it.skip(browserName === 'webkit', 'WebKit doesn\'t have webgl2 enabled yet upstream.'); it.fixme(browserName === 'firefox' && headless); it.fixme(browserName === 'chromium' && !headless, 'chromium doesn\'t like webgl2 when running under xvfb'); @@ -117,7 +117,7 @@ it('should support webgl 2 #smoke', async ({ page, browserName, headless }) => { expect(hasWebGL2).toBe(true); }); -it('should not crash on page with mp4 #smoke', async ({ page, server, platform, browserName }) => { +it('should not crash on page with mp4 @smoke', async ({ page, server, platform, browserName }) => { it.fixme(browserName === 'webkit' && platform === 'win32', 'https://github.com/microsoft/playwright/issues/11009, times out in setContent'); it.fixme(browserName === 'firefox', 'https://bugzilla.mozilla.org/show_bug.cgi?id=1697004'); await page.setContent(``); diff --git a/tests/defaultbrowsercontext-1.spec.ts b/tests/defaultbrowsercontext-1.spec.ts index 97190e105b..ea877f7679 100644 --- a/tests/defaultbrowsercontext-1.spec.ts +++ b/tests/defaultbrowsercontext-1.spec.ts @@ -19,7 +19,7 @@ import { playwrightTest as it, expect } from './config/browserTest'; import { verifyViewport } from './config/utils'; import fs from 'fs'; -it('context.cookies() should work #smoke', async ({ server, launchPersistent, defaultSameSiteCookieValue }) => { +it('context.cookies() should work @smoke', async ({ server, launchPersistent, defaultSameSiteCookieValue }) => { const { page } = await launchPersistent(); await page.goto(server.EMPTY_PAGE); const documentCookie = await page.evaluate(() => { diff --git a/tests/download.spec.ts b/tests/download.spec.ts index afdacfed68..2b9a493583 100644 --- a/tests/download.spec.ts +++ b/tests/download.spec.ts @@ -50,7 +50,7 @@ it.describe('download event', () => { }); }); - it('should report download when navigation turns into download #smoke', async ({ browser, server, browserName }) => { + it('should report download when navigation turns into download @smoke', async ({ browser, server, browserName }) => { const page = await browser.newPage(); const [ download, responseOrError ] = await Promise.all([ page.waitForEvent('download'), diff --git a/tests/emulation-focus.spec.ts b/tests/emulation-focus.spec.ts index 114ba742a4..5df92dc58d 100644 --- a/tests/emulation-focus.spec.ts +++ b/tests/emulation-focus.spec.ts @@ -22,7 +22,7 @@ it('should think that it is focused by default', async ({ page }) => { expect(await page.evaluate('document.hasFocus()')).toBe(true); }); -it('should think that all pages are focused #smoke', async ({ page }) => { +it('should think that all pages are focused @smoke', async ({ page }) => { const page2 = await page.context().newPage(); expect(await page.evaluate('document.hasFocus()')).toBe(true); expect(await page2.evaluate('document.hasFocus()')).toBe(true); diff --git a/tests/geolocation.spec.ts b/tests/geolocation.spec.ts index ff195d3b95..3cbb8f1741 100644 --- a/tests/geolocation.spec.ts +++ b/tests/geolocation.spec.ts @@ -17,7 +17,7 @@ import { browserTest as it, expect } from './config/browserTest'; -it('should work #smoke', async ({ server, contextFactory }) => { +it('should work @smoke', async ({ server, contextFactory }) => { const context = await contextFactory(); const page = await context.newPage(); await context.grantPermissions(['geolocation']); diff --git a/tests/global-fetch.spec.ts b/tests/global-fetch.spec.ts index 2a67d1c72a..82bd8683eb 100644 --- a/tests/global-fetch.spec.ts +++ b/tests/global-fetch.spec.ts @@ -41,7 +41,7 @@ it.afterAll(() => { }); for (const method of ['fetch', 'delete', 'get', 'head', 'patch', 'post', 'put'] as const) { - it(`${method} should work #smoke`, async ({ playwright, server }) => { + it(`${method} should work @smoke`, async ({ playwright, server }) => { const request = await playwright.request.newContext(); const response = await request[method](server.PREFIX + '/simple.json'); expect(response.url()).toBe(server.PREFIX + '/simple.json'); diff --git a/tests/har.spec.ts b/tests/har.spec.ts index 6b0d4b2733..ead0a95770 100644 --- a/tests/har.spec.ts +++ b/tests/har.spec.ts @@ -245,7 +245,7 @@ it('should include secure set-cookies', async ({ contextFactory, httpsServer }, expect(cookies[0]).toEqual({ name: 'name1', value: 'value1', secure: true }); }); -it('should include content #smoke', async ({ contextFactory, server }, testInfo) => { +it('should include content @smoke', async ({ contextFactory, server }, testInfo) => { const { page, getLog } = await pageWithHar(contextFactory, testInfo); await page.goto(server.PREFIX + '/har.html'); const log = await getLog(); diff --git a/tests/headful.spec.ts b/tests/headful.spec.ts index 6ec0f589e8..5b5287456c 100644 --- a/tests/headful.spec.ts +++ b/tests/headful.spec.ts @@ -18,7 +18,7 @@ import pixelmatch from 'pixelmatch'; import { PNG } from 'pngjs'; import { expect, playwrightTest as it } from './config/browserTest'; -it('should have default url when launching browser #smoke', async ({ browserType, createUserDataDir }) => { +it('should have default url when launching browser @smoke', async ({ browserType, createUserDataDir }) => { const browserContext = await browserType.launchPersistentContext(await createUserDataDir(), { headless: false }); const urls = browserContext.pages().map(page => page.url()); expect(urls).toEqual(['about:blank']); diff --git a/tests/ignorehttpserrors.spec.ts b/tests/ignorehttpserrors.spec.ts index 947f6d33fd..71da9a92fe 100644 --- a/tests/ignorehttpserrors.spec.ts +++ b/tests/ignorehttpserrors.spec.ts @@ -17,7 +17,7 @@ import { browserTest as it, expect } from './config/browserTest'; -it('should work #smoke', async ({ browser, httpsServer }) => { +it('should work @smoke', async ({ browser, httpsServer }) => { let error = null; const context = await browser.newContext({ ignoreHTTPSErrors: true }); const page = await context.newPage(); diff --git a/tests/logger.spec.ts b/tests/logger.spec.ts index 8461601a7f..8b77d27c39 100644 --- a/tests/logger.spec.ts +++ b/tests/logger.spec.ts @@ -16,7 +16,7 @@ import { playwrightTest as it, expect } from './config/browserTest'; -it('should log #smoke', async ({ browserType }) => { +it('should log @smoke', async ({ browserType }) => { const log = []; const browser = await browserType.launch({ logger: { log: (name, severity, message) => log.push({ name, severity, message }), diff --git a/tests/page/elementhandle-click.spec.ts b/tests/page/elementhandle-click.spec.ts index a6e0366bf1..e9d16ef40f 100644 --- a/tests/page/elementhandle-click.spec.ts +++ b/tests/page/elementhandle-click.spec.ts @@ -17,7 +17,7 @@ import { test as it, expect } from './pageTest'; -it('should work #smoke', async ({ page, server }) => { +it('should work @smoke', async ({ page, server }) => { await page.goto(server.PREFIX + '/input/button.html'); const button = await page.$('button'); await button.click(); diff --git a/tests/page/elementhandle-scroll-into-view.spec.ts b/tests/page/elementhandle-scroll-into-view.spec.ts index fcdf8a6029..9c53c170ba 100644 --- a/tests/page/elementhandle-scroll-into-view.spec.ts +++ b/tests/page/elementhandle-scroll-into-view.spec.ts @@ -17,7 +17,7 @@ import { test as it, expect } from './pageTest'; -it('should work #smoke', async ({ page, server, isAndroid }) => { +it('should work @smoke', async ({ page, server, isAndroid }) => { it.fixme(isAndroid); await page.goto(server.PREFIX + '/offscreenbuttons.html'); diff --git a/tests/page/frame-evaluate.spec.ts b/tests/page/frame-evaluate.spec.ts index 93aac63247..b84ef28b22 100644 --- a/tests/page/frame-evaluate.spec.ts +++ b/tests/page/frame-evaluate.spec.ts @@ -28,7 +28,7 @@ it('should have different execution contexts', async ({ page, server }) => { expect(await page.frames()[1].evaluate(() => window['FOO'])).toBe('bar'); }); -it('should have correct execution contexts #smoke', async ({ page, server }) => { +it('should have correct execution contexts @smoke', async ({ page, server }) => { await page.goto(server.PREFIX + '/frames/one-frame.html'); expect(page.frames().length).toBe(2); expect(await page.frames()[0].evaluate(() => document.body.textContent.trim())).toBe(''); diff --git a/tests/page/frame-frame-element.spec.ts b/tests/page/frame-frame-element.spec.ts index 9388219515..ba59188c0c 100644 --- a/tests/page/frame-frame-element.spec.ts +++ b/tests/page/frame-frame-element.spec.ts @@ -18,7 +18,7 @@ import { test as it, expect } from './pageTest'; import { attachFrame } from '../config/utils'; -it('should work #smoke', async ({ page, server }) => { +it('should work @smoke', async ({ page, server }) => { await page.goto(server.EMPTY_PAGE); const frame1 = await attachFrame(page, 'frame1', server.EMPTY_PAGE); await attachFrame(page, 'frame2', server.EMPTY_PAGE); diff --git a/tests/page/frame-goto.spec.ts b/tests/page/frame-goto.spec.ts index d9061648b0..cb9620c6e6 100644 --- a/tests/page/frame-goto.spec.ts +++ b/tests/page/frame-goto.spec.ts @@ -18,7 +18,7 @@ import { test as it, expect } from './pageTest'; import { attachFrame } from '../config/utils'; -it('should navigate subframes #smoke', async ({ page, server }) => { +it('should navigate subframes @smoke', async ({ page, server }) => { await page.goto(server.PREFIX + '/frames/one-frame.html'); expect(page.frames()[0].url()).toContain('/frames/one-frame.html'); expect(page.frames()[1].url()).toContain('/frames/frame.html'); diff --git a/tests/page/frame-hierarchy.spec.ts b/tests/page/frame-hierarchy.spec.ts index 96b7c1a8c3..e69c3e4150 100644 --- a/tests/page/frame-hierarchy.spec.ts +++ b/tests/page/frame-hierarchy.spec.ts @@ -35,7 +35,7 @@ function dumpFrames(frame: Frame, indentation: string = ''): string[] { return result; } -it('should handle nested frames #smoke', async ({ page, server, isAndroid }) => { +it('should handle nested frames @smoke', async ({ page, server, isAndroid }) => { it.skip(isAndroid, 'No cross-process on Android'); await page.goto(server.PREFIX + '/frames/nested-frames.html'); diff --git a/tests/page/interception.spec.ts b/tests/page/interception.spec.ts index 949a151358..d01c1b93fc 100644 --- a/tests/page/interception.spec.ts +++ b/tests/page/interception.spec.ts @@ -19,7 +19,7 @@ import { test as it, expect } from './pageTest'; import { globToRegex } from '../../packages/playwright-core/lib/client/clientHelper'; import vm from 'vm'; -it('should work with navigation #smoke', async ({ page, server }) => { +it('should work with navigation @smoke', async ({ page, server }) => { const requests = new Map(); await page.route('**/*', route => { requests.set(route.request().url().split('/').pop(), route.request()); diff --git a/tests/page/jshandle-as-element.spec.ts b/tests/page/jshandle-as-element.spec.ts index ed1d97043c..1f37f8b633 100644 --- a/tests/page/jshandle-as-element.spec.ts +++ b/tests/page/jshandle-as-element.spec.ts @@ -17,7 +17,7 @@ import { test, expect } from './pageTest'; -test('should work #smoke', async ({ page }) => { +test('should work @smoke', async ({ page }) => { const aHandle = await page.evaluateHandle(() => document.body); const element = aHandle.asElement(); expect(element).toBeTruthy(); diff --git a/tests/page/jshandle-evaluate.spec.ts b/tests/page/jshandle-evaluate.spec.ts index bc0acbd725..bf58dea913 100644 --- a/tests/page/jshandle-evaluate.spec.ts +++ b/tests/page/jshandle-evaluate.spec.ts @@ -17,7 +17,7 @@ import { test as it, expect } from './pageTest'; -it('should work with function #smoke', async ({ page }) => { +it('should work with function @smoke', async ({ page }) => { const windowHandle = await page.evaluateHandle(() => { window['foo'] = [1, 2]; return window; diff --git a/tests/page/jshandle-json-value.spec.ts b/tests/page/jshandle-json-value.spec.ts index bcd6610b59..84979a628c 100644 --- a/tests/page/jshandle-json-value.spec.ts +++ b/tests/page/jshandle-json-value.spec.ts @@ -17,7 +17,7 @@ import { test as it, expect } from './pageTest'; -it('should work #smoke', async ({ page }) => { +it('should work @smoke', async ({ page }) => { const aHandle = await page.evaluateHandle(() => ({ foo: 'bar' })); const json = await aHandle.jsonValue(); expect(json).toEqual({ foo: 'bar' }); diff --git a/tests/page/jshandle-properties.spec.ts b/tests/page/jshandle-properties.spec.ts index fa23ae5d15..1b959e762d 100644 --- a/tests/page/jshandle-properties.spec.ts +++ b/tests/page/jshandle-properties.spec.ts @@ -18,7 +18,7 @@ import { test as it, expect } from './pageTest'; import type { ElementHandle } from 'playwright-core'; -it('should work #smoke', async ({ page }) => { +it('should work @smoke', async ({ page }) => { const aHandle = await page.evaluateHandle(() => ({ one: 1, two: 2, diff --git a/tests/page/jshandle-to-string.spec.ts b/tests/page/jshandle-to-string.spec.ts index 886f8efbc2..7dad97de63 100644 --- a/tests/page/jshandle-to-string.spec.ts +++ b/tests/page/jshandle-to-string.spec.ts @@ -39,7 +39,7 @@ it('should work for promises', async ({ page }) => { expect(bHandle.toString()).toBe('Promise'); }); -it('should work with different subtypes #smoke', async ({ page, browserName }) => { +it('should work with different subtypes @smoke', async ({ page, browserName }) => { expect((await page.evaluateHandle('(function(){})')).toString()).toContain('function'); expect((await page.evaluateHandle('12')).toString()).toBe('12'); expect((await page.evaluateHandle('true')).toString()).toBe('true'); diff --git a/tests/page/locator-click.spec.ts b/tests/page/locator-click.spec.ts index d3c9ad312e..0ab77324f0 100644 --- a/tests/page/locator-click.spec.ts +++ b/tests/page/locator-click.spec.ts @@ -17,7 +17,7 @@ import { test as it, expect } from './pageTest'; -it('should work #smoke', async ({ page, server }) => { +it('should work @smoke', async ({ page, server }) => { await page.goto(server.PREFIX + '/input/button.html'); const button = page.locator('button'); await button.click(); diff --git a/tests/page/locator-element-handle.spec.ts b/tests/page/locator-element-handle.spec.ts index 29f54451d9..68ff979266 100644 --- a/tests/page/locator-element-handle.spec.ts +++ b/tests/page/locator-element-handle.spec.ts @@ -17,7 +17,7 @@ import { test as it, expect } from './pageTest'; -it('should query existing element #smoke', async ({ page, server }) => { +it('should query existing element @smoke', async ({ page, server }) => { await page.goto(server.PREFIX + '/playground.html'); await page.setContent('
A
'); const html = page.locator('html'); diff --git a/tests/page/locator-evaluate.spec.ts b/tests/page/locator-evaluate.spec.ts index 5886bd4826..4f8a044ea9 100644 --- a/tests/page/locator-evaluate.spec.ts +++ b/tests/page/locator-evaluate.spec.ts @@ -17,7 +17,7 @@ import { test as it, expect } from './pageTest'; -it('should work #smoke', async ({ page, server }) => { +it('should work @smoke', async ({ page, server }) => { await page.setContent('
10
'); const tweet = page.locator('.tweet .like'); const content = await tweet.evaluate(node => (node as HTMLElement).innerText); diff --git a/tests/page/locator-frame.spec.ts b/tests/page/locator-frame.spec.ts index 3886ffcbfb..ad47b213ab 100644 --- a/tests/page/locator-frame.spec.ts +++ b/tests/page/locator-frame.spec.ts @@ -65,7 +65,7 @@ async function routeAmbiguous(page: Page) { }); } -it('should work for iframe #smoke', async ({ page, server }) => { +it('should work for iframe @smoke', async ({ page, server }) => { await routeIframe(page); await page.goto(server.EMPTY_PAGE); const button = page.frameLocator('iframe').locator('button'); diff --git a/tests/page/locator-misc-1.spec.ts b/tests/page/locator-misc-1.spec.ts index 7337abf659..d42f9e6c48 100644 --- a/tests/page/locator-misc-1.spec.ts +++ b/tests/page/locator-misc-1.spec.ts @@ -18,7 +18,7 @@ import { test as it, expect } from './pageTest'; import path from 'path'; -it('should hover #smoke', async ({ page, server }) => { +it('should hover @smoke', async ({ page, server }) => { await page.goto(server.PREFIX + '/input/scrollable.html'); const button = page.locator('#button-6'); await button.hover(); diff --git a/tests/page/locator-misc-2.spec.ts b/tests/page/locator-misc-2.spec.ts index 923fb62ffb..1e95974100 100644 --- a/tests/page/locator-misc-2.spec.ts +++ b/tests/page/locator-misc-2.spec.ts @@ -17,7 +17,7 @@ import { test as it, expect } from './pageTest'; -it('should press #smoke', async ({ page }) => { +it('should press @smoke', async ({ page }) => { await page.setContent(``); await page.locator('input').press('h'); expect(await page.$eval('input', input => input.value)).toBe('h'); diff --git a/tests/page/locator-query.spec.ts b/tests/page/locator-query.spec.ts index 47777667f2..1908070015 100644 --- a/tests/page/locator-query.spec.ts +++ b/tests/page/locator-query.spec.ts @@ -17,7 +17,7 @@ import { test as it, expect } from './pageTest'; -it('should respect first() and last() #smoke', async ({ page }) => { +it('should respect first() and last() @smoke', async ({ page }) => { await page.setContent(`

A

diff --git a/tests/page/network-post-data.spec.ts b/tests/page/network-post-data.spec.ts index 5b0665dda2..99a322840c 100644 --- a/tests/page/network-post-data.spec.ts +++ b/tests/page/network-post-data.spec.ts @@ -36,7 +36,7 @@ it('should return correct postData buffer for utf-8 body', async ({ page, server expect(request.postDataJSON()).toBe(value); }); -it('should return post data w/o content-type #smoke', async ({ page, server }) => { +it('should return post data w/o content-type @smoke', async ({ page, server }) => { await page.goto(server.EMPTY_PAGE); const [request] = await Promise.all([ page.waitForRequest('**'), diff --git a/tests/page/page-accessibility.spec.ts b/tests/page/page-accessibility.spec.ts index 2158554272..028162da98 100644 --- a/tests/page/page-accessibility.spec.ts +++ b/tests/page/page-accessibility.spec.ts @@ -18,7 +18,7 @@ import { test as it, expect } from './pageTest'; import { chromiumVersionLessThan } from '../config/utils'; -it('should work #smoke', async ({ page, browserName }) => { +it('should work @smoke', async ({ page, browserName }) => { await page.setContent(` Accessibility Test diff --git a/tests/page/page-add-init-script.spec.ts b/tests/page/page-add-init-script.spec.ts index aad23d5b11..0477e95c61 100644 --- a/tests/page/page-add-init-script.spec.ts +++ b/tests/page/page-add-init-script.spec.ts @@ -31,7 +31,7 @@ it('should work with a path', async ({ page, server, asset }) => { expect(await page.evaluate(() => window['result'])).toBe(123); }); -it('should work with content #smoke', async ({ page, server }) => { +it('should work with content @smoke', async ({ page, server }) => { await page.addInitScript({ content: 'window["injected"] = 123' }); await page.goto(server.PREFIX + '/tamperable.html'); expect(await page.evaluate(() => window['result'])).toBe(123); diff --git a/tests/page/page-add-style-tag.spec.ts b/tests/page/page-add-style-tag.spec.ts index 57370a655d..57446ac9ec 100644 --- a/tests/page/page-add-style-tag.spec.ts +++ b/tests/page/page-add-style-tag.spec.ts @@ -29,7 +29,7 @@ it('should throw an error if no options are provided', async ({ page, server }) expect(error.message).toContain('Provide an object with a `url`, `path` or `content` property'); }); -it('should work with a url #smoke', async ({ page, server }) => { +it('should work with a url @smoke', async ({ page, server }) => { await page.goto(server.EMPTY_PAGE); const styleHandle = await page.addStyleTag({ url: '/injectedstyle.css' }); expect(styleHandle.asElement()).not.toBeNull(); diff --git a/tests/page/page-check.spec.ts b/tests/page/page-check.spec.ts index 5f3ee1b88f..4af9c05ca3 100644 --- a/tests/page/page-check.spec.ts +++ b/tests/page/page-check.spec.ts @@ -17,7 +17,7 @@ import { test as it, expect } from './pageTest'; -it('should check the box #smoke', async ({ page }) => { +it('should check the box @smoke', async ({ page }) => { await page.setContent(``); await page.check('input'); expect(await page.evaluate(() => window['checkbox'].checked)).toBe(true); diff --git a/tests/page/page-click.spec.ts b/tests/page/page-click.spec.ts index 2facbb9b92..138ae7cae0 100644 --- a/tests/page/page-click.spec.ts +++ b/tests/page/page-click.spec.ts @@ -23,7 +23,7 @@ async function giveItAChanceToClick(page) { await page.evaluate(() => new Promise(f => requestAnimationFrame(() => requestAnimationFrame(f)))); } -it('should click the button #smoke', async ({ page, server }) => { +it('should click the button @smoke', async ({ page, server }) => { await page.goto(server.PREFIX + '/input/button.html'); await page.click('button'); expect(await page.evaluate('result')).toBe('Clicked'); diff --git a/tests/page/page-dialog.spec.ts b/tests/page/page-dialog.spec.ts index 1516a683c1..8940940a78 100644 --- a/tests/page/page-dialog.spec.ts +++ b/tests/page/page-dialog.spec.ts @@ -27,7 +27,7 @@ it('should fire', async ({ page, server }) => { await page.evaluate(() => alert('yo')); }); -it('should allow accepting prompts #smoke', async ({ page, isElectron }) => { +it('should allow accepting prompts @smoke', async ({ page, isElectron }) => { it.skip(isElectron, 'prompt() is not a thing in electron'); page.on('dialog', dialog => { diff --git a/tests/page/page-dispatchevent.spec.ts b/tests/page/page-dispatchevent.spec.ts index e765f33a8d..17e6a70184 100644 --- a/tests/page/page-dispatchevent.spec.ts +++ b/tests/page/page-dispatchevent.spec.ts @@ -16,7 +16,7 @@ import { test as it, expect } from './pageTest'; -it('should dispatch click event #smoke', async ({ page, server }) => { +it('should dispatch click event @smoke', async ({ page, server }) => { await page.goto(server.PREFIX + '/input/button.html'); await page.dispatchEvent('button', 'click'); expect(await page.evaluate(() => window['result'])).toBe('Clicked'); diff --git a/tests/page/page-drag.spec.ts b/tests/page/page-drag.spec.ts index 56b464845b..8b0c5443df 100644 --- a/tests/page/page-drag.spec.ts +++ b/tests/page/page-drag.spec.ts @@ -22,7 +22,7 @@ it.describe('Drag and drop', () => { it.skip(({ isAndroid }) => isAndroid); it.skip(({ browserName, browserMajorVersion }) => browserName === 'chromium' && browserMajorVersion < 91); - it('should work #smoke', async ({ page, server }) => { + it('should work @smoke', async ({ page, server }) => { await page.goto(server.PREFIX + '/drag-n-drop.html'); await page.hover('#source'); await page.mouse.down(); diff --git a/tests/page/page-emulate-media.spec.ts b/tests/page/page-emulate-media.spec.ts index b5480f5e65..fb84a73022 100644 --- a/tests/page/page-emulate-media.spec.ts +++ b/tests/page/page-emulate-media.spec.ts @@ -19,7 +19,7 @@ import { test as it, expect } from './pageTest'; it.skip(({ isAndroid }) => isAndroid); -it('should emulate type #smoke', async ({ page }) => { +it('should emulate type @smoke', async ({ page }) => { expect(await page.evaluate(() => matchMedia('screen').matches)).toBe(true); expect(await page.evaluate(() => matchMedia('print').matches)).toBe(false); await page.emulateMedia({ media: 'print' }); @@ -40,7 +40,7 @@ it('should throw in case of bad media argument', async ({ page }) => { expect(error.message).toContain('media: expected one of (screen|print|null)'); }); -it('should emulate colorScheme should work #smoke', async ({ page }) => { +it('should emulate colorScheme should work @smoke', async ({ page }) => { await page.emulateMedia({ colorScheme: 'light' }); expect(await page.evaluate(() => matchMedia('(prefers-color-scheme: light)').matches)).toBe(true); expect(await page.evaluate(() => matchMedia('(prefers-color-scheme: dark)').matches)).toBe(false); diff --git a/tests/page/page-evaluate.spec.ts b/tests/page/page-evaluate.spec.ts index fb1f8ae86a..21901d4dd0 100644 --- a/tests/page/page-evaluate.spec.ts +++ b/tests/page/page-evaluate.spec.ts @@ -18,7 +18,7 @@ import { attachFrame, detachFrame } from '../config/utils'; import { test as it, expect } from './pageTest'; -it('should work #smoke', async ({ page }) => { +it('should work @smoke', async ({ page }) => { const result = await page.evaluate(() => 7 * 3); expect(result).toBe(21); }); diff --git a/tests/page/page-event-console.spec.ts b/tests/page/page-event-console.spec.ts index 7c00cadffb..34adfc88a0 100644 --- a/tests/page/page-event-console.spec.ts +++ b/tests/page/page-event-console.spec.ts @@ -18,7 +18,7 @@ import { test as it, expect } from './pageTest'; import util from 'util'; -it('should work #smoke', async ({ page, browserName }) => { +it('should work @smoke', async ({ page, browserName }) => { let message = null; page.once('console', m => message = m); await Promise.all([ diff --git a/tests/page/page-event-network.spec.ts b/tests/page/page-event-network.spec.ts index 0ac53bc346..3b5a9641d6 100644 --- a/tests/page/page-event-network.spec.ts +++ b/tests/page/page-event-network.spec.ts @@ -18,7 +18,7 @@ import type { ServerResponse } from '../../utils/testserver'; import { test as it, expect } from './pageTest'; -it('Page.Events.Request #smoke', async ({ page, server }) => { +it('Page.Events.Request @smoke', async ({ page, server }) => { const requests = []; page.on('request', request => requests.push(request)); await page.goto(server.EMPTY_PAGE); @@ -31,7 +31,7 @@ it('Page.Events.Request #smoke', async ({ page, server }) => { expect(requests[0].frame().url()).toBe(server.EMPTY_PAGE); }); -it('Page.Events.Response #smoke', async ({ page, server }) => { +it('Page.Events.Response @smoke', async ({ page, server }) => { const responses = []; page.on('response', response => responses.push(response)); await page.goto(server.EMPTY_PAGE); @@ -42,7 +42,7 @@ it('Page.Events.Response #smoke', async ({ page, server }) => { expect(responses[0].request()).toBeTruthy(); }); -it('Page.Events.RequestFailed #smoke', async ({ page, server, browserName, isMac, isWindows }) => { +it('Page.Events.RequestFailed @smoke', async ({ page, server, browserName, isMac, isWindows }) => { server.setRoute('/one-style.css', (req, res) => { res.setHeader('Content-Type', 'text/css'); res.connection.destroy(); @@ -69,7 +69,7 @@ it('Page.Events.RequestFailed #smoke', async ({ page, server, browserName, isMac expect(failedRequests[0].frame()).toBeTruthy(); }); -it('Page.Events.RequestFinished #smoke', async ({ page, server }) => { +it('Page.Events.RequestFinished @smoke', async ({ page, server }) => { const [response] = await Promise.all([ page.goto(server.EMPTY_PAGE), page.waitForEvent('requestfinished') diff --git a/tests/page/page-event-popup.spec.ts b/tests/page/page-event-popup.spec.ts index a97675a1ca..d732f49071 100644 --- a/tests/page/page-event-popup.spec.ts +++ b/tests/page/page-event-popup.spec.ts @@ -16,7 +16,7 @@ import { test as it, expect } from './pageTest'; -it('should work #smoke', async ({ page }) => { +it('should work @smoke', async ({ page }) => { const [popup] = await Promise.all([ page.waitForEvent('popup'), page.evaluate(() => window['__popup'] = window.open('about:blank')), diff --git a/tests/page/page-expose-function.spec.ts b/tests/page/page-expose-function.spec.ts index 07f3b14967..c2ce11ebd6 100644 --- a/tests/page/page-expose-function.spec.ts +++ b/tests/page/page-expose-function.spec.ts @@ -18,7 +18,7 @@ import { test as it, expect } from './pageTest'; import type { ElementHandle } from 'playwright-core'; -it('exposeBinding should work #smoke', async ({ page }) => { +it('exposeBinding should work @smoke', async ({ page }) => { let bindingSource; await page.exposeBinding('add', (source, a, b) => { bindingSource = source; diff --git a/tests/page/page-fill.spec.ts b/tests/page/page-fill.spec.ts index b764cdcfe8..dc2e3afea9 100644 --- a/tests/page/page-fill.spec.ts +++ b/tests/page/page-fill.spec.ts @@ -24,7 +24,7 @@ async function giveItAChanceToFill(page) { await page.evaluate(() => new Promise(f => requestAnimationFrame(() => requestAnimationFrame(f)))); } -it('should fill textarea #smoke', async ({ page, server }) => { +it('should fill textarea @smoke', async ({ page, server }) => { await page.goto(server.PREFIX + '/input/textarea.html'); await page.fill('textarea', 'some value'); expect(await page.evaluate(() => window['result'])).toBe('some value'); diff --git a/tests/page/page-focus.spec.ts b/tests/page/page-focus.spec.ts index a1fcd4e23f..5fcc7c6ad8 100644 --- a/tests/page/page-focus.spec.ts +++ b/tests/page/page-focus.spec.ts @@ -16,7 +16,7 @@ import { test as it, expect } from './pageTest'; -it('should work #smoke', async function({ page, browserName }) { +it('should work @smoke', async function({ page, browserName }) { it.skip(browserName === 'firefox'); await page.setContent(`
`); diff --git a/tests/page/page-goto.spec.ts b/tests/page/page-goto.spec.ts index cc9cf337c2..2f0c5e2a49 100644 --- a/tests/page/page-goto.spec.ts +++ b/tests/page/page-goto.spec.ts @@ -20,7 +20,7 @@ import os from 'os'; import { test as it, expect } from './pageTest'; import { expectedSSLError } from '../config/utils'; -it('should work #smoke', async ({ page, server }) => { +it('should work @smoke', async ({ page, server }) => { await page.goto(server.EMPTY_PAGE); expect(page.url()).toBe(server.EMPTY_PAGE); }); diff --git a/tests/page/page-history.spec.ts b/tests/page/page-history.spec.ts index f207b6980a..b9dad63bf3 100644 --- a/tests/page/page-history.spec.ts +++ b/tests/page/page-history.spec.ts @@ -18,7 +18,7 @@ import { test as it, expect } from './pageTest'; import url from 'url'; -it('page.goBack should work #smoke', async ({ page, server }) => { +it('page.goBack should work @smoke', async ({ page, server }) => { expect(await page.goBack()).toBe(null); await page.goto(server.EMPTY_PAGE); diff --git a/tests/page/page-keyboard.spec.ts b/tests/page/page-keyboard.spec.ts index 29638647dc..5866118ead 100644 --- a/tests/page/page-keyboard.spec.ts +++ b/tests/page/page-keyboard.spec.ts @@ -20,7 +20,7 @@ import { attachFrame } from '../config/utils'; it.skip(({ isAndroid }) => isAndroid); -it('should type into a textarea #smoke', async ({ page }) => { +it('should type into a textarea @smoke', async ({ page }) => { await page.evaluate(() => { const textarea = document.createElement('textarea'); document.body.appendChild(textarea); diff --git a/tests/page/page-mouse.spec.ts b/tests/page/page-mouse.spec.ts index 6b0bc5c172..8a914f886e 100644 --- a/tests/page/page-mouse.spec.ts +++ b/tests/page/page-mouse.spec.ts @@ -27,7 +27,7 @@ function dimensions() { }; } -it('should click the document #smoke', async ({ page, server }) => { +it('should click the document @smoke', async ({ page, server }) => { await page.evaluate(() => { window['clickPromise'] = new Promise(resolve => { document.addEventListener('click', event => { diff --git a/tests/page/page-network-request.spec.ts b/tests/page/page-network-request.spec.ts index 1f29f21334..94d24241a1 100644 --- a/tests/page/page-network-request.spec.ts +++ b/tests/page/page-network-request.spec.ts @@ -35,7 +35,7 @@ it('should work for subframe navigation request', async ({ page, server }) => { expect(requests[0].frame()).toBe(page.frames()[1]); }); -it('should work for fetch requests #smoke', async ({ page, server }) => { +it('should work for fetch requests @smoke', async ({ page, server }) => { await page.goto(server.EMPTY_PAGE); const requests = []; page.on('request', request => requests.push(request)); diff --git a/tests/page/page-network-response.spec.ts b/tests/page/page-network-response.spec.ts index 3ae59fde43..eca26785ae 100644 --- a/tests/page/page-network-response.spec.ts +++ b/tests/page/page-network-response.spec.ts @@ -19,7 +19,7 @@ import fs from 'fs'; import url from 'url'; import { expect, test as it } from './pageTest'; -it('should work #smoke', async ({ page, server }) => { +it('should work @smoke', async ({ page, server }) => { server.setRoute('/empty.html', (req, res) => { res.setHeader('foo', 'bar'); res.setHeader('BaZ', 'bAz'); diff --git a/tests/page/page-route.spec.ts b/tests/page/page-route.spec.ts index 23d7ee4a1b..9e04690b8f 100644 --- a/tests/page/page-route.spec.ts +++ b/tests/page/page-route.spec.ts @@ -18,7 +18,7 @@ import { Route } from 'playwright-core'; import { test as it, expect } from './pageTest'; -it('should intercept #smoke', async ({ page, server }) => { +it('should intercept @smoke', async ({ page, server }) => { let intercepted = false; await page.route('**/empty.html', (route, request) => { expect(route.request()).toBe(request); diff --git a/tests/page/page-screenshot.spec.ts b/tests/page/page-screenshot.spec.ts index 312553264b..9d8d7eca7b 100644 --- a/tests/page/page-screenshot.spec.ts +++ b/tests/page/page-screenshot.spec.ts @@ -25,7 +25,7 @@ it.describe('page screenshot', () => { it.skip(({ browserName, headless }) => browserName === 'firefox' && !headless, 'Firefox headed produces a different image.'); it.skip(({ isAndroid }) => isAndroid, 'Different viewport'); - it('should work #smoke', async ({ page, server }) => { + it('should work @smoke', async ({ page, server }) => { await page.setViewportSize({ width: 500, height: 500 }); await page.goto(server.PREFIX + '/grid.html'); const screenshot = await page.screenshot(); diff --git a/tests/page/page-select-option.spec.ts b/tests/page/page-select-option.spec.ts index 49d094ea09..ab32c03f0a 100644 --- a/tests/page/page-select-option.spec.ts +++ b/tests/page/page-select-option.spec.ts @@ -22,7 +22,7 @@ async function giveItAChanceToResolve(page) { await page.evaluate(() => new Promise(f => requestAnimationFrame(() => requestAnimationFrame(f)))); } -it('should select single option #smoke', async ({ page, server }) => { +it('should select single option @smoke', async ({ page, server }) => { await page.goto(server.PREFIX + '/input/select.html'); await page.selectOption('select', 'blue'); expect(await page.evaluate(() => window['result'].onInput)).toEqual(['blue']); diff --git a/tests/page/page-set-content.spec.ts b/tests/page/page-set-content.spec.ts index 07e2b1ff19..2d8d87a511 100644 --- a/tests/page/page-set-content.spec.ts +++ b/tests/page/page-set-content.spec.ts @@ -19,7 +19,7 @@ import { test as it, expect } from './pageTest'; const expectedOutput = '
hello
'; -it('should work #smoke', async ({ page, server }) => { +it('should work @smoke', async ({ page, server }) => { await page.setContent('
hello
'); const result = await page.content(); expect(result).toBe(expectedOutput); diff --git a/tests/page/page-set-extra-http-headers.spec.ts b/tests/page/page-set-extra-http-headers.spec.ts index 3e2e5b177a..284621edd6 100644 --- a/tests/page/page-set-extra-http-headers.spec.ts +++ b/tests/page/page-set-extra-http-headers.spec.ts @@ -17,7 +17,7 @@ import { test as it, expect } from './pageTest'; -it('should work #smoke', async ({ page, server }) => { +it('should work @smoke', async ({ page, server }) => { await page.setExtraHTTPHeaders({ foo: 'bar', }); diff --git a/tests/page/page-set-input-files.spec.ts b/tests/page/page-set-input-files.spec.ts index b3137b2e85..9575386f75 100644 --- a/tests/page/page-set-input-files.spec.ts +++ b/tests/page/page-set-input-files.spec.ts @@ -36,7 +36,7 @@ it('should upload the file', async ({ page, server, asset }) => { }, input)).toBe('contents of the file'); }); -it('should work #smoke', async ({ page, asset }) => { +it('should work @smoke', async ({ page, asset }) => { await page.setContent(``); await page.setInputFiles('input', asset('file-to-upload.txt')); expect(await page.$eval('input', input => input.files.length)).toBe(1); diff --git a/tests/page/queryselector.spec.ts b/tests/page/queryselector.spec.ts index 572a8e9631..79d300596a 100644 --- a/tests/page/queryselector.spec.ts +++ b/tests/page/queryselector.spec.ts @@ -22,7 +22,7 @@ it('should throw for non-string selector', async ({ page }) => { expect(error.message).toContain('selector: expected string, got object'); }); -it('should query existing element with css selector #smoke', async ({ page, server }) => { +it('should query existing element with css selector @smoke', async ({ page, server }) => { await page.setContent('
test
'); const element = await page.$('css=section'); expect(element).toBeTruthy(); diff --git a/tests/page/selectors-css.spec.ts b/tests/page/selectors-css.spec.ts index 5f644b65e1..37d09afc08 100644 --- a/tests/page/selectors-css.spec.ts +++ b/tests/page/selectors-css.spec.ts @@ -17,7 +17,7 @@ import { test as it, expect } from './pageTest'; -it('should work with large DOM #smoke', async ({ page, server }) => { +it('should work with large DOM @smoke', async ({ page, server }) => { await page.evaluate(() => { let id = 0; const next = (tag: string) => { diff --git a/tests/page/selectors-frame.spec.ts b/tests/page/selectors-frame.spec.ts index 12988fa1ad..9003e3e5e6 100644 --- a/tests/page/selectors-frame.spec.ts +++ b/tests/page/selectors-frame.spec.ts @@ -46,7 +46,7 @@ async function routeIframe(page: Page) { }); } -it('should work for iframe #smoke', async ({ page, server }) => { +it('should work for iframe @smoke', async ({ page, server }) => { await routeIframe(page); await page.goto(server.EMPTY_PAGE); const button = page.locator('iframe >> control=enter-frame >> button'); diff --git a/tests/page/selectors-react.spec.ts b/tests/page/selectors-react.spec.ts index af1513f2bb..a3d6788f00 100644 --- a/tests/page/selectors-react.spec.ts +++ b/tests/page/selectors-react.spec.ts @@ -29,7 +29,7 @@ for (const [name, url] of Object.entries(reacts)) { await page.goto(server.PREFIX + url); }); - it('should work with single-root elements #smoke', async ({ page }) => { + it('should work with single-root elements @smoke', async ({ page }) => { expect(await page.$$eval(`_react=BookList`, els => els.length)).toBe(1); expect(await page.$$eval(`_react=BookItem`, els => els.length)).toBe(3); expect(await page.$$eval(`_react=BookList >> _react=BookItem`, els => els.length)).toBe(3); diff --git a/tests/page/selectors-text.spec.ts b/tests/page/selectors-text.spec.ts index e0c1e6547a..f837b7b1ef 100644 --- a/tests/page/selectors-text.spec.ts +++ b/tests/page/selectors-text.spec.ts @@ -17,7 +17,7 @@ import { test as it, expect } from './pageTest'; -it('should work #smoke', async ({ page }) => { +it('should work @smoke', async ({ page }) => { await page.setContent(`
yo
ya
\nye
`); expect(await page.$eval(`text=ya`, e => e.outerHTML)).toBe('
ya
'); expect(await page.$eval(`text="ya"`, e => e.outerHTML)).toBe('
ya
'); diff --git a/tests/page/selectors-vue.spec.ts b/tests/page/selectors-vue.spec.ts index 87c7cc6b1f..239632404a 100644 --- a/tests/page/selectors-vue.spec.ts +++ b/tests/page/selectors-vue.spec.ts @@ -28,7 +28,7 @@ for (const [name, url] of Object.entries(vues)) { await page.goto(server.PREFIX + url); }); - it('should work with single-root elements #smoke', async ({ page }) => { + it('should work with single-root elements @smoke', async ({ page }) => { expect(await page.$$eval(`_vue=book-list`, els => els.length)).toBe(1); expect(await page.$$eval(`_vue=book-item`, els => els.length)).toBe(3); expect(await page.$$eval(`_vue=book-list >> _vue=book-item`, els => els.length)).toBe(3); diff --git a/tests/page/wheel.spec.ts b/tests/page/wheel.spec.ts index b4252bca2c..ef34ba735e 100644 --- a/tests/page/wheel.spec.ts +++ b/tests/page/wheel.spec.ts @@ -20,7 +20,7 @@ it.skip(({ isElectron, browserMajorVersion, isAndroid }) => { // Old Electron has flaky wheel events. return (isElectron && browserMajorVersion <= 11) || isAndroid; }); -it('should dispatch wheel events #smoke', async ({ page, server }) => { +it('should dispatch wheel events @smoke', async ({ page, server }) => { await page.setContent(`
`); await page.mouse.move(50, 60); await listenForWheelEvents(page, 'div'); diff --git a/tests/page/workers.spec.ts b/tests/page/workers.spec.ts index b14afeccc1..3d6f5d3e6c 100644 --- a/tests/page/workers.spec.ts +++ b/tests/page/workers.spec.ts @@ -19,7 +19,7 @@ import { test as it, expect } from './pageTest'; import { attachFrame } from '../config/utils'; import type { ConsoleMessage } from 'playwright-core'; -it('Page.workers #smoke', async function({ page, server }) { +it('Page.workers @smoke', async function({ page, server }) { await Promise.all([ page.waitForEvent('worker'), page.goto(server.PREFIX + '/worker/worker.html')]); diff --git a/tests/popup.spec.ts b/tests/popup.spec.ts index 0a3f63660c..5b631fb9f9 100644 --- a/tests/popup.spec.ts +++ b/tests/popup.spec.ts @@ -16,7 +16,7 @@ import { browserTest as it, expect } from './config/browserTest'; -it('should inherit user agent from browser context #smoke', async function({ browser, server }) { +it('should inherit user agent from browser context @smoke', async function({ browser, server }) { const context = await browser.newContext({ userAgent: 'hey' }); diff --git a/tests/port-forwarding-server.spec.ts b/tests/port-forwarding-server.spec.ts index 5b3d8faa3e..3310989253 100644 --- a/tests/port-forwarding-server.spec.ts +++ b/tests/port-forwarding-server.spec.ts @@ -108,7 +108,7 @@ it('should forward non-forwarded requests', async ({ pageFactory, server }) => { expect(reachedOriginalTarget).toBe(true); }); -it('should proxy localhost requests #smoke', async ({ pageFactory, server, browserName, platform }, workerInfo) => { +it('should proxy localhost requests @smoke', async ({ pageFactory, server, browserName, platform }, workerInfo) => { it.skip(browserName === 'webkit' && platform === 'darwin'); const { testServerPort, stopTestServer } = await startTestServer(); let reachedOriginalTarget = false; diff --git a/tests/proxy.spec.ts b/tests/proxy.spec.ts index 8a55486e43..26e898335c 100644 --- a/tests/proxy.spec.ts +++ b/tests/proxy.spec.ts @@ -28,7 +28,7 @@ it('should throw for bad server value', async ({ browserType }) => { expect(error.message).toContain('proxy.server: expected string, got number'); }); -it('should use proxy #smoke', async ({ browserType, server }) => { +it('should use proxy @smoke', async ({ browserType, server }) => { server.setRoute('/target.html', async (req, res) => { res.end('Served by the proxy'); }); diff --git a/tests/resource-timing.spec.ts b/tests/resource-timing.spec.ts index c5256b8c11..ab4c9a00d9 100644 --- a/tests/resource-timing.spec.ts +++ b/tests/resource-timing.spec.ts @@ -17,7 +17,7 @@ import { browserTest as it, expect } from './config/browserTest'; -it('should work #smoke', async ({ contextFactory, server }) => { +it('should work @smoke', async ({ contextFactory, server }) => { const context = await contextFactory(); const page = await context.newPage(); const [request] = await Promise.all([ diff --git a/tests/tap.spec.ts b/tests/tap.spec.ts index e5559b01cd..efd4556f7d 100644 --- a/tests/tap.spec.ts +++ b/tests/tap.spec.ts @@ -20,7 +20,7 @@ import type { ServerResponse } from 'http'; it.use({ hasTouch: true }); -it('should send all of the correct events #smoke', async ({ page }) => { +it('should send all of the correct events @smoke', async ({ page }) => { await page.setContent(`
a
b
diff --git a/tests/video.spec.ts b/tests/video.spec.ts index fff2397785..9ee89f08ac 100644 --- a/tests/video.spec.ts +++ b/tests/video.spec.ts @@ -508,7 +508,7 @@ it.describe('screencast', () => { expect(videoPlayer.videoHeight).toBe(600); }); - it('should capture static page in persistent context #smoke', async ({ launchPersistent, browserName, trace }, testInfo) => { + it('should capture static page in persistent context @smoke', async ({ launchPersistent, browserName, trace }, testInfo) => { it.fixme(browserName === 'firefox' && trace === 'on', 'https://github.com/microsoft/playwright/issues/10060'); const size = { width: 320, height: 240 }; const { context, page } = await launchPersistent({ diff --git a/tests/web-socket.spec.ts b/tests/web-socket.spec.ts index 83ed07c08f..6aaec2d0af 100644 --- a/tests/web-socket.spec.ts +++ b/tests/web-socket.spec.ts @@ -18,7 +18,7 @@ import { contextTest as it, expect } from './config/browserTest'; import { Server as WebSocketServer } from 'ws'; -it('should work #smoke', async ({ page, server }) => { +it('should work @smoke', async ({ page, server }) => { server.sendOnWebSocketConnection('incoming'); const value = await page.evaluate(port => { let cb;