From 91ba44c46f634cd462164832d11c39a631368bf0 Mon Sep 17 00:00:00 2001
From: Simon Knott <info@simonknott.de>
Date: Thu, 18 Jul 2024 10:12:01 +0200
Subject: [PATCH] Revert "propagate --onlyChanged through UI"

This reverts commit bfe75e45f4bd7827788531e0756ed989b1d298f5.
---
 .../playwright-core/src/server/trace/viewer/traceViewer.ts     | 3 ---
 packages/playwright/src/isomorphic/testServerInterface.ts      | 1 -
 packages/playwright/src/program.ts                             | 3 +--
 packages/playwright/src/runner/testServer.ts                   | 1 -
 packages/trace-viewer/src/ui/uiModeView.tsx                    | 2 --
 5 files changed, 1 insertion(+), 9 deletions(-)

diff --git a/packages/playwright-core/src/server/trace/viewer/traceViewer.ts b/packages/playwright-core/src/server/trace/viewer/traceViewer.ts
index 500381f657..d053a3e643 100644
--- a/packages/playwright-core/src/server/trace/viewer/traceViewer.ts
+++ b/packages/playwright-core/src/server/trace/viewer/traceViewer.ts
@@ -39,7 +39,6 @@ export type TraceViewerRedirectOptions = {
   args?: string[];
   grep?: string;
   grepInvert?: string;
-  onlyChanged?: string;
   project?: string[];
   workers?: number | string;
   headed?: boolean;
@@ -124,8 +123,6 @@ export async function installRootRedirect(server: HttpServer, traceUrls: string[
     params.append('grep', options.grep);
   if (options.grepInvert)
     params.append('grepInvert', options.grepInvert);
-  if (options.onlyChanged)
-    params.append('onlyChanged', options.onlyChanged);
   for (const project of options.project || [])
     params.append('project', project);
   if (options.workers)
diff --git a/packages/playwright/src/isomorphic/testServerInterface.ts b/packages/playwright/src/isomorphic/testServerInterface.ts
index 90e177ab54..ac06f65c24 100644
--- a/packages/playwright/src/isomorphic/testServerInterface.ts
+++ b/packages/playwright/src/isomorphic/testServerInterface.ts
@@ -88,7 +88,6 @@ export interface TestServerInterface {
     locations?: string[];
     grep?: string;
     grepInvert?: string;
-    onlyChanged?: string;
     testIds?: string[];
     headed?: boolean;
     workers?: number | string;
diff --git a/packages/playwright/src/program.ts b/packages/playwright/src/program.ts
index fde44aae91..d494602dc8 100644
--- a/packages/playwright/src/program.ts
+++ b/packages/playwright/src/program.ts
@@ -164,7 +164,6 @@ async function runTests(args: string[], opts: { [key: string]: any }) {
       args,
       grep: opts.grep as string | undefined,
       grepInvert: opts.grepInvert as string | undefined,
-      onlyChanged: opts.onlyChanged === true ? 'HEAD' : opts.onlyChanged,
       project: opts.project || undefined,
       headed: opts.headed,
       reporter: Array.isArray(opts.reporter) ? opts.reporter : opts.reporter ? [opts.reporter] : undefined,
@@ -192,7 +191,7 @@ async function runTests(args: string[], opts: { [key: string]: any }) {
 
   config.cliArgs = args;
   config.cliGrep = opts.grep as string | undefined;
-  config.cliOnlyChanged = getOnlyChangedArg(opts.onlyChanged);
+  config.cliOnlyChanged = opts.onlyChanged === true ? 'HEAD' : opts.onlyChanged;
   config.cliGrepInvert = opts.grepInvert as string | undefined;
   config.cliListOnly = !!opts.list;
   config.cliProjectFilter = opts.project || undefined;
diff --git a/packages/playwright/src/runner/testServer.ts b/packages/playwright/src/runner/testServer.ts
index 8c3de2a61e..c5133df3eb 100644
--- a/packages/playwright/src/runner/testServer.ts
+++ b/packages/playwright/src/runner/testServer.ts
@@ -335,7 +335,6 @@ class TestServerDispatcher implements TestServerInterface {
     config.cliArgs = params.locations || [];
     config.cliGrep = params.grep;
     config.cliGrepInvert = params.grepInvert;
-    config.cliOnlyChanged = params.onlyChanged;
     config.cliProjectFilter = params.projects?.length ? params.projects : undefined;
     config.testIdMatcher = testIdSet ? id => testIdSet.has(id) : undefined;
 
diff --git a/packages/trace-viewer/src/ui/uiModeView.tsx b/packages/trace-viewer/src/ui/uiModeView.tsx
index 22bfcaf4d8..c626c862c9 100644
--- a/packages/trace-viewer/src/ui/uiModeView.tsx
+++ b/packages/trace-viewer/src/ui/uiModeView.tsx
@@ -56,7 +56,6 @@ const queryParams = {
   args: searchParams.getAll('arg'),
   grep: searchParams.get('grep') || undefined,
   grepInvert: searchParams.get('grepInvert') || undefined,
-  onlyChanged: searchParams.get('onlyChanged') || undefined,
   projects: searchParams.getAll('project'),
   workers: searchParams.get('workers') || undefined,
   timeout: searchParams.has('timeout') ? +searchParams.get('timeout')! : undefined,
@@ -283,7 +282,6 @@ export const UIModeView: React.FC<{}> = ({
         locations: queryParams.args,
         grep: queryParams.grep,
         grepInvert: queryParams.grepInvert,
-        onlyChanged: queryParams.onlyChanged,
         testIds: [...testIds],
         projects: [...projectFilters].filter(([_, v]) => v).map(([p]) => p),
         workers: queryParams.workers,